Bug 1590907 - Remove obsolete macro MOZ_HAVE_BITSCAN64. r=froydnj
authorPhilip Chimento <philip.chimento@gmail.com>
Tue, 12 Nov 2019 21:59:25 +0000
changeset 501681 b98e3a2058c06d33994a43e5637009fc910968eb
parent 501680 bedd96446c984c7bee5dae402274e0427a42cb98
child 501682 41cd25e887f099990d5579ab417823c73fe244c6
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1590907, 772469
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1590907 - Remove obsolete macro MOZ_HAVE_BITSCAN64. r=froydnj This macro seems to have been introduced in https://bugzilla.mozilla.org/attachment.cgi?id=772469&action=diff but there doesn't seem to be any mention of it anywhere else. Currently it's only checked in order to #undef it if it's defined. Differential Revision: https://phabricator.services.mozilla.com/D51770
mfbt/MathAlgorithms.h
--- a/mfbt/MathAlgorithms.h
+++ b/mfbt/MathAlgorithms.h
@@ -240,20 +240,16 @@ inline uint_fast8_t CountTrailingZeroes6
   uint32_t lo = uint32_t(aValue);
   if (lo != 0) {
     return CountTrailingZeroes32(lo);
   }
   return 32u + CountTrailingZeroes32(uint32_t(aValue >> 32));
 #  endif
 }
 
-#  ifdef MOZ_HAVE_BITSCAN64
-#    undef MOZ_HAVE_BITSCAN64
-#  endif
-
 #elif defined(__clang__) || defined(__GNUC__)
 
 #  if defined(__clang__)
 #    if !__has_builtin(__builtin_ctz) || !__has_builtin(__builtin_clz)
 #      error "A clang providing __builtin_c[lt]z is required to build"
 #    endif
 #  else
 // gcc has had __builtin_clz and friends since 3.4: no need to check.