Bug 1543324 - Part 3: Remove --theme-comment-alt variable; r=ntim
authorFlorens Verschelde <florens@fvsch.com>
Thu, 18 Apr 2019 19:17:03 +0000
changeset 470135 b92e12f815e1afe5ce87a588e05b906c15a364e3
parent 470134 59d2894daa38d968b8ea1c1cf22522959e0037a6
child 470136 8c2c3afe6a3d8b0d32c77aef1c1ca718326632b0
push id112843
push useraiakab@mozilla.com
push dateFri, 19 Apr 2019 09:50:22 +0000
treeherdermozilla-inbound@c06f27cbfe40 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersntim
bugs1543324
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1543324 - Part 3: Remove --theme-comment-alt variable; r=ntim Differential Revision: https://phabricator.services.mozilla.com/D27108
devtools/client/debugger/src/components/Editor/Highlight.css
devtools/client/debugger/src/components/Editor/Preview.css
devtools/client/debugger/src/components/Editor/Preview/Popup.css
devtools/client/debugger/src/components/SecondaryPanes/CommandBar.css
devtools/client/debugger/src/components/shared/ResultList.css
devtools/client/inspector/layout/components/Accordion.css
devtools/client/shared/sourceeditor/codemirror/mozilla.css
devtools/client/themes/variables.css
--- a/devtools/client/debugger/src/components/Editor/Highlight.css
+++ b/devtools/client/debugger/src/components/Editor/Highlight.css
@@ -5,25 +5,25 @@
 .cm-highlight {
   position: relative;
 }
 
 .cm-highlight::before {
   position: absolute;
   border-top-style: solid;
   border-bottom-style: solid;
-  border-top-color: var(--theme-comment-alt);
-  border-bottom-color: var(--theme-comment-alt);
+  border-top-color: var(--theme-text-color-inactive);
+  border-bottom-color: var(--theme-text-color-inactive);
   border-top-width: 1px;
   border-bottom-width: 1px;
   top: -1px;
   bottom: 0;
   left: 0;
   right: 0;
   content: "";
   margin-bottom: -1px;
 }
 
 .cm-highlight-full::before {
-  border: 1px solid var(--theme-comment-alt);
+  border: 1px solid var(--theme-text-color-inactive);
   border-radius: 2px;
   margin: 0 -1px -1px -1px;
 }
--- a/devtools/client/debugger/src/components/Editor/Preview.css
+++ b/devtools/client/debugger/src/components/Editor/Preview.css
@@ -90,17 +90,17 @@
   display: -ms-flexbox;
   display: flex;
   -webkit-box-align: center;
   -ms-flex-align: center;
   align-items: center;
   font-size: 14px;
   line-height: 30px;
   background: var(--theme-toolbar-background);
-  color: var(--theme-comment-alt);
+  color: var(--theme-text-color-inactive);
   padding: 0 4px;
 }
 
 .add-to-expression-bar .prompt {
   width: 1em;
 }
 
 .add-to-expression-bar .expression-to-save-label {
--- a/devtools/client/debugger/src/components/Editor/Preview/Popup.css
+++ b/devtools/client/debugger/src/components/Editor/Preview/Popup.css
@@ -105,17 +105,17 @@
   display: -ms-flexbox;
   display: flex;
   -webkit-box-align: center;
   -ms-flex-align: center;
   align-items: center;
   font-size: 14px;
   line-height: 30px;
   background: var(--theme-toolbar-background);
-  color: var(--theme-comment-alt);
+  color: var(--theme-text-color-inactive);
   padding: 0 4px;
 }
 
 .add-to-expression-bar .prompt {
   width: 1em;
 }
 
 .add-to-expression-bar .expression-to-save-label {
--- a/devtools/client/debugger/src/components/SecondaryPanes/CommandBar.css
+++ b/devtools/client/debugger/src/components/SecondaryPanes/CommandBar.css
@@ -23,17 +23,17 @@ html[dir="rtl"] .command-bar {
   flex-grow: 1;
 }
 
 .command-bar .replay-inactive {
   opacity: 0.5;
 }
 
 .command-bar .step-position {
-  color: var(--theme-comment-alt);
+  color: var(--theme-text-color-inactive);
   padding-top: 8px;
   margin-inline-end: 4px;
 }
 
 .command-bar .replay-active {
   color: var(--theme-highlight-blue);
 }
 
--- a/devtools/client/debugger/src/components/shared/ResultList.css
+++ b/devtools/client/debugger/src/components/shared/ResultList.css
@@ -119,17 +119,17 @@
   white-space: nowrap;
 }
 
 .theme-dark .result-list.big li.selected .subtitle {
   color: white;
 }
 
 .theme-dark .result-list.big li .subtitle {
-  color: var(--theme-comment-alt);
+  color: var(--theme-text-color-inactive);
 }
 
 .search-bar .result-list li.selected .subtitle {
   color: white;
 }
 
 .search-bar .result-list {
   border-bottom: 1px solid var(--theme-splitter-color);
--- a/devtools/client/inspector/layout/components/Accordion.css
+++ b/devtools/client/inspector/layout/components/Accordion.css
@@ -38,17 +38,17 @@
   -moz-user-select: none;
 }
 
 .accordion ._header:hover {
   background-color: var(--theme-toolbar-hover);
 }
 
 .accordion ._header:hover svg {
-  fill: var(--theme-comment-alt);
+  fill: var(--theme-text-color-inactive);
 }
 
 .accordion ._header .truncate {
   display: block;
   overflow: hidden;
   white-space: nowrap;
   text-overflow: ellipsis;
 }
--- a/devtools/client/shared/sourceeditor/codemirror/mozilla.css
+++ b/devtools/client/shared/sourceeditor/codemirror/mozilla.css
@@ -99,45 +99,45 @@
 .cm-highlight {
   position: relative;
 }
 
 .cm-highlight:before {
   position: absolute;
   border-top-style: solid;
   border-bottom-style: solid;
-  border-top-color: var(--theme-comment-alt);
-  border-bottom-color: var(--theme-comment-alt);
+  border-top-color: var(--theme-text-color-inactive);
+  border-bottom-color: var(--theme-text-color-inactive);
   border-top-width: 1px;
   border-bottom-width: 1px;
   top: -1px;
   bottom: 0;
   left: 0;
   right: 0;
   content: "";
   margin-bottom: -1px;
 }
 
 .cm-highlight-full:before {
-  border: 1px solid var(--theme-comment-alt);
+  border: 1px solid var(--theme-text-color-inactive);
 }
 
 .cm-highlight-start:before {
   border-left-width: 1px;
   border-left-style: solid;
-  border-left-color: var(--theme-comment-alt);
+  border-left-color: var(--theme-text-color-inactive);
   margin: 0 0 -1px -1px;
   border-top-left-radius: 2px;
   border-bottom-left-radius: 2px;
 }
 
 .cm-highlight-end:before {
   border-right-width: 1px;
   border-right-style: solid;
-  border-right-color: var(--theme-comment-alt);
+  border-right-color: var(--theme-text-color-inactive);
   margin: 0 -1px -1px 0;
   border-top-right-radius: 2px;
   border-bottom-right-radius: 2px;
 }
 
 /* CodeMirror dialogs styling */
 
 .CodeMirror-dialog {
--- a/devtools/client/themes/variables.css
+++ b/devtools/client/themes/variables.css
@@ -48,17 +48,16 @@
 
   /* Icon colors */
   --theme-icon-color: rgba(12, 12, 13, 0.8);
   --theme-icon-dimmed-color: rgba(135, 135, 137, 0.9);
   --theme-icon-checked-color: var(--blue-60);
 
   /* Text color */
   --theme-comment: var(--grey-50);
-  --theme-comment-alt: var(--grey-40);
   --theme-body-color: var(--grey-60);
   --theme-text-color-alt: var(--grey-50);
   --theme-text-color-inactive: var(--grey-40);
   --theme-text-color-strong: var(--grey-80);
 
   --theme-highlight-green: var(--green-70);
   --theme-highlight-blue: var(--blue-55);
   --theme-highlight-purple: var(--blue-70);
@@ -139,17 +138,16 @@
 
   /* Icon colors */
   --theme-icon-color: rgba(249, 249, 250, 0.7);
   --theme-icon-dimmed-color: rgba(147, 147, 149, 0.9);
   --theme-icon-checked-color: var(--blue-30);
 
   /* Text color */
   --theme-comment: var(--grey-45);
-  --theme-comment-alt: var(--grey-50);
   --theme-body-color: var(--grey-40);
   --theme-text-color-alt: var(--grey-45);
   --theme-text-color-inactive: var(--grey-50);
   --theme-text-color-strong: var(--grey-30);
 
   --theme-highlight-green: #86DE74;
   --theme-highlight-blue: #75BFFF;
   --theme-highlight-purple: #B98EFF;