Backed out changeset 8eb0c588a43e (bug 1378218) for frequent win debug xpcshell failures in test_sanitizer.js a=backout
authorWes Kocher <wkocher@mozilla.com>
Wed, 05 Jul 2017 15:08:13 -0700
changeset 367446 b7373e1df03eac30bca7b882a352a7282775059e
parent 367445 f897e328d8aaf63713f6cb9b1aa703c97dcc7990
child 367447 251b82b42ba23763f559122b72ce20341ed43096
push id92240
push userkwierso@gmail.com
push dateWed, 05 Jul 2017 22:08:19 +0000
treeherdermozilla-inbound@b7373e1df03e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1378218
milestone56.0a1
backs out8eb0c588a43e2dd84638c60b8cdf66a845c5f6b9
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 8eb0c588a43e (bug 1378218) for frequent win debug xpcshell failures in test_sanitizer.js a=backout MozReview-Commit-ID: EsfsviyLVbw
dom/base/Link.cpp
dom/base/Link.h
--- a/dom/base/Link.cpp
+++ b/dom/base/Link.cpp
@@ -192,18 +192,17 @@ Link::LinkState() const
   // We are a constant method, but we are just lazily doing things and have to
   // track that state.  Cast away that constness!
   Link *self = const_cast<Link *>(this);
 
   Element *element = self->mElement;
 
   // If we have not yet registered for notifications and need to,
   // due to our href changing, register now!
-  if (!mRegistered && mNeedsRegistration && element->IsInComposedDoc() &&
-      !HasPendingLinkUpdate()) {
+  if (!mRegistered && mNeedsRegistration && element->IsInComposedDoc()) {
     // Only try and register once.
     self->mNeedsRegistration = false;
 
     nsCOMPtr<nsIURI> hrefURI(GetURI());
 
     // Assume that we are not visited until we are told otherwise.
     self->mLinkState = eLinkState_Unvisited;
 
--- a/dom/base/Link.h
+++ b/dom/base/Link.h
@@ -121,17 +121,17 @@ public:
   void TryDNSPrefetch();
   void CancelDNSPrefetch(nsWrapperCache::FlagsType aDeferredFlag,
                          nsWrapperCache::FlagsType aRequestedFlag);
 
   // This is called by HTMLLinkElement.
   void TryDNSPrefetchPreconnectOrPrefetchOrPrerender();
   void CancelPrefetch();
 
-  bool HasPendingLinkUpdate() const { return mHasPendingLinkUpdate; }
+  bool HasPendingLinkUpdate() { return mHasPendingLinkUpdate; }
   void SetHasPendingLinkUpdate() { mHasPendingLinkUpdate = true; }
   void ClearHasPendingLinkUpdate() { mHasPendingLinkUpdate = false; }
 
   // To ensure correct mHasPendingLinkUpdate handling, we have this method
   // similar to the one in Element. Overriders must call
   // ClearHasPendingLinkUpdate().
   // If you change this, change also the method in Element.
   virtual void NodeInfoChanged(nsIDocument* aOldDoc) = 0;