Bug 1527939 - Fix the leak on the log message inside profiler_register_page r=mstange
authorNazım Can Altınova <canaltinova@gmail.com>
Thu, 14 Feb 2019 20:56:40 +0000
changeset 459510 b39035332029d51402f076823d7b7643dbb10161
parent 459509 a2bc4dbac66aa7d73dff232216a89f3eeb1754a3
child 459511 0f46f6b65796320a4948cb3571e17e24211fa084
push id111964
push usercsabou@mozilla.com
push dateFri, 15 Feb 2019 18:54:44 +0000
treeherdermozilla-inbound@db3c4f905082 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange
bugs1527939
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1527939 - Fix the leak on the log message inside profiler_register_page r=mstange Differential Revision: https://phabricator.services.mozilla.com/D19812
tools/profiler/core/platform.cpp
--- a/tools/profiler/core/platform.cpp
+++ b/tools/profiler/core/platform.cpp
@@ -3536,18 +3536,19 @@ void profiler_unregister_thread() {
     //
     // Either way, TLSRegisteredThread should be empty.
     MOZ_RELEASE_ASSERT(!TLSRegisteredThread::RegisteredThread(lock));
   }
 }
 
 void profiler_register_page(const nsID& aDocShellId, uint32_t aHistoryId,
                             const nsCString& aUrl, bool aIsSubFrame) {
-  DEBUG_LOG("profiler_register_page(%s, %u, %s, %d)", aDocShellId.ToString(),
-            aHistoryId, aUrl.get(), aIsSubFrame);
+  DEBUG_LOG("profiler_register_page(%s, %u, %s, %d)",
+            nsIDToCString(aDocShellId).get(), aHistoryId, aUrl.get(),
+            aIsSubFrame);
 
   MOZ_RELEASE_ASSERT(CorePS::Exists());
 
   PSAutoLock lock(gPSMutex);
 
   // If profiler is not active, delete all the previous page entries of the
   // given DocShell since we won't need those.
   if (!ActivePS::Exists(lock)) {