author | Florian Quèze <florian@queze.net> |
Wed, 23 Sep 2015 12:05:37 +0200 | |
changeset 264078 | b2fd64120dab85e0dce4a6f2286227e7ccd1ef40 |
parent 264077 | e5a6f8ea2ff46d1caa7ef0b8c4f9bf7c3c66ea8e |
child 264079 | 1b51fa918ebf2d84b1338a99a1b2f4f6568255b7 |
push id | 65512 |
push user | kwierso@gmail.com |
push date | Wed, 23 Sep 2015 20:23:51 +0000 |
treeherder | mozilla-inbound@b00078e693a0 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | adw |
bugs | 862148 |
milestone | 44.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/browser/base/content/test/general/browser_aboutHome.js +++ b/browser/base/content/test/general/browser_aboutHome.js @@ -270,17 +270,17 @@ var gTests = [ deferred.resolve(); }); }); Services.obs.addObserver(searchObserver, "browser-search-engine-modified", false); registerCleanupFunction(function () { Services.obs.removeObserver(searchObserver, "browser-search-engine-modified"); }); Services.search.addEngine("http://test:80/browser/browser/base/content/test/general/POSTSearchEngine.xml", - Ci.nsISearchEngine.DATA_XML, null, false); + null, null, false); return deferred.promise; } }, { desc: "Make sure that a page can't imitate about:home", setup: function () { }, run: function (aSnippetsMap) @@ -654,17 +654,17 @@ function promiseContentSearchChange(newE }); }); } function promiseNewEngine(basename) { info("Waiting for engine to be added: " + basename); let addDeferred = Promise.defer(); let url = getRootDirectory(gTestPath) + basename; - Services.search.addEngine(url, Ci.nsISearchEngine.TYPE_MOZSEARCH, "", false, { + Services.search.addEngine(url, null, "", false, { onSuccess: function (engine) { info("Search engine added: " + basename); registerCleanupFunction(() => { try { Services.search.removeEngine(engine); } catch (ex) { /* Can't remove the engine more than once */ } }); addDeferred.resolve(engine);
--- a/browser/base/content/test/general/browser_contentSearchUI.js +++ b/browser/base/content/test/general/browser_contentSearchUI.js @@ -189,42 +189,42 @@ add_task(function* cycleSuggestions() { yield setUp(); yield msg("key", { key: "x", waitForSuggestions: true }); let cycle = Task.async(function* (aSelectedButtonIndex) { let modifiers = { shiftKey: true, accelKey: true, }; - + let state = yield msg("key", { key: "VK_DOWN", modifiers: modifiers }); checkState(state, "xfoo", ["xfoo", "xbar"], 0, aSelectedButtonIndex); - + state = yield msg("key", { key: "VK_DOWN", modifiers: modifiers }); checkState(state, "xbar", ["xfoo", "xbar"], 1, aSelectedButtonIndex); - + state = yield msg("key", { key: "VK_DOWN", modifiers: modifiers }); checkState(state, "x", ["xfoo", "xbar"], -1, aSelectedButtonIndex); - + state = yield msg("key", { key: "VK_DOWN", modifiers: modifiers }); checkState(state, "xfoo", ["xfoo", "xbar"], 0, aSelectedButtonIndex); - + state = yield msg("key", { key: "VK_UP", modifiers: modifiers }); checkState(state, "x", ["xfoo", "xbar"], -1, aSelectedButtonIndex); - + state = yield msg("key", { key: "VK_UP", modifiers: modifiers }); checkState(state, "xbar", ["xfoo", "xbar"], 1, aSelectedButtonIndex); - + state = yield msg("key", { key: "VK_UP", modifiers: modifiers }); checkState(state, "xfoo", ["xfoo", "xbar"], 0, aSelectedButtonIndex); - + state = yield msg("key", { key: "VK_UP", modifiers: modifiers }); checkState(state, "x", ["xfoo", "xbar"], -1, aSelectedButtonIndex); }); - + yield cycle(); // Repeat with a one-off selected. let state = yield msg("key", "VK_TAB"); checkState(state, "x", ["xfoo", "xbar"], 2); yield cycle(0); // Repeat with the settings button selected. @@ -684,17 +684,17 @@ function checkState(actualState, expecte str: sugg, type: "remote", }; }); if (expectedSelectedIdx == -1 && expectedSelectedButtonIdx != undefined) { expectedSelectedIdx = expectedSuggestions.length + expectedSelectedButtonIdx; } - + let expectedState = { selectedIndex: expectedSelectedIdx, numSuggestions: expectedSuggestions.length, suggestionAtIndex: expectedSuggestions.map(s => s.str), isFormHistorySuggestionAtIndex: expectedSuggestions.map(s => s.type == "formHistory"), tableHidden: expectedSuggestions.length == 0, @@ -754,39 +754,20 @@ function promiseMsg(name, type, msgMan) } function setUpEngines() { return Task.spawn(function* () { info("Removing default search engines"); let currentEngineName = Services.search.currentEngine.name; let currentEngines = Services.search.getVisibleEngines(); info("Adding test search engines"); - let engine1 = yield promiseNewEngine(TEST_ENGINE_BASENAME); - let engine2 = yield promiseNewEngine(TEST_ENGINE_2_BASENAME); + let engine1 = yield promiseNewSearchEngine(TEST_ENGINE_BASENAME); + let engine2 = yield promiseNewSearchEngine(TEST_ENGINE_2_BASENAME); Services.search.currentEngine = engine1; for (let engine of currentEngines) { Services.search.removeEngine(engine); } registerCleanupFunction(() => { Services.search.restoreDefaultEngines(); - Services.search.removeEngine(engine1); - Services.search.removeEngine(engine2); Services.search.currentEngine = Services.search.getEngineByName(currentEngineName); }); }); } - -function promiseNewEngine(basename) { - info("Waiting for engine to be added: " + basename); - let addDeferred = Promise.defer(); - let url = getRootDirectory(gTestPath) + basename; - Services.search.addEngine(url, Ci.nsISearchEngine.TYPE_MOZSEARCH, "", false, { - onSuccess: function (engine) { - info("Search engine added: " + basename); - addDeferred.resolve(engine); - }, - onError: function (errCode) { - ok(false, "addEngine failed with error code " + errCode); - addDeferred.reject(); - }, - }); - return addDeferred.promise; -}
--- a/browser/base/content/test/general/browser_keywordSearch_postData.js +++ b/browser/base/content/test/general/browser_keywordSearch_postData.js @@ -45,17 +45,17 @@ function test() { registerCleanupFunction(function () { gBrowser.removeTab(tab); Services.obs.removeObserver(searchObserver, "browser-search-engine-modified"); }); Services.search.addEngine("http://test:80/browser/browser/base/content/test/general/POSTSearchEngine.xml", - Ci.nsISearchEngine.DATA_XML, null, false); + null, null, false); } var gCurrTest; function nextTest() { if (gTests.length) { gCurrTest = gTests.shift(); doTest(); } else {
--- a/browser/base/content/test/general/head.js +++ b/browser/base/content/test/general/head.js @@ -1028,18 +1028,17 @@ function promiseTopicObserved(aTopic) }, aTopic, false); }); } function promiseNewSearchEngine(basename) { return new Promise((resolve, reject) => { info("Waiting for engine to be added: " + basename); let url = getRootDirectory(gTestPath) + basename; - Services.search.addEngine(url, Ci.nsISearchEngine.TYPE_MOZSEARCH, "", - false, { + Services.search.addEngine(url, null, "", false, { onSuccess: function (engine) { info("Search engine added: " + basename); registerCleanupFunction(() => Services.search.removeEngine(engine)); resolve(engine); }, onError: function (errCode) { Assert.ok(false, "addEngine failed with error code " + errCode); reject();
--- a/browser/base/content/test/newtab/browser_newtab_search.js +++ b/browser/base/content/test/newtab/browser_newtab_search.js @@ -232,17 +232,17 @@ function promiseNewSearchEngine({name: b for (let i = 0; i < numLogos; i++) { expectedSearchEvents.push("CurrentState"); } let eventPromise = promiseSearchEvents(expectedSearchEvents); // Wait for addEngine(). let addDeferred = Promise.defer(); let url = getRootDirectory(gTestPath) + basename; - Services.search.addEngine(url, Ci.nsISearchEngine.TYPE_MOZSEARCH, "", false, { + Services.search.addEngine(url, null, "", false, { onSuccess: function (engine) { info("Search engine added: " + basename); gNewEngines.push(engine); addDeferred.resolve(engine); }, onError: function (errCode) { ok(false, "addEngine failed with error code " + errCode); addDeferred.reject();
--- a/browser/components/search/content/search.xml +++ b/browser/components/search/content/search.xml @@ -441,23 +441,21 @@ </implementation> <handlers> <handler event="command"><![CDATA[ const target = event.originalTarget; if (target.engine) { this.currentEngine = target.engine; } else if (target.classList.contains("addengine-item")) { - // We only detect OpenSearch files - var type = Ci.nsISearchEngine.DATA_XML; // Select the installed engine if the installation succeeds var installCallback = { onSuccess: engine => this.currentEngine = engine } - Services.search.addEngine(target.getAttribute("uri"), type, + Services.search.addEngine(target.getAttribute("uri"), null, target.getAttribute("src"), false, installCallback); } else return; this.focus(); this.select(); @@ -1427,18 +1425,17 @@ onSuccess: function(engine) { event.target.hidePopup(); BrowserSearch.searchBar.openSuggestionsPanel(); }, onError: function(errorCode) { Components.utils.reportError("Error adding search engine: " + errorCode); } } - Services.search.addEngine(target.getAttribute("uri"), - Ci.nsISearchEngine.DATA_XML, + Services.search.addEngine(target.getAttribute("uri"), null, target.getAttribute("image"), false, installCallback); } let anonid = target.getAttribute("anonid"); if (anonid == "search-one-offs-context-open-in-new-tab") { let searchbar = document.getElementById("searchbar"); searchbar.handleSearchCommand(event, this._contextEngine, true); }
--- a/browser/components/search/test/browser_426329.js +++ b/browser/components/search/test/browser_426329.js @@ -94,18 +94,17 @@ function* promiseSetEngine() { Services.obs.removeObserver(observer, "browser-search-engine-modified"); deferred.resolve(); break; } }; Services.obs.addObserver(observer, "browser-search-engine-modified", false); ss.addEngine("http://mochi.test:8888/browser/browser/components/search/test/426329.xml", - Ci.nsISearchEngine.DATA_XML, "data:image/x-icon,%00", - false); + null, "data:image/x-icon,%00", false); return deferred.promise; } function* promiseRemoveEngine() { let deferred = Promise.defer(); var ss = Services.search;
--- a/browser/components/search/test/browser_483086.js +++ b/browser/components/search/test/browser_483086.js @@ -19,33 +19,31 @@ function test() { Services.obs.removeObserver(observer, "browser-search-engine-modified"); test2(); break; } } Services.obs.addObserver(observer, "browser-search-engine-modified", false); gSS.addEngine("http://mochi.test:8888/browser/browser/components/search/test/483086-1.xml", - Ci.nsISearchEngine.DATA_XML, "data:image/x-icon;%00", - false); + null, "data:image/x-icon;%00", false); } function test2() { function observer(aSubject, aTopic, aData) { switch (aData) { case "engine-added": let engine = gSS.getEngineByName("483086b"); ok(engine, "Test engine 2 installed"); is(engine.searchForm, "http://example.com", "SearchForm is correct"); gSS.removeEngine(engine); break; - case "engine-removed": + case "engine-removed": Services.obs.removeObserver(observer, "browser-search-engine-modified"); finish(); break; } } Services.obs.addObserver(observer, "browser-search-engine-modified", false); gSS.addEngine("http://mochi.test:8888/browser/browser/components/search/test/483086-2.xml", - Ci.nsISearchEngine.DATA_XML, "data:image/x-icon;%00", - false); + null, "data:image/x-icon;%00", false); }
--- a/browser/components/search/test/browser_addEngine.js +++ b/browser/components/search/test/browser_addEngine.js @@ -39,22 +39,21 @@ function checkEngine(checkObj, engineObj var gTests = [ { name: "opensearch install", engine: { name: "Foo", alias: null, description: "Foo Search", - searchForm: "http://mochi.test:8888/browser/browser/components/search/test/", - type: Ci.nsISearchEngine.TYPE_OPENSEARCH + searchForm: "http://mochi.test:8888/browser/browser/components/search/test/" }, run: function () { gSS.addEngine("http://mochi.test:8888/browser/browser/components/search/test/testEngine.xml", - Ci.nsISearchEngine.DATA_XML, "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAIAAACQkWg2AAABGklEQVQoz2NgGB6AnZ1dUlJSXl4eSDIyMhLW4Ovr%2B%2Fr168uXL69Zs4YoG%2BLi4i5dusTExMTGxsbNzd3f37937976%2BnpmZmagbHR09J49e5YvX66kpATVEBYW9ubNm2nTphkbG7e2tp44cQLIuHfvXm5urpaWFlDKysqqu7v73LlzECMYIiIiHj58mJCQoKKicvXq1bS0NKBgW1vbjh074uPjgeqAXE1NzSdPnvDz84M0AEUvXLgAsW379u1z5swBen3jxo2zZ892cHB4%2BvQp0KlAfwI1cHJyghQFBwfv2rULokFXV%2FfixYu7d%2B8GGqGgoMDKyrpu3br9%2B%2FcDuXl5eVA%2FAEWBfoWHAdAYoNuAYQ0XAeoUERFhGDYAAPoUaT2dfWJuAAAAAElFTkSuQmCC", + null, "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAIAAACQkWg2AAABGklEQVQoz2NgGB6AnZ1dUlJSXl4eSDIyMhLW4Ovr%2B%2Fr168uXL69Zs4YoG%2BLi4i5dusTExMTGxsbNzd3f37937976%2BnpmZmagbHR09J49e5YvX66kpATVEBYW9ubNm2nTphkbG7e2tp44cQLIuHfvXm5urpaWFlDKysqqu7v73LlzECMYIiIiHj58mJCQoKKicvXq1bS0NKBgW1vbjh074uPjgeqAXE1NzSdPnvDz84M0AEUvXLgAsW379u1z5swBen3jxo2zZ892cHB4%2BvQp0KlAfwI1cHJyghQFBwfv2rULokFXV%2FfixYu7d%2B8GGqGgoMDKyrpu3br9%2B%2FcDuXl5eVA%2FAEWBfoWHAdAYoNuAYQ0XAeoUERFhGDYAAPoUaT2dfWJuAAAAAElFTkSuQmCC", false); }, added: function (engine) { ok(engine, "engine was added."); checkEngine(this.engine, engine); let engineFromSS = gSS.getEngineByName(this.engine.name);
--- a/browser/components/search/test/browser_amazon.js +++ b/browser/components/search/test/browser_amazon.js @@ -25,17 +25,16 @@ function test() { is(url, "https://completion.amazon.com/search/complete?q=foo&search-alias=aps&mkt=1", "Check search suggestion URL for 'foo'"); // Check all other engine properties. const EXPECTED_ENGINE = { name: "Amazon.com", alias: null, description: "Amazon.com Search", searchForm: "https://www.amazon.com/exec/obidos/external-search/?field-keywords=&mode=blended&tag=mozilla-20&sourceid=Mozilla-search", - type: Ci.nsISearchEngine.TYPE_MOZSEARCH, hidden: false, wrappedJSObject: { queryCharset: "UTF-8", "_iconURL": "data:image/x-icon;base64,AAABAAIAEBAAAAAAAAC0AQAAJgAAACAgAAAAAAAA6QIAANoBAACJUE5HDQoaCgAAAA1JSERSAAAAEAAAABAIBgAAAB/z/2EAAAF7SURBVDjLlZPLasJAFIaFRF+iVV+h6hO0GF+gVB9AaHwDt64qCG03tQgtdCFIuyhUelmGli66MXThSt24kNiFBUlAYi6ezjnNxSuawB/ITP7v/HNmJgQAEaZzpgHs/gwcTyTEXuXl2U6nA8ViEbK5HKler28CVRAwnB9ptVrAh8MrQuCaZ4iA8fzIqSgCxwzpTIaSuN/RWGwdYLwCUBQFZFkGSZLgqdmEE7YEN8VOAKyaSKUW4nNBAFmnYiKZpDRX1WqwBBzP089n5f/NEQsFL4WqqtsBWJlzDAJr5PwSMM1awEzzdxIbGI3Hvc6jCZeVFgRQRwpY7Qcw3ktgfpR8wLRxCPaot/X4GS95MppfF6DX9n2A3f+kAZycaT8bAZjU6r6B/duD6d3BYg9wQq/tkYzHY1blEiz5lmQyGc95mrO6r2CxgpjCBXgNsJVviolpXJiraeOIjJRE10juUa4sR8V+mO17VvmGqtuOcdNlwut8zTQJcJ0njifyB2bgTdKh6w4BAAAAAElFTkSuQmCCiVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAACsElEQVRYw71XQWsTURBe2LQgeNKLB+tVemt6txcteNSD/QGC6VEIGDx5s+eKPQqFgJhLNdFLBWMP7cU0oSAWjB70koC9WHbVQ5SO8+XtS14mr7svyaYDH9m87Jv55puZt1nPi4yIzjMeMj7T9OwjI88455nGC1cZX+nsDESumJmPFDwIAqrX6z00Gg1qt9vjkJgFgUeuO16Vy3RjeZkyMzM9+MY1fsM9I9h9zyV7ZAznZrA4FAoFVwJ1z+WuOysrg1lnMolkHJX4k0igzI5sARYWF7vEZEk0rvO6iyUSuJfLJUqM7zYSqRDIra4OOUZPmNZsNrsl8UVTpkJAjh1GzmaSpJ8mAWmYeZB5urHRhW5SNOfUCCDo47W1bvPZsp2qAhipy3Nz1kaLG8dUCEBqM5AvpgElqFar01NgIZsdco7Zb7VasU2YigIYL5tjqCL7Q5YkFQXKlcqQ7DbHthIALk/IWAKor82xPIhshxWABCYioDMz51sexcVi0XoG4DPLIyvJjkTArK3scDQnRvO0MdTrUHGiKZCP4tNgO6BAEI08EQH9Z2Qow0hyPypJGIa9p6JWKCn4SA8jSKmJIDgyRvPJkcRxjfUwNGr/i8+Mo32iHzWiThBD4NM60bet9P77/ubA728RlTjMiwiH6zEEfvIrwdZFtQmMJ7W/ofIDBZD5m3mVZGwJcOP2kmILIlCkE45HoPWurwCSg0+UQRD4ZyXxId+T7gQb9+4q9sioY5ltrOG3L5vqXiiJffDx/aUi83ZJ7jr2ohcEu8Hh6/m+I7OWGiVxbWKHsz+O3vSOakqFQdsFgQeJUiKD7Wv9YKXBgCeSUC3v2kM5EJhlHDh3NcgcPlG1BXZu98sDmTuBa4fsMnz9fniJUaGzs+eMC540XuR0aDO2L8Y3qPyMcdOM+R/8XcqRA3qp9gAAAABJRU5ErkJggg==", _urls : [ { type: "application/x-suggestions+json", method: "GET",
--- a/browser/components/search/test/browser_bing.js +++ b/browser/components/search/test/browser_bing.js @@ -35,17 +35,16 @@ function test() { is(url, "https://www.bing.com/osjson.aspx?query=foo&form=OSDJAS&language=" + getLocale(), "Check search suggestion URL for 'foo'"); // Check all other engine properties. const EXPECTED_ENGINE = { name: "Bing", alias: null, description: "Bing. Search by Microsoft.", searchForm: "https://www.bing.com/search?q=&pc=MOZI", - type: Ci.nsISearchEngine.TYPE_MOZSEARCH, hidden: false, wrappedJSObject: { queryCharset: "UTF-8", "_iconURL": "data:image/x-icon;base64,AAABAAIAEBAAAAEACADaCwAAJgAAACAgAAABAAgAlAIAAAAMAACJUE5HDQoaCgAAAA1JSERSAAAAEAAAABAIAgAAAJCRaDYAAAAJcEhZcwAACxMAAAsTAQCanBgAAApPaUNDUFBob3Rvc2hvcCBJQ0MgcHJvZmlsZQAAeNqdU2dUU+kWPffe9EJLiICUS29SFQggUkKLgBSRJiohCRBKiCGh2RVRwRFFRQQbyKCIA46OgIwVUSwMigrYB+Qhoo6Do4iKyvvhe6Nr1rz35s3+tdc+56zznbPPB8AIDJZIM1E1gAypQh4R4IPHxMbh5C5AgQokcAAQCLNkIXP9IwEA+H48PCsiwAe+AAF40wsIAMBNm8AwHIf/D+pCmVwBgIQBwHSROEsIgBQAQHqOQqYAQEYBgJ2YJlMAoAQAYMtjYuMAUC0AYCd/5tMAgJ34mXsBAFuUIRUBoJEAIBNliEQAaDsArM9WikUAWDAAFGZLxDkA2C0AMElXZkgAsLcAwM4QC7IACAwAMFGIhSkABHsAYMgjI3gAhJkAFEbyVzzxK64Q5yoAAHiZsjy5JDlFgVsILXEHV1cuHijOSRcrFDZhAmGaQC7CeZkZMoE0D+DzzAAAoJEVEeCD8/14zg6uzs42jrYOXy3qvwb/ImJi4/7lz6twQAAA4XR+0f4sL7MagDsGgG3+oiXuBGheC6B194tmsg9AtQCg6dpX83D4fjw8RaGQudnZ5eTk2ErEQlthyld9/mfCX8BX/Wz5fjz89/XgvuIkgTJdgUcE+ODCzPRMpRzPkgmEYtzmj0f8twv//B3TIsRJYrlYKhTjURJxjkSajPMypSKJQpIpxSXS/2Ti3yz7Az7fNQCwaj4Be5EtqF1jA/ZLJxBYdMDi9wAA8rtvwdQoCAOAaIPhz3f/7z/9R6AlAIBmSZJxAABeRCQuVMqzP8cIAABEoIEqsEEb9MEYLMAGHMEF3MEL/GA2hEIkxMJCEEIKZIAccmAprIJCKIbNsB0qYC/UQB00wFFohpNwDi7CVbgOPXAP+mEInsEovIEJBEHICBNhIdqIAWKKWCOOCBeZhfghwUgEEoskIMmIFFEiS5E1SDFSilQgVUgd8j1yAjmHXEa6kTvIADKC/Ia8RzGUgbJRPdQMtUO5qDcahEaiC9BkdDGajxagm9BytBo9jDah59CraA/ajz5DxzDA6BgHM8RsMC7Gw0KxOCwJk2PLsSKsDKvGGrBWrAO7ifVjz7F3BBKBRcAJNgR3QiBhHkFIWExYTthIqCAcJDQR2gk3CQOEUcInIpOoS7QmuhH5xBhiMjGHWEgsI9YSjxMvEHuIQ8Q3JBKJQzInuZACSbGkVNIS0kbSblIj6SypmzRIGiOTydpka7IHOZQsICvIheSd5MPkM+Qb5CHyWwqdYkBxpPhT4ihSympKGeUQ5TTlBmWYMkFVo5pS3aihVBE1j1pCraG2Uq9Rh6gTNHWaOc2DFklLpa2ildMaaBdo92mv6HS6Ed2VHk6X0FfSy+lH6JfoA/R3DA2GFYPHiGcoGZsYBxhnGXcYr5hMphnTixnHVDA3MeuY55kPmW9VWCq2KnwVkcoKlUqVJpUbKi9Uqaqmqt6qC1XzVctUj6leU32uRlUzU+OpCdSWq1WqnVDrUxtTZ6k7qIeqZ6hvVD+kfln9iQZZw0zDT0OkUaCxX+O8xiALYxmzeCwhaw2rhnWBNcQmsc3ZfHYqu5j9HbuLPaqpoTlDM0ozV7NS85RmPwfjmHH4nHROCecop5fzforeFO8p4ikbpjRMuTFlXGuqlpeWWKtIq1GrR+u9Nq7tp52mvUW7WfuBDkHHSidcJ0dnj84FnedT2VPdpwqnFk09OvWuLqprpRuhu0R3v26n7pievl6Ankxvp955vef6HH0v/VT9bfqn9UcMWAazDCQG2wzOGDzFNXFvPB0vx9vxUUNdw0BDpWGVYZfhhJG50Tyj1UaNRg+MacZc4yTjbcZtxqMmBiYhJktN6k3umlJNuaYppjtMO0zHzczNos3WmTWbPTHXMueb55vXm9+3YFp4Wiy2qLa4ZUmy5FqmWe62vG6FWjlZpVhVWl2zRq2drSXWu627pxGnuU6TTque1mfDsPG2ybaptxmw5dgG2662bbZ9YWdiF2e3xa7D7pO9k326fY39PQcNh9kOqx1aHX5ztHIUOlY63prOnO4/fcX0lukvZ1jPEM/YM+O2E8spxGmdU5vTR2cXZ7lzg/OIi4lLgssulz4umxvG3ci95Ep09XFd4XrS9Z2bs5vC7ajbr+427mnuh9yfzDSfKZ5ZM3PQw8hD4FHl0T8Ln5Uwa9+sfk9DT4FntecjL2MvkVet17C3pXeq92HvFz72PnKf4z7jPDfeMt5ZX8w3wLfIt8tPw2+eX4XfQ38j/2T/ev/RAKeAJQFnA4mBQYFbAvv4enwhv44/Ottl9rLZ7UGMoLlBFUGPgq2C5cGtIWjI7JCtIffnmM6RzmkOhVB+6NbQB2HmYYvDfgwnhYeFV4Y/jnCIWBrRMZc1d9HcQ3PfRPpElkTem2cxTzmvLUo1Kj6qLmo82je6NLo/xi5mWczVWJ1YSWxLHDkuKq42bmy+3/zt84fineIL43sXmC/IXXB5oc7C9IWnFqkuEiw6lkBMiE44lPBBECqoFowl8hN3JY4KecIdwmciL9E20YjYQ1wqHk7ySCpNepLskbw1eSTFM6Us5bmEJ6mQvEwNTN2bOp4WmnYgbTI9Or0xg5KRkHFCqiFNk7Zn6mfmZnbLrGWFsv7Fbou3Lx6VB8lrs5CsBVktCrZCpuhUWijXKgeyZ2VXZr/Nico5lqueK83tzLPK25A3nO+f/+0SwhLhkralhktXLR1Y5r2sajmyPHF52wrjFQUrhlYGrDy4irYqbdVPq+1Xl65+vSZ6TWuBXsHKgsG1AWvrC1UK5YV969zX7V1PWC9Z37Vh+oadGz4ViYquFNsXlxV/2CjceOUbh2/Kv5nclLSpq8S5ZM9m0mbp5t4tnlsOlqqX5pcObg3Z2rQN31a07fX2Rdsvl80o27uDtkO5o788uLxlp8nOzTs/VKRU9FT6VDbu0t21Ydf4btHuG3u89jTs1dtbvPf9Psm+21UBVU3VZtVl+0n7s/c/romq6fiW+21drU5tce3HA9ID/QcjDrbXudTVHdI9VFKP1ivrRw7HH77+ne93LQ02DVWNnMbiI3BEeeTp9wnf9x4NOtp2jHus4QfTH3YdZx0vakKa8ppGm1Oa+1tiW7pPzD7R1ureevxH2x8PnDQ8WXlK81TJadrpgtOTZ/LPjJ2VnX1+LvncYNuitnvnY87fag9v77oQdOHSRf+L5zu8O85c8rh08rLb5RNXuFearzpfbep06jz+k9NPx7ucu5quuVxrue56vbV7ZvfpG543zt30vXnxFv/W1Z45Pd2983pv98X39d8W3X5yJ/3Oy7vZdyfurbxPvF/0QO1B2UPdh9U/W/7c2O/cf2rAd6Dz0dxH9waFg8/+kfWPD0MFj5mPy4YNhuueOD45OeI/cv3p/KdDz2TPJp4X/qL+y64XFi9++NXr187RmNGhl/KXk79tfKX96sDrGa/bxsLGHr7JeDMxXvRW++3Bd9x3He+j3w9P5Hwgfyj/aPmx9VPQp/uTGZOT/wQDmPP8YzMt2wAAACBjSFJNAAB6JQAAgIMAAPn/AACA6QAAdTAAAOpgAAA6mAAAF2+SX8VGAAABBUlEQVR42mL8v4OBJMAEZ/0nTgMLnLXtitKRO9JmCi9cNR/wsP8mrOHfP8YbL4RvvBBWFXuvI/WGsJMYSHUSMujbY8LN/ttM4bmO1BtW5n+ENdipPmndbrHjqiIn6x9DuZc2yk8tlZ7hc5Kx/AtzxecMDAzff7Mcuys9/7gOAT8wMjAUOZ9x0XhI2A98HL+Eub/vuSG/8ozGmy+cEEF+zp/YNYjxfvPTv9O63fLpBx6ICCvz32DD24EGt7Fo4Gb/zcX2Z84RPbiIqfyLZJtL4rzfsDvJUf3R91+sC09o//7LJMn/NdXmkqHsSyzeQ0t8j9/znn8s7ql9Dy34cWogIbUSCQADAJ+jWQrH9LCsAAAAAElFTkSuQmCCiVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAIAAAD8GO2jAAACW0lEQVR4nGP8v5OBpoCJtsbTwQIWTKGUxe5mCi9M5V/oSL9mZf5HoQWMmHEQOD0AwuBg/WMo+8pB/ZGZwguyLcDiAzj48Zvl+D2pTz/YKLGAcBxcfSZCtulEWUAhGDQW3HstcOOF8P//jKRagC+SkQE/58/0pa7c7L9N5V+aKTw3kH3FxvKXmhYI83y3VXl64Jbs3htye2/IsbH8NZB9Zabw3FT+JR/nTypYwMDAEGBw+8AtWQj71x/mU/clT92XZGT8ry7+zlzxhbnic0n+LxRZIC/8yUju5blH4siC//8z3nghfOOF8MLj2jKCnydH7EXTRVoqCjC4g0f2yXteTEHSLNCVft0WcNhM4QXxiYmEIIIATcm3mpJvn37gmX7Q8OozYYLqycloTz/wLDulRYzpDMT4QFf6NZz95gvnyjMa+27I/SM6xxGwQJj7R6rtJQYGhk8/2NaeU9t+RfH3X2ZcihWEP5Fmgazg53qfY9zsv1ed0dh4UeXbL5yKudl/R5tdd9O6T4IFGhJvyz1OHbkts/qc2qfv7LiUMTIwOGk8irW4yo8jP2O3wEzxubHcy7I1Dq+/cOIymoGBQVn0Q5rtRTXx93jUYLFAX+b1sw88p+5L4tHGy/Er2uy6m9YDRsb/eJRht8BS+emCY7q4NDAyMLhpPYixuMbD/gu/0VD1WBtezz7w9O81vvNKEE1cTfxdmu0lZdEPxBiNzwIGBoa//xhXndFYfU4NUsnwcf6Ms7jmpPGQ1BoHpwUQcOOF0OT9RoayryJNr3Oz/ybRcCIsoBwMmkp/8FoAADmgy6ulKggYAAAAAElFTkSuQmCC", _urls : [ { type: "application/x-suggestions+json", method: "GET",
--- a/browser/components/search/test/browser_contextmenu.js +++ b/browser/components/search/test/browser_contextmenu.js @@ -26,18 +26,17 @@ function test() { Services.obs.removeObserver(observer, "browser-search-engine-modified"); finish(); break; } } Services.obs.addObserver(observer, "browser-search-engine-modified", false); ss.addEngine("http://mochi.test:8888/browser/browser/components/search/test/testEngine_mozsearch.xml", - Ci.nsISearchEngine.DATA_XML, "data:image/x-icon,%00", - false); + null, "data:image/x-icon,%00", false); function startTest() { contextMenu = document.getElementById("contentAreaContextMenu"); ok(contextMenu, "Got context menu XUL"); doOnloadOnce(testContextMenu); let tab = gBrowser.selectedTab = gBrowser.addTab("data:text/plain;charset=utf8,test%20search"); registerCleanupFunction(function () {
--- a/browser/components/search/test/browser_eBay.js +++ b/browser/components/search/test/browser_eBay.js @@ -25,17 +25,16 @@ function test() { is(url, "http://autosug.ebay.com/autosug?sId=0&kwd=foo&fmt=osr", "Check search suggestion URL for 'foo'"); // Check all other engine properties. const EXPECTED_ENGINE = { name: "eBay", alias: null, description: "eBay - Online auctions", searchForm: "http://search.ebay.com/", - type: Ci.nsISearchEngine.TYPE_MOZSEARCH, hidden: false, wrappedJSObject: { queryCharset: "ISO-8859-1", "_iconURL": "data:image/x-icon;base64,AAABAAIAEBAAAAAAAAB6AQAAJgAAACAgAAAAAAAAQgMAAKABAACJUE5HDQoaCgAAAA1JSERSAAAAEAAAABAIBgAAAB/z/2EAAAFBSURBVDjLtZPdK0MBGIf3J5Babhx3rinFBWuipaUskX9DYvkopqgV90q5UJpyp0OKrUWM2VrRsS9D0zZKHGaOnW1nj4vtypVtPPe/533r9746QAAOAJXfo5Yzgg44pHrcugon/6Sgo0b+XuAOZ2iZiVQmyPoDpIwmUkYTzqM7GsdDdC7F6Lbf8pzOkfWOouzqeZem2b+2AqAV8zjD8yVBqqcf2b7C66yNiMGMfixIQSvi8Mp0LEbR5ADq1QSKWM+Gx0RC9nOZ2GLzwlIWdPWiuNzk4w/EpThNkyEAXKEP2ud8KGId2sspilhPMrmNwzfCuqePr/xbSfC5I/I0MMSj2YJ3z49gDdO2cEOrLUowJpE9G0QRG1ClKbR0EIdvmOPYcnUtnN+vsnZiQC1k/qnGagQ1n3LNzySUJZVskitnmr8BlQG7T2hvgxsAAAAASUVORK5CYIKJUE5HDQoaCgAAAA1JSERSAAAAIAAAACAIBgAAAHN6evQAAAMJSURBVFjD7ZddSFNhGMeHXXQTZFFCWfR1pRhUECQlBdWVToo+6KYu1KigtDASG5qUfZgFZvahEDosECPDktKZS1FL+1DRnEvdUptjug91X2dnZzv/3vO6OZbWnR4v9sADL+fs7P97/s/znu2VAJD4UkpSSdKG+QubTyPBr+sXz8XCR64fIAHihVTis0SsUAoAVhEBrBKIHCGAEMB/ARi3F5LkbpS2WMRzYEEBXC2tsD6T03R9agsCGLNyqPw6CXmrBT06JvhbPHZwmkdwtR0B138PPKOHgzXD5jLAy3tmibo4K9weZwDAazJj/FQKRnfugfHMeRiTz0K3Ixam1HQKcPC+Fisu9NK1P08Uj4DleHgMdXC+WQ7nu3UEOhFMfTQcVUvQ1H4IN2sj8H2k7K+2TqCc3GseyA8AmDOzMBq7D9bS8sAr6nEJdNt3UbHVF1XQGtmZew8bTPT6tWoD3KpsUvlR8NxUoEICMvl6KQo+xqCwcRs4T8Ax5c8bFExjbAgAjO7aS8VsLypgq3g5nWStjztAhWRVhqAqeB6IuKTClkw1eNYEbrCQQBwD8yGGOsAooogLYejQPKBi7UPF9DkH+ezd+o141ZkUPAOC+L9SAMivNc7q46YMNSLTe4n1kaQF4XD3ZIDTPgU3XEYciKcAHrsGJS1xKFBGgyVzouiT4VbdGhjt/cEA5isyKsaz7jl3we7bg7Rqf6j0LoSldON4wWcqJDgQNGTN++l13vELA+MK6kKd6iryFOvxtidt9i5gO7owdjKJQliflNAU1pas6xQgnAzg1ux+lJEdILixNr0Pq9JUUA8NwVG9DM73G0jlcnh+V4BpjIWzJmIGQIjnXw5TiDuKSEwxurm3ITc8DNO51BnrLbIcsrW0dNA6RxgUKU1UdGVqLy5X6qGzTLvlnewiBZyGs3Yz6X8UeaYI3olvZDhzwLumZ+eHvooCCC0Q5VUsb4unwycM4YIDqA01tPqmgbzQr2EIYPECiPm33LYoDiZSsY9moh9O/Znoa4d9HkXtPg2pX/cPKCoRQ+ocZa4AAAAASUVORK5CYII=", _urls : [ { type: "application/x-suggestions+json", method: "GET",
--- a/browser/components/search/test/browser_google.js +++ b/browser/components/search/test/browser_google.js @@ -41,17 +41,16 @@ function test() { "Check alternate domain"); // Check all other engine properties. const EXPECTED_ENGINE = { name: "Google", alias: null, description: "Google Search", searchForm: "https://www.google.com/search?q=&ie=utf-8&oe=utf-8", - type: Ci.nsISearchEngine.TYPE_MOZSEARCH, hidden: false, wrappedJSObject: { queryCharset: "UTF-8", "_iconURL": "data:image/x-icon;base64,AAABAAIAEBAAAAAAAAB9AQAAJgAAACAgAAAAAAAA8gIAAKMBAACJUE5HDQoaCgAAAA1JSERSAAAAEAAAABAIBgAAAB/z/2EAAAFESURBVDjLpZNJSwNBEIXnt4lE4kHxovgT9BDwJHqPy0HEEOJBiAuCRg+KUdC4QS4KrpC4gCBGE3NQ48JsnZ6eZ3UOM6gjaePhQU93v6+qq2q0pqgeJj2S8EdJT1hr0OxBtKCD5iEd8QxDYpvhvOBAuMDKURX9C9aPu4GA1GEVkzvMg10UBfYveWAWgYAP00V01fa+R9M2bA51wJvhIn3qR+ybt3D3JNQBE5sMjCIOLFpoHzOwdsLRO22qA6R6kiZiWwxUvy/PUQZIhYZ1vFM9cvcOOsYNdcBgysISdSJBnZjJMlR0Fw8vAp0xoz5gao/h+NZBy4i/10XGwrPA+hmvDyhVRG2Avu/LwcrkFADZa16L1h330w1RNgc3DiJzCpPYRm1bpveXX11clQR28xwblHpk1vq1iP/5mcoS0CoXDZiL0vsJ+dzfl+3T/VYAAAAASUVORK5CYIKJUE5HDQoaCgAAAA1JSERSAAAAIAAAACAIBgAAAHN6evQAAAK5SURBVFjDxVfrSxRRFJ9/Jta/oyWjF5XQm6D6EkHRgygIIgjUTcueVgqVWSRRkppEUQYWWB8ye1iGWilWlo/Ude489s7M6Zw7D9dlt53dmd29cFiWvXvO77x+51xpaaUsoSxBaUWZQ4ECy5xji2xKZDyCMlMEw6lCNiOSgwZKJK1SkcKeSealfP64t0mBjl4Ow39MkDUL0p2RSROOtqhZdeUEYM1pBl39XCg/fEeFtWcY7G9W4csvUxjlBkCsQ4Nt9QyWVfvT6RsAKXw3aoDGATZeYIt+W1kjw7cJG0RctWDTRebbKd8A6h5pwsDb70ba3w/eUr3wt/cmwgfw6Yft4TNMQaY7o1P2ncm4FT4ANQH/jQBJ2xv7kqIXEADDql8eS3+n8bku7oxNm+EDIM/dU92upb3T/NJGeaNbDx/AsbsLRUY5Xn92caWXY5d8RV6gWllxSg4fAEnTC90DQW13BLlgXR2D3dcUeDVkwOthA1bXspxILWcm3HdThcfvufB26LcJpkOEAz9NKI/lzqpSEC7feol5EWnpSeSlIxCALUkApmULdjUqxQVAQnl3D/X/yQda4QBEq2TYc12By091MQ17Bg3R88nHKlQbVmHvj89awNBLYrwT9zXY2aBAxTkGFdiSxP/Jp6FLDw+AS7GfsdJTJ2EqSO5khD43nGfBARy/ZxOQgZHe7GPM1jzUvChUtmnBAXQPcKGMJp3fdFGq6NByEhiAO4b/YptFfQJwNyQ/bZkVQGcf90Ja25ndIyrKBOa/f8wIpwi3X1G8UcxNu7ozUS7tiH0jBswwS3RIaF1w6LYKU/ML2+8sGnjygQswtKrVIy/Qd9qQP6LnO64q4fPAKpxyZIymHo1jWk6p1ag2BsdNwQMHcC+M5kHFJX+YlPxpVlbCx2mZ5DzPI04k4kUwHHdskU3pH76iftG8yWlkAAAAAElFTkSuQmCC", _urls : [ { type: "application/x-suggestions+json", method: "GET",
--- a/browser/components/search/test/browser_healthreport.js +++ b/browser/components/search/test/browser_healthreport.js @@ -91,19 +91,17 @@ function test() { Services.obs.removeObserver(observer, "browser-search-engine-modified"); finish(); break; } } Services.obs.addObserver(observer, "browser-search-engine-modified", false); Services.search.addEngine("http://mochi.test:8888/browser/browser/components/search/test/testEngine.xml", - Ci.nsISearchEngine.DATA_XML, - "data:image/x-icon,%00", - false); + null, "data:image/x-icon,%00", false); } function resetPreferences() { let service = Components.classes["@mozilla.org/datareporting/service;1"] .getService(Components.interfaces.nsISupports) .wrappedJSObject; service.policy._prefs.resetBranch("datareporting.policy.");
--- a/browser/components/search/test/browser_hiddenOneOffs_cleanup.js +++ b/browser/components/search/test/browser_hiddenOneOffs_cleanup.js @@ -4,17 +4,17 @@ const testPref = "Foo,FooDupe"; function promiseNewEngine(basename) { return new Promise((resolve, reject) => { info("Waiting for engine to be added: " + basename); Services.search.init({ onInitComplete: function() { let url = getRootDirectory(gTestPath) + basename; - Services.search.addEngine(url, Ci.nsISearchEngine.TYPE_MOZSEARCH, "", false, { + Services.search.addEngine(url, null, "", false, { onSuccess: function (engine) { info("Search engine added: " + basename); resolve(engine); }, onError: function (errCode) { ok(false, "addEngine failed with error code " + errCode); reject(); }
--- a/browser/components/search/test/browser_private_search_perwindowpb.js +++ b/browser/components/search/test/browser_private_search_perwindowpb.js @@ -46,18 +46,17 @@ function test() { onSuccess: function (engine) { Services.search.currentEngine = engine; aCallback(); }, onError: function (errorCode) { ok(false, "failed to install engine: " + errorCode); } }; - Services.search.addEngine(engineURL + "426329.xml", - Ci.nsISearchEngine.DATA_XML, + Services.search.addEngine(engineURL + "426329.xml", null, "data:image/x-icon,%00", false, installCallback); } function testOnWindow(aIsPrivate, aCallback) { let win = whenNewWindowLoaded({ private: aIsPrivate }, function() { waitForFocus(aCallback, win); }); windowsToClose.push(win);
--- a/browser/components/search/test/browser_yahoo.js +++ b/browser/components/search/test/browser_yahoo.js @@ -25,17 +25,16 @@ function test() { is(url, "https://search.yahoo.com/sugg/ff?output=fxjson&appid=ffd&command=foo", "Check search suggestion URL for 'foo'"); // Check all other engine properties. const EXPECTED_ENGINE = { name: "Yahoo", alias: null, description: "Yahoo Search", searchForm: "https://search.yahoo.com/yhs/search?p=&ei=UTF-8&hspart=mozilla", - type: Ci.nsISearchEngine.TYPE_MOZSEARCH, hidden: false, wrappedJSObject: { queryCharset: "UTF-8", "_iconURL": "data:image/x-icon;base64,AAABAAIAEBAAAAEACAA8DQAAJgAAACAgAAABAAgAowsAAGINAACJUE5HDQoaCgAAAA1JSERSAAAAEAAAABAIBgAAAB/z/2EAAAAJcEhZcwAACxMAAAsTAQCanBgAAApPaUNDUFBob3Rvc2hvcCBJQ0MgcHJvZmlsZQAAeNqdU2dUU+kWPffe9EJLiICUS29SFQggUkKLgBSRJiohCRBKiCGh2RVRwRFFRQQbyKCIA46OgIwVUSwMigrYB+Qhoo6Do4iKyvvhe6Nr1rz35s3+tdc+56zznbPPB8AIDJZIM1E1gAypQh4R4IPHxMbh5C5AgQokcAAQCLNkIXP9IwEA+H48PCsiwAe+AAF40wsIAMBNm8AwHIf/D+pCmVwBgIQBwHSROEsIgBQAQHqOQqYAQEYBgJ2YJlMAoAQAYMtjYuMAUC0AYCd/5tMAgJ34mXsBAFuUIRUBoJEAIBNliEQAaDsArM9WikUAWDAAFGZLxDkA2C0AMElXZkgAsLcAwM4QC7IACAwAMFGIhSkABHsAYMgjI3gAhJkAFEbyVzzxK64Q5yoAAHiZsjy5JDlFgVsILXEHV1cuHijOSRcrFDZhAmGaQC7CeZkZMoE0D+DzzAAAoJEVEeCD8/14zg6uzs42jrYOXy3qvwb/ImJi4/7lz6twQAAA4XR+0f4sL7MagDsGgG3+oiXuBGheC6B194tmsg9AtQCg6dpX83D4fjw8RaGQudnZ5eTk2ErEQlthyld9/mfCX8BX/Wz5fjz89/XgvuIkgTJdgUcE+ODCzPRMpRzPkgmEYtzmj0f8twv//B3TIsRJYrlYKhTjURJxjkSajPMypSKJQpIpxSXS/2Ti3yz7Az7fNQCwaj4Be5EtqF1jA/ZLJxBYdMDi9wAA8rtvwdQoCAOAaIPhz3f/7z/9R6AlAIBmSZJxAABeRCQuVMqzP8cIAABEoIEqsEEb9MEYLMAGHMEF3MEL/GA2hEIkxMJCEEIKZIAccmAprIJCKIbNsB0qYC/UQB00wFFohpNwDi7CVbgOPXAP+mEInsEovIEJBEHICBNhIdqIAWKKWCOOCBeZhfghwUgEEoskIMmIFFEiS5E1SDFSilQgVUgd8j1yAjmHXEa6kTvIADKC/Ia8RzGUgbJRPdQMtUO5qDcahEaiC9BkdDGajxagm9BytBo9jDah59CraA/ajz5DxzDA6BgHM8RsMC7Gw0KxOCwJk2PLsSKsDKvGGrBWrAO7ifVjz7F3BBKBRcAJNgR3QiBhHkFIWExYTthIqCAcJDQR2gk3CQOEUcInIpOoS7QmuhH5xBhiMjGHWEgsI9YSjxMvEHuIQ8Q3JBKJQzInuZACSbGkVNIS0kbSblIj6SypmzRIGiOTydpka7IHOZQsICvIheSd5MPkM+Qb5CHyWwqdYkBxpPhT4ihSympKGeUQ5TTlBmWYMkFVo5pS3aihVBE1j1pCraG2Uq9Rh6gTNHWaOc2DFklLpa2ildMaaBdo92mv6HS6Ed2VHk6X0FfSy+lH6JfoA/R3DA2GFYPHiGcoGZsYBxhnGXcYr5hMphnTixnHVDA3MeuY55kPmW9VWCq2KnwVkcoKlUqVJpUbKi9Uqaqmqt6qC1XzVctUj6leU32uRlUzU+OpCdSWq1WqnVDrUxtTZ6k7qIeqZ6hvVD+kfln9iQZZw0zDT0OkUaCxX+O8xiALYxmzeCwhaw2rhnWBNcQmsc3ZfHYqu5j9HbuLPaqpoTlDM0ozV7NS85RmPwfjmHH4nHROCecop5fzforeFO8p4ikbpjRMuTFlXGuqlpeWWKtIq1GrR+u9Nq7tp52mvUW7WfuBDkHHSidcJ0dnj84FnedT2VPdpwqnFk09OvWuLqprpRuhu0R3v26n7pievl6Ankxvp955vef6HH0v/VT9bfqn9UcMWAazDCQG2wzOGDzFNXFvPB0vx9vxUUNdw0BDpWGVYZfhhJG50Tyj1UaNRg+MacZc4yTjbcZtxqMmBiYhJktN6k3umlJNuaYppjtMO0zHzczNos3WmTWbPTHXMueb55vXm9+3YFp4Wiy2qLa4ZUmy5FqmWe62vG6FWjlZpVhVWl2zRq2drSXWu627pxGnuU6TTque1mfDsPG2ybaptxmw5dgG2662bbZ9YWdiF2e3xa7D7pO9k326fY39PQcNh9kOqx1aHX5ztHIUOlY63prOnO4/fcX0lukvZ1jPEM/YM+O2E8spxGmdU5vTR2cXZ7lzg/OIi4lLgssulz4umxvG3ci95Ep09XFd4XrS9Z2bs5vC7ajbr+427mnuh9yfzDSfKZ5ZM3PQw8hD4FHl0T8Ln5Uwa9+sfk9DT4FntecjL2MvkVet17C3pXeq92HvFz72PnKf4z7jPDfeMt5ZX8w3wLfIt8tPw2+eX4XfQ38j/2T/ev/RAKeAJQFnA4mBQYFbAvv4enwhv44/Ottl9rLZ7UGMoLlBFUGPgq2C5cGtIWjI7JCtIffnmM6RzmkOhVB+6NbQB2HmYYvDfgwnhYeFV4Y/jnCIWBrRMZc1d9HcQ3PfRPpElkTem2cxTzmvLUo1Kj6qLmo82je6NLo/xi5mWczVWJ1YSWxLHDkuKq42bmy+3/zt84fineIL43sXmC/IXXB5oc7C9IWnFqkuEiw6lkBMiE44lPBBECqoFowl8hN3JY4KecIdwmciL9E20YjYQ1wqHk7ySCpNepLskbw1eSTFM6Us5bmEJ6mQvEwNTN2bOp4WmnYgbTI9Or0xg5KRkHFCqiFNk7Zn6mfmZnbLrGWFsv7Fbou3Lx6VB8lrs5CsBVktCrZCpuhUWijXKgeyZ2VXZr/Nico5lqueK83tzLPK25A3nO+f/+0SwhLhkralhktXLR1Y5r2sajmyPHF52wrjFQUrhlYGrDy4irYqbdVPq+1Xl65+vSZ6TWuBXsHKgsG1AWvrC1UK5YV969zX7V1PWC9Z37Vh+oadGz4ViYquFNsXlxV/2CjceOUbh2/Kv5nclLSpq8S5ZM9m0mbp5t4tnlsOlqqX5pcObg3Z2rQN31a07fX2Rdsvl80o27uDtkO5o788uLxlp8nOzTs/VKRU9FT6VDbu0t21Ydf4btHuG3u89jTs1dtbvPf9Psm+21UBVU3VZtVl+0n7s/c/romq6fiW+21drU5tce3HA9ID/QcjDrbXudTVHdI9VFKP1ivrRw7HH77+ne93LQ02DVWNnMbiI3BEeeTp9wnf9x4NOtp2jHus4QfTH3YdZx0vakKa8ppGm1Oa+1tiW7pPzD7R1ureevxH2x8PnDQ8WXlK81TJadrpgtOTZ/LPjJ2VnX1+LvncYNuitnvnY87fag9v77oQdOHSRf+L5zu8O85c8rh08rLb5RNXuFearzpfbep06jz+k9NPx7ucu5quuVxrue56vbV7ZvfpG543zt30vXnxFv/W1Z45Pd2983pv98X39d8W3X5yJ/3Oy7vZdyfurbxPvF/0QO1B2UPdh9U/W/7c2O/cf2rAd6Dz0dxH9waFg8/+kfWPD0MFj5mPy4YNhuueOD45OeI/cv3p/KdDz2TPJp4X/qL+y64XFi9++NXr187RmNGhl/KXk79tfKX96sDrGa/bxsLGHr7JeDMxXvRW++3Bd9x3He+j3w9P5Hwgfyj/aPmx9VPQp/uTGZOT/wQDmPP8YzMt2wAAACBjSFJNAAB6JQAAgIMAAPn/AACA6QAAdTAAAOpgAAA6mAAAF2+SX8VGAAACZ0lEQVR42mzSP4icZRTF4ee+38xOkp2sG5cQxVJIIaaKkICxTkqJjQhpJFYiop2F1YKFQqoUVpEoCBYSS7dfOxVFWGIsokUE/0TEye7OzPe977XYNWk83b0cDoffvXHWGxkKYjt0N1fi+FaJIzNIFSJ0kDXn0z5nF1O9Sp5PzaizamLD2NELo5W4sOwXqqX/04o1R2wg9PYs/GXUmTjqpGNxwvWdFzz19Akvjj+XUkYTggylFLfml93due+tZ7+y577BrkJnbNWke8yHmzvgi/4lq+WU1XjCsThl2p1ya3GZ4KNrt03KuhXH0SkkkbTOL5+u2PnuZ/D8axtGMTaKsbOvrINP3v/W3Y9XhCJjQCrUWRedVpaq3nvn7oHXrz8jD8PfvnEGbL0716LXytIoxqizkups4R/VwhB7hpi7sXkbXNo86bkrazK5sXnbEHND7BvMLcykOotz3vlxvZw+faRb08VEiVC64rPdSw/pZ/Ly9EutNi3TkHOLOvN3u3OnHNx7MFio5qq5Ifdce/WHhwEfXPnekPuq/UPPQhrAKOV0MFdyRFQFRefr7Z9wRrb0zfYd1aCpGmr2BvtSTkcp1wZLnX0tx4oQjeHX+UF97P75QGspM7VMqTfopVwb0aY1F4ZWlFK1SCVDHQKUEvphj0ztkEdrvZoLtOkoNS2XlkHJIlroIky7Jw8atDSJdQ/aPTUdtJBaLqVmlJpqQataCZKhY/L4HwcEI/Qbv1v8tivbIdVG1UtNnPVmFmPEoT9l/Dc9Ujp42Mx4uGl6I5pmgdjGzaLbopsdJqZHWZnqtKkXcZU8D/8OAPAMQ4kD8KK1AAAAAElFTkSuQmCCiVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAEJGlDQ1BJQ0MgUHJvZmlsZQAAOBGFVd9v21QUPolvUqQWPyBYR4eKxa9VU1u5GxqtxgZJk6XtShal6dgqJOQ6N4mpGwfb6baqT3uBNwb8AUDZAw9IPCENBmJ72fbAtElThyqqSUh76MQPISbtBVXhu3ZiJ1PEXPX6yznfOec7517bRD1fabWaGVWIlquunc8klZOnFpSeTYrSs9RLA9Sr6U4tkcvNEi7BFffO6+EdigjL7ZHu/k72I796i9zRiSJPwG4VHX0Z+AxRzNRrtksUvwf7+Gm3BtzzHPDTNgQCqwKXfZwSeNHHJz1OIT8JjtAq6xWtCLwGPLzYZi+3YV8DGMiT4VVuG7oiZpGzrZJhcs/hL49xtzH/Dy6bdfTsXYNY+5yluWO4D4neK/ZUvok/17X0HPBLsF+vuUlhfwX4j/rSfAJ4H1H0qZJ9dN7nR19frRTeBt4Fe9FwpwtN+2p1MXscGLHR9SXrmMgjONd1ZxKzpBeA71b4tNhj6JGoyFNp4GHgwUp9qplfmnFW5oTdy7NamcwCI49kv6fN5IAHgD+0rbyoBc3SOjczohbyS1drbq6pQdqumllRC/0ymTtej8gpbbuVwpQfyw66dqEZyxZKxtHpJn+tZnpnEdrYBbueF9qQn93S7HQGGHnYP7w6L+YGHNtd1FJitqPAR+hERCNOFi1i1alKO6RQnjKUxL1GNjwlMsiEhcPLYTEiT9ISbN15OY/jx4SMshe9LaJRpTvHr3C/ybFYP1PZAfwfYrPsMBtnE6SwN9ib7AhLwTrBDgUKcm06FSrTfSj187xPdVQWOk5Q8vxAfSiIUc7Z7xr6zY/+hpqwSyv0I0/QMTRb7RMgBxNodTfSPqdraz/sDjzKBrv4zu2+a2t0/HHzjd2Lbcc2sG7GtsL42K+xLfxtUgI7YHqKlqHK8HbCCXgjHT1cAdMlDetv4FnQ2lLasaOl6vmB0CMmwT/IPszSueHQqv6i/qluqF+oF9TfO2qEGTumJH0qfSv9KH0nfS/9TIp0Wboi/SRdlb6RLgU5u++9nyXYe69fYRPdil1o1WufNSdTTsp75BfllPy8/LI8G7AUuV8ek6fkvfDsCfbNDP0dvRh0CrNqTbV7LfEEGDQPJQadBtfGVMWEq3QWWdufk6ZSNsjG2PQjp3ZcnOWWing6noonSInvi0/Ex+IzAreevPhe+CawpgP1/pMTMDo64G0sTCXIM+KdOnFWRfQKdJvQzV1+Bt8OokmrdtY2yhVX2a+qrykJfMq4Ml3VR4cVzTQVz+UoNne4vcKLoyS+gyKO6EHe+75Fdt0Mbe5bRIf/wjvrVmhbqBN97RD1vxrahvBOfOYzoosH9bq94uejSOQGkVM6sN/7HelL4t10t9F4gPdVzydEOx83Gv+uNxo7XyL/FtFl8z9ZAHF4bBsrEwAAAAlwSFlzAAALEwAACxMBAJqcGAAAByVJREFUWAm1l1uIldcVx9d3ruMZZzRaay+pCjFJH6LSRqxQqA1NH0pBiH3Qp774kEAg4EOkxKdQSCjUFvpm6YsNVNoSaGjFtmga2yZgCIIawdv04g2kM7Uz6lzO+c758v/t/9lzTB/61Oxhn7332muv9V+3vb8pnooDVRkzZ4oY/LmK6mQZa05frX6yFJ9Ae7x4qd2IuV1FFM9WMfhaI9Z+pQBAL+aiEZ0QgNBm2YuZmxHF9VZMXqmivFaLweUyuteWYvHGVPWr2f+F7YvF/ola9DZGVJsHUXs8YvBEK1ZrXt9URDwqxY1BdGMQvWjGqkgA+iLUtazHuADUoowHYugKTilaR7SIpZjWqOMRfY090RbasS4JglpFtzWIcqwZa+pSqnWVcLLXijXpZCFpvbgb/VhMe8huMLPylWkci8/oSD8xJq7hj4WUWvXrlbqVrUyKtBYdpX3Bh9YbzsdErwRgbZKyFP+KdqxPssu4l2hDAOOxIj6bCHigKWRNCcpMCHHHB4TJLc+TXxKHnC51Ct+Qgxl/TZ0qE5Be/EdWTwjqQuJJAPIB8qAZk4kZoXJnvHH+27Hq0+0YX12PH+w7E3/8zbWkitN2M8pS7kCKZ761OV55c2fcm+nG7J1e7N/+e3m2nbyKQcAhnHWZLC86B1rxiFRvSIkIgJHFVWzZ+qk4fG5HEr4wV8buVb+Vuv5QeVZsi/HeW//eHZ1HbNfLT5+Jc2dndBav9KXugfqc+pLsv6Xxvk6kVheumnpDnXlTVMZWfHh+Li6cdOKvmGzEC69+WTskzwr1SfUJ9ZWp7z/0pWXlF9+ejQtnUdCWnAxQ+al5Tdz80lIVEP8x9eZQWCQwOTAhNc34Re+rUW8U0S+r2Ns8nWzBKgONBOeX3V3RaCpPRN7XeFcO7yYl+InML2U3VdBVHszHzbSXYLBJkuTSQzBuphoYZ7X/u8O30gFAHHxzi+Yop8ETcfDXW5JyKMd/fFuO9l3mYuwLAl5gbMg8QuKdYQg4Zjcxo7HikMeIn37vcizes9Ide9bGhs9NLPN9YX0ndnzHpbZ4vx9HXr6kc6Sobo2hIkuzOnIh0xMFRlvc0waWL+p3UePCQ/Myjjx/JSnl59CJbUkJgl75g+ZD/D978Yrc7EuMPe4ESo6OYsaasiiX7tADAyny5cGtyMHsDxzFnP0Tx6Z0SfsW27B1PHZ+c13seGZdbNo2Lo6Iu7e7cfznfxc/8ggNQBhZI9dSs2c5k+rFaHBXmZhd32xTGdlZPvzDvefj9XddlgeObYVpuf1o3zkpyrEnCJwBDjlmr9i7XP3jgrYkDamhEqRA8UOBxZ53tcOtBbgyzr53M65f8DU6sVZ1o067cfFBvP+XGzrDOa5s+JkTShIc+dBtlLOLlRpqAUDc+yqQMnViNq81edDVnPixno/vP/dXjn2svbbnPa1RiqXEHVkYQ06RWygnFEtpbZDLAJws2X1OHgfCv+hiRkZU8Y+pmbjwzjTE1D48PR1TV+5IMErgsjex2A8TJrqCHH9Cw6U0BGBkPUWrKTZnPq4L9WqIOFvEO8ml+vbRvyUB/Jw6OiUa9GydM58qQl6lTrNHyiENrwyTkOvXLziVkMlOOsesVKyIFtZB1zfDAGvdyj4xtkD7yHQ8Ynn4hCrwvYA+DOJCSlXAZl3MjNQobNzVPK7gJm0AiPsQyEg0c6s1cbEB5X08AmDz1TTLucApzHHyJgADvUqVysJMKOSicLRQl+emOIvbnaw+ot2pSTzl5zzJVjPaZ6ix7zCSN4E1shOAWnqbyYH8bOqd1h9AGJ0qtl6LRBubcBKxbo6xh60kWlbLjgG4NJ2ETkwqbl7SeUXVSCq+BF1C2bWEgEO4CxBGvOydGmu3ooXv7AEogLFqn2JtWKO8yc9xAmDxjhGiWMOQXe63zCvHtIjOpGOIwvGJlhRQepyzaiu0MQ4MnFhuT7CiJQC+sUg4jtOYO+1IH9OdCwgBSmOkP2r60CarHeXMjxw3PGyvOBnN670EgOPOc1yEYgDYCxbqTPDXki1srChi4R6lpQ+uDmVFDtkA5GH1qJEvQFgacqCFT37pyP+Y+DMJs0Y54NgbiIVn61jhEUrNARuNIi3vOQf8iUeQuNzILe4b/jFZ7RDYJhTbVRaJTxyWh8PgO93hQJCBsSa2GQyyoLlBzWDxgnm9l0JgADgNgVxElCH22xs4NCsaieSUyzWXaSTLDAPlGQB0Kt6JaqpzYjkJQT9id60aNwqZjVqlz9Kqp+JcfDjOAqhirNoCI6MelpVPAjZ/CbFv45Y9YNcicqDMKm/Xo/FPJdMlqZ9SIK7qSrrci9mbl6q3/DGQ5f7XuK347rgKeuMgiicEfLPmT0rGY1K5SdI/ryritlMbJrr/PZ8+I8qf9PF8qhMrT39QHfHLkhj/fz/bi+eb83F/VxX1b6jWvt6KdTs/AvvCmqXE235jAAAAAElFTkSuQmCC", _urls : [ { type: "application/x-suggestions+json", method: "GET",
--- a/browser/components/search/test/head.js +++ b/browser/components/search/test/head.js @@ -141,17 +141,17 @@ function promiseNewEngine(basename, opti //Default the setAsCurrent option to true. let setAsCurrent = options.setAsCurrent == undefined ? true : options.setAsCurrent; info("Waiting for engine to be added: " + basename); Services.search.init({ onInitComplete: function() { let url = getRootDirectory(gTestPath) + basename; let current = Services.search.currentEngine; - Services.search.addEngine(url, Ci.nsISearchEngine.TYPE_MOZSEARCH, "", false, { + Services.search.addEngine(url, null, "", false, { onSuccess: function (engine) { info("Search engine added: " + basename); if (setAsCurrent) { Services.search.currentEngine = engine; } registerCleanupFunction(() => { if (setAsCurrent) { Services.search.currentEngine = current;
--- a/browser/modules/test/browser_ContentSearch.js +++ b/browser/modules/test/browser_ContentSearch.js @@ -312,17 +312,17 @@ function waitForNewEngine(basename, numI for (let i = 0; i < numImages; i++) { expectedSearchEvents.push("CurrentState"); } let eventPromises = expectedSearchEvents.map(e => waitForTestMsg(e)); // Wait for addEngine(). let addDeferred = Promise.defer(); let url = getRootDirectory(gTestPath) + basename; - Services.search.addEngine(url, Ci.nsISearchEngine.TYPE_MOZSEARCH, "", false, { + Services.search.addEngine(url, null, "", false, { onSuccess: function (engine) { info("Search engine added: " + basename); addDeferred.resolve(engine); }, onError: function (errCode) { ok(false, "addEngine failed with error code " + errCode); addDeferred.reject(); },
--- a/netwerk/base/nsIBrowserSearchService.idl +++ b/netwerk/base/nsIBrowserSearchService.idl @@ -17,17 +17,17 @@ interface nsISearchSubmission : nsISuppo readonly attribute nsIInputStream postData; /** * The URI to submit a search to. */ readonly attribute nsIURI uri; }; -[scriptable, uuid(65fd517b-6bda-4bac-bbe1-42de1b3a7df6)] +[scriptable, uuid(620bd920-0491-48c8-99a8-d6047e64802d)] interface nsISearchEngine : nsISupports { /** * Gets a nsISearchSubmission object that contains information about what to * send to the search engine, including the URI and postData, if applicable. * * @param data * Data to add to the submission object. @@ -111,29 +111,16 @@ interface nsISearchEngine : nsISupports * {window} the content window for the window performing the search * * @throws NS_ERROR_INVALID_ARG if options is omitted or lacks required * elemeents */ void speculativeConnect(in jsval options); /** - * Supported search engine types. - */ - const unsigned long TYPE_MOZSEARCH = 1; - const unsigned long TYPE_SHERLOCK = 2; - const unsigned long TYPE_OPENSEARCH = 3; - - /** - * Supported search engine data types. - */ - const unsigned long DATA_XML = 1; - const unsigned long DATA_TEXT = 2; - - /** * An optional shortcut alias for the engine. * When non-null, this is a unique identifier. */ attribute AString alias; /** * A text description describing the engine. */ @@ -155,21 +142,16 @@ interface nsISearchEngine : nsISupports readonly attribute AString name; /** * A URL string pointing to the engine's search form. */ readonly attribute AString searchForm; /** - * The search engine type. - */ - readonly attribute long type; - - /** * An optional unique identifier for this search engine within the context of * the distribution, as provided by the distributing entity. */ readonly attribute AString identifier; /** * Gets a string representing the hostname from which search results for a * given responseType are returned, minus the leading "www." (if present). @@ -309,18 +291,18 @@ interface nsIBrowserSearchService : nsIS * value is false, the engine will be added to the list upon successful * load, but it will not be selected as the current engine. * * @param callback * A nsISearchInstallCallback that will be notified when the * addition is complete, or if the addition fails. It will not be * called if addEngine throws an exception. * - * @throws NS_ERROR_FAILURE if the type is invalid, or if the description - * file cannot be successfully loaded. + * @throws NS_ERROR_FAILURE if the description file cannot be successfully + * loaded. */ void addEngine(in AString engineURL, in long dataType, in AString iconURL, in boolean confirm, [optional] in nsISearchInstallCallback callback); /** * Adds a new search engine, without asking the user for confirmation and * without starting to use it right away. *
--- a/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js +++ b/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js @@ -437,18 +437,17 @@ function* addTestEngine(basename, httpSe } Services.obs.removeObserver(obs, "browser-search-engine-modified"); do_register_cleanup(() => Services.search.removeEngine(engine)); resolve(engine); }, "browser-search-engine-modified", false); do_print("Adding engine from URL: " + dataUrl + basename); - Services.search.addEngine(dataUrl + basename, - Ci.nsISearchEngine.DATA_XML, null, false); + Services.search.addEngine(dataUrl + basename, null, null, false); }); } // Ensure we have a default search engine and the keyword.enabled preference // set. add_task(function ensure_search_engine() { // keyword.enabled is necessary for the tests to see keyword searches. Services.prefs.setBoolPref("keyword.enabled", true);
--- a/toolkit/components/search/nsSearchService.js +++ b/toolkit/components/search/nsSearchService.js @@ -92,19 +92,16 @@ const SEARCH_SERVICE_TOPIC = "brow */ const SEARCH_SERVICE_METADATA_WRITTEN = "write-metadata-to-disk-complete"; /** * Sent whenever the cache is fully written to disk. */ const SEARCH_SERVICE_CACHE_WRITTEN = "write-cache-to-disk-complete"; -const SEARCH_TYPE_MOZSEARCH = Ci.nsISearchEngine.TYPE_MOZSEARCH; -const SEARCH_TYPE_OPENSEARCH = Ci.nsISearchEngine.TYPE_OPENSEARCH; - // Delay for lazy serialization (ms) const LAZY_SERIALIZE_DELAY = 100; // Delay for batching invalidation of the JSON cache (ms) const CACHE_INVALIDATION_DELAY = 1000; // Current cache version. This should be incremented if the format of the cache // file is modified. @@ -858,39 +855,16 @@ function getVerificationHash(aName) { let hasher = Cc["@mozilla.org/security/hash;1"] .createInstance(Ci.nsICryptoHash); hasher.init(hasher.SHA256); hasher.update(data, data.length); return hasher.finish(true); } - -/** - * Used to verify a given DOM node's localName and namespaceURI. - * @param aElement - * The element to verify. - * @param aLocalNameArray - * An array of strings to compare against aElement's localName. - * @param aNameSpaceArray - * An array of strings to compare against aElement's namespaceURI. - * - * @returns false if aElement is null, or if its localName or namespaceURI - * does not match one of the elements in the aLocalNameArray or - * aNameSpaceArray arrays, respectively. - * @throws NS_ERROR_INVALID_ARG if aLocalNameArray or aNameSpaceArray are null. - */ -function checkNameSpace(aElement, aLocalNameArray, aNameSpaceArray) { - if (!aLocalNameArray || !aNameSpaceArray) - FAIL("missing aLocalNameArray or aNameSpaceArray for checkNameSpace"); - return (aElement && - (aLocalNameArray.indexOf(aElement.localName) != -1) && - (aNameSpaceArray.indexOf(aElement.namespaceURI) != -1)); -} - /** * Safely close a nsISafeOutputStream. * @param aFOS * The file output stream to close. */ function closeSafeOutputStream(aFOS) { if (aFOS instanceof Ci.nsISafeOutputStream) { try { @@ -1421,18 +1395,16 @@ Engine.prototype = { }, // Set to true if the engine has a preferred icon (an icon that should not be // overridden by a non-preferred icon). _hasPreferredIcon: null, // Whether the engine is hidden from the user. _hidden: null, // The engine's name. _name: null, - // The engine type. See engine types (TYPE_) defined above. - _type: null, // The name of the charset used to submit the search terms. _queryCharset: null, // The engine's raw SearchForm value (URL string pointing to a search form). __searchForm: null, get _searchForm() { return this.__searchForm; }, set _searchForm(aValue) { @@ -1964,31 +1936,24 @@ Engine.prototype = { /** * Initialize this Engine object from the collected data. */ _initFromData: function SRCH_ENG_initFromData() { ENSURE_WARN(this._data, "Can't init an engine with no data!", Cr.NS_ERROR_UNEXPECTED); - // Find out what type of engine we are - if (checkNameSpace(this._data, [MOZSEARCH_LOCALNAME], - [MOZSEARCH_NS_10])) { - - LOG("_init: Initing MozSearch plugin from " + this._location); - - this._type = SEARCH_TYPE_MOZSEARCH; - this._parse(); - - } else if (checkNameSpace(this._data, [OPENSEARCH_LOCALNAME], - OPENSEARCH_NAMESPACES)) { - - LOG("_init: Initing OpenSearch plugin from " + this._location); - - this._type = SEARCH_TYPE_OPENSEARCH; + // Ensure we have a supported engine type before attempting to parse it. + let element = this._data; + if ((element.localName == MOZSEARCH_LOCALNAME && + element.namespaceURI == MOZSEARCH_NS_10) || + (element.localName == OPENSEARCH_LOCALNAME && + OPENSEARCH_NAMESPACES.indexOf(element.namespaceURI) != -1)) { + LOG("_init: Initing search plugin from " + this._location); + this._parse(); } else FAIL(this._location + " is not a valid search plugin.", Cr.NS_ERROR_FAILURE); // No need to keep a ref to our data (which in some cases can be a document // element) past this point this._data = null; @@ -2202,17 +2167,16 @@ Engine.prototype = { this.__id = aJson._id; this._name = aJson._name; this._description = aJson.description; if (aJson._hasPreferredIcon == undefined) this._hasPreferredIcon = true; else this._hasPreferredIcon = false; this._hidden = aJson._hidden; - this._type = aJson.type || SEARCH_TYPE_MOZSEARCH; this._queryCharset = aJson.queryCharset || DEFAULT_QUERY_CHARSET; this.__searchForm = aJson.__searchForm; this.__installLocation = aJson._installLocation || SEARCH_APP_DIR; this._updateInterval = aJson._updateInterval || null; this._updateURL = aJson._updateURL || null; this._iconUpdateURL = aJson._iconUpdateURL || null; if (aJson._readOnly == undefined) this._readOnly = true; @@ -2261,18 +2225,16 @@ Engine.prototype = { if (this._updateInterval || !aFilter) json._updateInterval = this._updateInterval; if (this._updateURL || !aFilter) json._updateURL = this._updateURL; if (this._iconUpdateURL || !aFilter) json._iconUpdateURL = this._iconUpdateURL; if (!this._hasPreferredIcon || !aFilter) json._hasPreferredIcon = this._hasPreferredIcon; - if (this.type != SEARCH_TYPE_MOZSEARCH || !aFilter) - json.type = this.type; if (this.queryCharset != DEFAULT_QUERY_CHARSET || !aFilter) json.queryCharset = this.queryCharset; if (!this._readOnly || !aFilter) json._readOnly = this._readOnly; if (this._extensionID) { json.extensionID = this._extensionID; } @@ -2646,20 +2608,16 @@ Engine.prototype = { let selfURL = this._getURLOfType(URLTYPE_OPENSEARCH, "self"); return !!(this._updateURL || this._iconUpdateURL || selfURL); }, get name() { return this._name; }, - get type() { - return this._type; - }, - get searchForm() { return this._getSearchFormWithPurpose(); }, _getSearchFormWithPurpose(aPurpose = "") { // First look for a <Url rel="searchform"> var searchFormURL = this._getURLOfType(URLTYPE_SEARCH_HTML, "searchform"); if (searchFormURL) {
--- a/toolkit/components/search/tests/xpcshell/data/engineMaker.sjs +++ b/toolkit/components/search/tests/xpcshell/data/engineMaker.sjs @@ -12,31 +12,22 @@ const { classes: Cc, interfaces: Ci, uti function handleRequest(request, response) { let engineData = JSON.parse(unescape(request.queryString).replace("+", " ")); if (!engineData.baseURL) { response.setStatusLine(request.httpVersion, 500, "baseURL required"); return; } - engineData.engineType = engineData.engineType || Ci.nsISearchEngine.TYPE_OPENSEARCH; engineData.name = engineData.name || "Generated test engine"; engineData.description = engineData.description || "Generated test engine description"; engineData.method = engineData.method || "GET"; response.setStatusLine(request.httpVersion, 200, "OK"); - - switch (engineData.engineType) { - case Ci.nsISearchEngine.TYPE_OPENSEARCH: - createOpenSearchEngine(response, engineData); - break; - default: - response.setStatusLine(request.httpVersion, 404, "Unsupported engine type"); - break; - } + createOpenSearchEngine(response, engineData); } /** * Create an OpenSearch engine for the given base URL. */ function createOpenSearchEngine(response, engineData) { let params = "", queryString = ""; if (engineData.method == "POST") {
--- a/toolkit/components/search/tests/xpcshell/head_search.js +++ b/toolkit/components/search/tests/xpcshell/head_search.js @@ -418,17 +418,17 @@ var addTestEngines = Task.async(function resolve(); } catch (ex) { reject(ex); } }, "browser-search-engine-modified", false); if (item.xmlFileName) { Services.search.addEngine(gDataUrl + item.xmlFileName, - Ci.nsISearchEngine.DATA_XML, null, false); + null, null, false); } else { Services.search.addEngineWithDetails(item.name, ...item.details); } }); } return engines; });
--- a/toolkit/components/search/tests/xpcshell/test_addEngine_callback.js +++ b/toolkit/components/search/tests/xpcshell/test_addEngine_callback.js @@ -42,54 +42,51 @@ add_test(function simple_callback_test() do_check_true(!!engine); do_check_neq(engine.name, Services.search.defaultEngine.name); run_next_test(); }, onError: function (errorCode) { do_throw("search callback returned error: " + errorCode); } } - Services.search.addEngine(gDataUrl + "engine.xml", - Ci.nsISearchEngine.DATA_XML, + Services.search.addEngine(gDataUrl + "engine.xml", null, null, false, searchCallback); }); // Test of the search callback on duplicate engine failures add_test(function duplicate_failure_test() { let searchCallback = { onSuccess: function (engine) { do_throw("this addition should not have succeeded"); }, onError: function (errorCode) { do_check_true(!!errorCode); do_check_eq(errorCode, Ci.nsISearchInstallCallback.ERROR_DUPLICATE_ENGINE); run_next_test(); } } // Re-add the same engine added in the previous test - Services.search.addEngine(gDataUrl + "engine.xml", - Ci.nsISearchEngine.DATA_XML, + Services.search.addEngine(gDataUrl + "engine.xml", null, null, false, searchCallback); }); // Test of the search callback on failure to load the engine failures add_test(function load_failure_test() { let searchCallback = { onSuccess: function (engine) { do_throw("this addition should not have succeeded"); }, onError: function (errorCode) { do_check_true(!!errorCode); do_check_eq(errorCode, Ci.nsISearchInstallCallback.ERROR_UNKNOWN_FAILURE); run_next_test(); } } // Try adding an engine that doesn't exist - Services.search.addEngine("http://invalid/data/engine.xml", - Ci.nsISearchEngine.DATA_XML, + Services.search.addEngine("http://invalid/data/engine.xml", null, null, false, searchCallback); }); function run_test() { updateAppInfo(); useHttpServer(); run_next_test();
--- a/toolkit/components/search/tests/xpcshell/test_json_cache.js +++ b/toolkit/components/search/tests/xpcshell/test_json_cache.js @@ -231,17 +231,16 @@ add_test(function test_cache_write() { }); var EXPECTED_ENGINE = { engine: { name: "Test search engine", alias: null, description: "A test search engine (based on Google search)", searchForm: "http://www.google.com/", - type: Ci.nsISearchEngine.TYPE_MOZSEARCH, wrappedJSObject: { _extensionID: "test-addon-id@mozilla.org", "_iconURL": "data:image/png;base64,AAABAAEAEBAAAAEAGABoAwAAFgAAACgAAAAQAAAAIAAAAAEAGAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADs9Pt8xetPtu9FsfFNtu%2BTzvb2%2B%2Fne4dFJeBw0egA%2FfAJAfAA8ewBBegAAAAD%2B%2FPtft98Mp%2BwWsfAVsvEbs%2FQeqvF8xO7%2F%2F%2F63yqkxdgM7gwE%2FggM%2BfQA%2BegBDeQDe7PIbotgQufcMufEPtfIPsvAbs%2FQvq%2Bfz%2Bf%2F%2B%2B%2FZKhR05hgBBhQI8hgBAgAI9ewD0%2B%2Fg3pswAtO8Cxf4Kw%2FsJvvYAqupKsNv%2B%2Fv7%2F%2FP5VkSU0iQA7jQA9hgBDgQU%2BfQH%2F%2Ff%2FQ6fM4sM4KsN8AteMCruIqqdbZ7PH8%2Fv%2Fg6Nc%2Fhg05kAA8jAM9iQI%2BhQA%2BgQDQu6b97uv%2F%2F%2F7V8Pqw3eiWz97q8%2Ff%2F%2F%2F%2F7%2FPptpkkqjQE4kwA7kAA5iwI8iAA8hQCOSSKdXjiyflbAkG7u2s%2F%2B%2F%2F39%2F%2F7r8utrqEYtjQE8lgA7kwA7kwA9jwA9igA9hACiWSekVRyeSgiYSBHx6N%2F%2B%2Fv7k7OFRmiYtlAA5lwI7lwI4lAA7kgI9jwE9iwI4iQCoVhWcTxCmb0K%2BooT8%2Fv%2F7%2F%2F%2FJ2r8fdwI1mwA3mQA3mgA8lAE8lAE4jwA9iwE%2BhwGfXifWvqz%2B%2Ff%2F58u%2Fev6Dt4tr%2B%2F%2F2ZuIUsggA7mgM6mAM3lgA5lgA6kQE%2FkwBChwHt4dv%2F%2F%2F728ei1bCi7VAC5XQ7kz7n%2F%2F%2F6bsZkgcB03lQA9lgM7kwA2iQktZToPK4r9%2F%2F%2F9%2F%2F%2FSqYK5UwDKZAS9WALIkFn%2B%2F%2F3%2F%2BP8oKccGGcIRJrERILYFEMwAAuEAAdX%2F%2Ff7%2F%2FP%2B%2BfDvGXQLIZgLEWgLOjlf7%2F%2F%2F%2F%2F%2F9QU90EAPQAAf8DAP0AAfMAAOUDAtr%2F%2F%2F%2F7%2B%2Fu2bCTIYwDPZgDBWQDSr4P%2F%2Fv%2F%2F%2FP5GRuABAPkAA%2FwBAfkDAPAAAesAAN%2F%2F%2B%2Fz%2F%2F%2F64g1C5VwDMYwK8Yg7y5tz8%2Fv%2FV1PYKDOcAAP0DAf4AAf0AAfYEAOwAAuAAAAD%2F%2FPvi28ymXyChTATRrIb8%2F%2F3v8fk6P8MAAdUCAvoAAP0CAP0AAfYAAO4AAACAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAQAA", _urls : [ { type: "application/x-suggestions+json", method: "GET", template: "http://suggestqueries.google.com/complete/search?output=firefox&client=firefox" +
--- a/toolkit/components/search/tests/xpcshell/test_notifications.js +++ b/toolkit/components/search/tests/xpcshell/test_notifications.js @@ -63,12 +63,10 @@ function run_test() { do_register_cleanup(function cleanup() { Services.obs.removeObserver(search_observer, "browser-search-engine-modified"); }); do_test_pending(); Services.obs.addObserver(search_observer, "browser-search-engine-modified", false); - Services.search.addEngine(gDataUrl + "engine.xml", - Ci.nsISearchEngine.DATA_XML, - null, false); + Services.search.addEngine(gDataUrl + "engine.xml", null, null, false); }
--- a/toolkit/components/search/tests/xpcshell/test_searchSuggest.js +++ b/toolkit/components/search/tests/xpcshell/test_searchSuggest.js @@ -31,31 +31,28 @@ function run_test() { })); run_next_test(); } add_task(function* add_test_engines() { let getEngineData = { baseURL: gDataUrl, - engineType: Ci.nsISearchEngine.TYPE_OPENSEARCH, name: "GET suggestion engine", method: "GET", }; let postEngineData = { baseURL: gDataUrl, - engineType: Ci.nsISearchEngine.TYPE_OPENSEARCH, name: "POST suggestion engine", method: "POST", }; let unresolvableEngineData = { baseURL: "http://example.invalid/", - engineType: Ci.nsISearchEngine.TYPE_OPENSEARCH, name: "Offline suggestion engine", method: "GET", }; [getEngine, postEngine, unresolvableEngine] = yield addTestEngines([ { name: getEngineData.name, xmlFileName: "engineMaker.sjs?" + JSON.stringify(getEngineData),