author | Jim Blandy <jimb@mozilla.com> |
Fri, 19 Sep 2014 15:10:00 -0700 | |
changeset 206274 | b1cbc50798346c4cf4f361a7958ba3c98263971a |
parent 206273 | e739ab313ce7b1bb0d8a1290bedf16d5edc248e9 |
child 206275 | ef6d81ac0bba5aea6cc3cae4aa91b4ed8910c4c8 |
push id | 49394 |
push user | jblandy@mozilla.com |
push date | Fri, 19 Sep 2014 22:10:19 +0000 |
treeherder | mozilla-inbound@ed38f85902f7 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | terrence |
bugs | 1063247 |
milestone | 35.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
js/public/UbiNode.h | file | annotate | diff | comparison | revisions | |
js/src/vm/UbiNode.cpp | file | annotate | diff | comparison | revisions |
--- a/js/public/UbiNode.h +++ b/js/public/UbiNode.h @@ -266,17 +266,17 @@ class Node { } template<typename T> Node &operator=(const Rooted<T *> &root) { construct(root.get()); return *this; } // Constructors accepting SpiderMonkey's other generic-pointer-ish types. - explicit Node(JS::Value value); + Node(JS::HandleValue value); Node(JSGCTraceKind kind, void *ptr); // copy construction and copy assignment just use memcpy, since we know // instances contain nothing but a vtable pointer and a data pointer. // // To be completely correct, concrete classes could provide a virtual // 'construct' member function, which we could invoke on rhs to construct an // instance in our storage. But this is good enough; there's no need to jump
--- a/js/src/vm/UbiNode.cpp +++ b/js/src/vm/UbiNode.cpp @@ -55,17 +55,17 @@ Node::Node(JSGCTraceKind kind, void *ptr case JSTRACE_BASE_SHAPE: construct(static_cast<js::BaseShape *>(ptr)); break; case JSTRACE_TYPE_OBJECT: construct(static_cast<js::types::TypeObject *>(ptr)); break; default: MOZ_CRASH("bad JSGCTraceKind passed to JS::ubi::Node::Node"); } } -Node::Node(Value value) +Node::Node(HandleValue value) { if (value.isObject()) construct(&value.toObject()); else if (value.isString()) construct(value.toString()); else if (value.isSymbol()) construct(value.toSymbol()); else