Bug 1237201 part 5 - Ignore Vector OOM in JSMainRuntimeCompartmentsReporter. r=njn
authorJan de Mooij <jdemooij@mozilla.com>
Thu, 14 Jan 2016 15:19:28 +0100
changeset 279979 b072874b9253c3ade313f8e47645eb9f7ba9b3ed
parent 279978 13e1546239391ef5a00058e83a549b8364b911e0
child 279980 9746d5b3df80873c384864a6f1b8cfdaa3fa63c4
push id70281
push userjandemooij@gmail.com
push dateThu, 14 Jan 2016 14:18:23 +0000
treeherdermozilla-inbound@cdd2accc2d1a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn
bugs1237201
milestone46.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1237201 part 5 - Ignore Vector OOM in JSMainRuntimeCompartmentsReporter. r=njn
js/xpconnect/src/XPCJSRuntime.cpp
--- a/js/xpconnect/src/XPCJSRuntime.cpp
+++ b/js/xpconnect/src/XPCJSRuntime.cpp
@@ -2659,17 +2659,17 @@ class JSMainRuntimeCompartmentsReporter 
         // silently ignore OOM errors
         Data* data = static_cast<Data*>(vdata);
         nsCString path;
         GetCompartmentName(c, path, &data->anonymizeID, /* replaceSlashes = */ true);
         path.Insert(js::IsSystemCompartment(c)
                     ? NS_LITERAL_CSTRING("js-main-runtime-compartments/system/")
                     : NS_LITERAL_CSTRING("js-main-runtime-compartments/user/"),
                     0);
-        data->paths.append(path);
+        (void)data->paths.append(path);
     }
 
     NS_IMETHOD CollectReports(nsIMemoryReporterCallback* cb,
                               nsISupports* closure, bool anonymize) override
     {
         // First we collect the compartment paths.  Then we report them.  Doing
         // the two steps interleaved is a bad idea, because calling |cb|
         // from within CompartmentCallback() leads to all manner of assertions.