Bug 1463621 - Part 3: Rename application name. r=pbro
authorDaisuke Akatsuka <dakatsuka@mozilla.com>
Mon, 10 Sep 2018 13:10:12 +0900
changeset 435665 afcb44c66c5ff4c0d3a3e3b3036c48caf70ef088
parent 435664 46032e616f5d6d2b6abcb5f531abc8753d7715d2
child 435666 5d653605ce14ca4afe2b5c81b6dd7d304fd087dc
push id107699
push userdakatsuka@mozilla.com
push dateTue, 11 Sep 2018 10:59:05 +0000
treeherdermozilla-inbound@5d653605ce14 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspbro
bugs1463621
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1463621 - Part 3: Rename application name. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D5500
devtools/client/inspector/animation/animation.js
devtools/client/inspector/animation/test/head.js
devtools/client/inspector/inspector.js
devtools/client/shared/telemetry.js
devtools/client/shared/test/browser_telemetry_sidebar.js
--- a/devtools/client/inspector/animation/animation.js
+++ b/devtools/client/inspector/animation/animation.js
@@ -105,18 +105,18 @@ class AnimationInspector {
     this.animationsFront = new AnimationsFront(target.client, target.form);
     this.animationsFront.setWalkerActor(this.inspector.walker);
 
     this.animationsCurrentTimeListeners = [];
     this.isCurrentTimeSet = false;
 
     const provider = createElement(Provider,
       {
-        id: "newanimationinspector",
-        key: "newanimationinspector",
+        id: "animationinspector",
+        key: "animationinspector",
         store: this.inspector.store
       },
       App(
         {
           addAnimationsCurrentTimeListener,
           direction,
           emitEventForTest,
           getAnimatedPropertyMap,
@@ -270,17 +270,17 @@ class AnimationInspector {
     }
 
     return this.inspector.walker.getNodeFromActor(actorID, ["node"]);
   }
 
   isPanelVisible() {
     return this.inspector && this.inspector.toolbox && this.inspector.sidebar &&
            this.inspector.toolbox.currentToolId === "inspector" &&
-           this.inspector.sidebar.getCurrentTabID() === "newanimationinspector";
+           this.inspector.sidebar.getCurrentTabID() === "animationinspector";
   }
 
   onAnimationStateChanged() {
     // Simply update the animations since the state has already been updated.
     this.updateState([...this.state.animations]);
   }
 
   /**
@@ -620,17 +620,17 @@ class AnimationInspector {
     this.currentTimeTimer = currentTimeTimer;
   }
 
   toggleElementPicker() {
     this.inspector.toolbox.highlighterUtils.togglePicker();
   }
 
   async update() {
-    const done = this.inspector.updating("newanimationinspector");
+    const done = this.inspector.updating("animationinspector");
 
     const selection = this.inspector.selection;
     const animations =
       selection.isConnected() && selection.isElementNode()
       ? await this.animationsFront.getAnimationPlayersForNode(selection.nodeFront)
       : [];
     this.updateState(animations);
     this.setAnimationStateChangedListenerEnabled(true);
--- a/devtools/client/inspector/animation/test/head.js
+++ b/devtools/client/inspector/animation/test/head.js
@@ -5,17 +5,17 @@
 "use strict";
 
 /* import-globals-from ../../test/head.js */
 // Import the inspector's head.js first (which itself imports shared-head.js).
 Services.scriptloader.loadSubScript(
   "chrome://mochitests/content/browser/devtools/client/inspector/test/head.js", this);
 
 const FRAME_SCRIPT_URL = CHROME_URL_ROOT + "doc_frame_script.js";
-const TAB_NAME = "newanimationinspector";
+const TAB_NAME = "animationinspector";
 
 const ANIMATION_L10N =
   new LocalizationHelper("devtools/client/locales/animationinspector.properties");
 
 // Auto clean-up when a test ends.
 // Clean-up all prefs that might have been changed during a test run
 // (safer here because if the test fails, then the pref is never reverted)
 registerCleanupFunction(() => {
@@ -400,17 +400,17 @@ const mouseOutOnTargetNode = function(an
 /**
  * Select animation inspector in sidebar and toolbar.
  *
  * @param {InspectorPanel} inspector
  */
 const selectAnimationInspector = async function(inspector) {
   await inspector.toolbox.selectTool("inspector");
   const onUpdated = inspector.once("inspector-updated");
-  inspector.sidebar.select("newanimationinspector");
+  inspector.sidebar.select("animationinspector");
   await onUpdated;
   await waitForRendering(inspector.animationinspector);
 };
 
 /**
  * Set the inspector's current selection to a node or to the first match of the
  * given css selector and wait for the animations to be displayed
  *
--- a/devtools/client/inspector/inspector.js
+++ b/devtools/client/inspector/inspector.js
@@ -930,17 +930,17 @@ Inspector.prototype = {
       },
       defaultTab == layoutId);
 
     this.sidebar.queueExistingTab(
       "computedview",
       INSPECTOR_L10N.getStr("inspector.sidebar.computedViewTitle"),
       defaultTab == "computedview");
 
-    const animationId = "newanimationinspector";
+    const animationId = "animationinspector";
     const animationTitle =
       INSPECTOR_L10N.getStr("inspector.sidebar.animationInspectorTitle");
     this.sidebar.queueTab(
       animationId,
       animationTitle,
       {
         props: {
           id: animationId,
--- a/devtools/client/shared/telemetry.js
+++ b/devtools/client/shared/telemetry.js
@@ -570,20 +570,16 @@ class Telemetry {
   toolOpened(id) {
     const charts = getChartsFromToolId(id);
 
     if (!charts) {
       return;
     }
 
     if (charts.useTimedEvent) {
-      if (id === "newanimationinspector") {
-        id = "animationinspector";
-      }
-
       this.preparePendingEvent("devtools.main", "tool_timer", id, null, [
         "os",
         "time_open",
         "session_id"
       ]);
       this.addEventProperty("devtools.main", "tool_timer", id, null,
                             "time_open", this.msSystemNow());
     }
@@ -614,20 +610,16 @@ class Telemetry {
   toolClosed(id, sessionId) {
     const charts = getChartsFromToolId(id);
 
     if (!charts) {
       return;
     }
 
     if (charts.useTimedEvent) {
-      if (id === "newanimationinspector") {
-        id = "animationinspector";
-      }
-
       const sig = `devtools.main,tool_timer,${id},null`;
       const event = PENDING_EVENTS.get(sig);
       const time = this.msSystemNow() - event.extra.time_open;
 
       this.addEventProperties("devtools.main", "tool_timer", id, null, {
         "time_open": time,
         "os": this.osNameAndVersion,
         "session_id": sessionId
@@ -659,19 +651,16 @@ function getChartsFromToolId(id) {
   let countHist = null;
   let countScalar = null;
 
   id = id.toUpperCase();
 
   if (id === "PERFORMANCE") {
     id = "JSPROFILER";
   }
-  if (id === "NEWANIMATIONINSPECTOR") {
-    id = "ANIMATIONINSPECTOR";
-  }
 
   switch (id) {
     case "ABOUTDEBUGGING":
     case "BROWSERCONSOLE":
     case "CANVASDEBUGGER":
     case "DOM":
     case "INSPECTOR":
     case "JSBROWSERDEBUGGER":
--- a/devtools/client/shared/test/browser_telemetry_sidebar.js
+++ b/devtools/client/shared/test/browser_telemetry_sidebar.js
@@ -15,27 +15,27 @@ const DATA = [
   {
     timestamp: null,
     category: "devtools.main",
     method: "sidepanel_changed",
     object: "inspector",
     value: null,
     extra: {
       oldpanel: "computedview",
-      newpanel: "newanimationinspector"
+      newpanel: "animationinspector"
     }
   },
   {
     timestamp: null,
     category: "devtools.main",
     method: "sidepanel_changed",
     object: "inspector",
     value: null,
     extra: {
-      oldpanel: "newanimationinspector",
+      oldpanel: "animationinspector",
       newpanel: "fontinspector"
     }
   },
   {
     timestamp: null,
     category: "devtools.main",
     method: "sidepanel_changed",
     object: "inspector",
@@ -59,27 +59,27 @@ const DATA = [
   {
     timestamp: null,
     category: "devtools.main",
     method: "sidepanel_changed",
     object: "inspector",
     value: null,
     extra: {
       oldpanel: "computedview",
-      newpanel: "newanimationinspector"
+      newpanel: "animationinspector"
     }
   },
   {
     timestamp: null,
     category: "devtools.main",
     method: "sidepanel_changed",
     object: "inspector",
     value: null,
     extra: {
-      oldpanel: "newanimationinspector",
+      oldpanel: "animationinspector",
       newpanel: "fontinspector"
     }
   },
   {
     timestamp: null,
     category: "devtools.main",
     method: "sidepanel_changed",
     object: "inspector",
@@ -125,17 +125,17 @@ add_task(async function() {
   gBrowser.removeCurrentTab();
 });
 
 function testSidebar(toolbox) {
   info("Testing sidebar");
 
   const inspector = toolbox.getCurrentPanel();
   let sidebarTools = ["computedview", "layoutview", "fontinspector",
-                      "newanimationinspector"];
+                      "animationinspector"];
 
   // Concatenate the array with itself so that we can open each tool twice.
   sidebarTools = [...sidebarTools, ...sidebarTools];
 
   return new Promise(resolve => {
     // See TOOL_DELAY for why we need setTimeout here
     setTimeout(function selectSidebarTab() {
       const tool = sidebarTools.pop();