Bug 1194033 - Added background selector to TwoLinPageRow & removed selector override from RemoteTabsListView r=mcomella
authorAngel Bouzo <angelb7575@gmail.com>
Fri, 08 Jan 2016 18:03:14 -0800
changeset 286246 aefae03959a33e8e5761e448e7ff6aad0610402e
parent 286245 1b2fddb62fcc4d1038f2e57b619a56c4f1837507
child 286247 8ef94be995a453f5c464278c53478ba8c8554f81
child 286307 3f936e1ca0bca816512e17c8fe5fb9dabc58ad84
push id72696
push usercbook@mozilla.com
push dateTue, 01 Mar 2016 14:25:42 +0000
treeherdermozilla-inbound@0f47155c48a1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmcomella
bugs1194033
milestone47.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1194033 - Added background selector to TwoLinPageRow & removed selector override from RemoteTabsListView r=mcomella MozReview-Commit-ID: A9TwBiTbP0B
mobile/android/base/resources/layout/home_item_row.xml
mobile/android/base/resources/values/styles.xml
--- a/mobile/android/base/resources/layout/home_item_row.xml
+++ b/mobile/android/base/resources/layout/home_item_row.xml
@@ -1,9 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <org.mozilla.gecko.home.TwoLinePageRow xmlns:android="http://schemas.android.com/apk/res/android"
+                                       style="@style/Widget.TwoLinePageRow"
                                        android:layout_width="match_parent"
                                        android:layout_height="@dimen/page_row_height"
                                        android:minHeight="@dimen/page_row_height"/>
--- a/mobile/android/base/resources/values/styles.xml
+++ b/mobile/android/base/resources/values/styles.xml
@@ -109,17 +109,19 @@
         <item name="android:drawablePadding">6dip</item>
         <item name="android:gravity">center_vertical</item>
         <item name="android:textAppearance">@style/TextAppearance</item>
         <item name="android:singleLine">true</item>
         <item name="android:ellipsize">middle</item>
         <item name="android:textSize">@dimen/menu_item_textsize</item>
     </style>
 
-    <style name="Widget.TwoLinePageRow" />
+    <style name="Widget.TwoLinePageRow" >
+        <item name="android:background">@color/pressed_about_page_header_grey</item>
+    </style>
 
     <style name="Widget.TwoLinePageRow.Title">
         <item name="android:textAppearance">@style/TextAppearance.Widget.Home.ItemTitle</item>
     </style>
 
     <style name="Widget.TwoLinePageRow.Url">
         <item name="android:textAppearance">@style/TextAppearance.Widget.Home.ItemDescription</item>
         <item name="android:includeFontPadding">false</item>
@@ -552,17 +554,16 @@
     <style name="Widget.RemoteTabsItemView" parent="Widget.TwoLinePageRow"/>
 
     <style name="Widget.RemoteTabsClientView" parent="Widget.TwoLinePageRow">
         <item name="android:background">@color/about_page_header_grey</item>
     </style>
 
     <style name="Widget.RemoteTabsListView" parent="Widget.HomeListView">
         <item name="android:childDivider">@color/toolbar_divider_grey</item>
-        <item name="android:drawSelectorOnTop">true</item>
     </style>
 
     <style name="Widget.HistoryListView" parent="Widget.HomeListView">
         <item name="android:childDivider">@color/toolbar_divider_grey</item>
         <item name="android:drawSelectorOnTop">true</item>
     </style>
 
     <!-- TabsLayout Row -->