Bug 1349905 - Make _beginRemoveTab consistently return a boolean. r=dao
authorHrishikesh Barman <hrishikeshbman@gmail.com>
Fri, 24 Mar 2017 19:14:16 +0530
changeset 349511 adb38e68486ec6f5b8114d776c2f806dac7c536b
parent 349510 ddc2134eb60392a934dd04677c3aa0d6782df981
child 349512 249037d28c7896fadafe4b58e2458b11a4866cf4
push id88435
push userdgottwald@mozilla.com
push dateFri, 24 Mar 2017 14:01:31 +0000
treeherdermozilla-inbound@adb38e68486e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1349905
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1349905 - Make _beginRemoveTab consistently return a boolean. r=dao
browser/base/content/tabbrowser.xml
--- a/browser/base/content/tabbrowser.xml
+++ b/browser/base/content/tabbrowser.xml
@@ -2700,17 +2700,17 @@
               // than closing the window right away. If the caller opts in, take
               // the fast path.
               if (closeWindow &&
                   aCloseWindowFastpath &&
                   this._removingTabs.length == 0) {
                 // This call actually closes the window, unless the user
                 // cancels the operation.  We are finished here in both cases.
                 this._windowIsClosing = window.closeWindow(true, window.warnAboutClosingWindow);
-                return null;
+                return false;
               }
 
               newTab = true;
             }
 
             aTab.closing = true;
             this._removingTabs.push(aTab);
             this._visibleTabs = null; // invalidate cache