mozilla-inbound: changeset 496506:ad77820040a48597771ae151dcd4df7759d49654

author	moz-wptsync-bot <wptsync@mozilla.com>
	Thu, 03 Oct 2019 09:53:36 +0000
changeset 496506	ad77820040a48597771ae151dcd4df7759d49654
parent 496505	2e579e2ef17baf8d1eede029bcb549aafb8a7173
child 496507	81a5ed5da59438c547ac721792ab1ed901f7e827
push id	114144
push user	wptsync@mozilla.com
push date	Mon, 07 Oct 2019 10:18:06 +0000
treeherder	mozilla-inbound@aa50a7580ed4 [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	testonly
bugs	1579168, 19318
milestone	71.0a1
first release with	nightly linux32 4651f71eeb54 / 71.0a1 / 20191007215350 / files nightly linux64 4651f71eeb54 / 71.0a1 / 20191007215350 / files nightly mac 4651f71eeb54 / 71.0a1 / 20191007215350 / files nightly win32 4651f71eeb54 / 71.0a1 / 20191007215350 / files nightly win64 4651f71eeb54 / 71.0a1 / 20191007215350 / files
last release without	nightly linux32 3955e0a93047 / 71.0a1 / 20191007092954 / files nightly linux64 3955e0a93047 / 71.0a1 / 20191007092954 / files nightly mac 3955e0a93047 / 71.0a1 / 20191007092954 / files nightly win32 3955e0a93047 / 71.0a1 / 20191007092954 / files nightly win64 3955e0a93047 / 71.0a1 / 20191007092954 / files

Bug 1579168 [wpt PR 19318] - [Gecko Bug 1579168] Fix updating metadata for results that are expected but have known intermittents, a=testonly Automatic update from web-platform-tests Fix updating metadata for results that are expected but have known intermittents We were assuming that in the case that the status matched expected we'd have no expected entry in the log data. But actually it was being set to None, so handle both those cases. Differential Revision: https://phabricator.services.mozilla.com/D44874 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1579168 gecko-commit: 4fe3084ae3e4ce4f20ebf6c0cf333381ac93a0c8 gecko-integration-branch: central gecko-reviewers: maja_zf -- Fix formatting -- wpt-commits: 44df76773a7aa7361f6ca077180b3479d257cb16, 7c7f09fecc6dd4bcb38f97c9de4080038b067dac wpt-pr: 19318

testing/web-platform/tests/tools/wptrunner/wptrunner/metadata.py

file | annotate | diff | comparison | revisions

--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/metadata.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/metadata.py
@@ -697,18 +697,17 @@ class TestFileData(object):
                             subtest_id = subtest_id.decode("utf8")
                         item_expected = test_expected.get_subtest(subtest_id)
 
                     if prop == "status":
                         status, known_intermittent = unpack_result(value)
                         value = Result(status,
                                        known_intermittent,
                                        default_expected_by_type[self.item_type,
-                                                                subtest_id is not None],
-                        )
+                                                                subtest_id is not None])
                         item_expected.set_result(run_info, value)
                     elif prop == "asserts":
                         item_expected.set_asserts(run_info, value)
 
         expected.update(full_update=full_update,
                         disable_intermittent=disable_intermittent)
         for test in expected.iterchildren():
             for subtest in test.iterchildren():