Bug 1119062 - enable unicode-range in release builds. r=dbaron
authorJohn Daggett <jdaggett@mozilla.com>
Fri, 20 Nov 2015 14:46:47 +0900
changeset 273440 ab494cc7de0d797e2818f9b547a9338986cb738e
parent 273439 ca10d0f073cab0142b5566776535f8fa030d6486
child 273441 55df0ae1a9f5cadd6cd4cc2e9874250acc42a0ed
push id68282
push userjdaggett@mozilla.com
push dateFri, 20 Nov 2015 05:48:07 +0000
treeherdermozilla-inbound@55df0ae1a9f5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdbaron
bugs1119062
milestone45.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1119062 - enable unicode-range in release builds. r=dbaron
gfx/thebes/gfxUserFontSet.cpp
layout/reftests/font-face/reftest.list
modules/libpref/init/all.js
testing/profiles/prefs_general.js
--- a/gfx/thebes/gfxUserFontSet.cpp
+++ b/gfx/thebes/gfxUserFontSet.cpp
@@ -124,18 +124,17 @@ gfxUserFontEntry::gfxUserFontEntry(gfxUs
     mSrcList = aFontFaceSrcList;
     mSrcIndex = 0;
     mWeight = aWeight;
     mStretch = aStretch;
     mStyle = aStyle;
     mFeatureSettings.AppendElements(aFeatureSettings);
     mLanguageOverride = aLanguageOverride;
 
-    if (aUnicodeRanges &&
-        Preferences::GetBool("layout.css.unicode-range.enabled")) {
+    if (aUnicodeRanges) {
         mCharacterMap = new gfxCharacterMap(*aUnicodeRanges);
     }
 }
 
 gfxUserFontEntry::~gfxUserFontEntry()
 {
 }
 
--- a/layout/reftests/font-face/reftest.list
+++ b/layout/reftests/font-face/reftest.list
@@ -45,31 +45,31 @@ skip HTTP(..) == src-list-local-localize
 
 # postscript name lookup
 # fontconfig only supports postscript name lookup from 2.10.92, Android/B2G not supported
 skip-if(B2G||Mulet) fails-if(Android) random-if(gtkWidget) == src-list-local-ps.html src-list-local-full-ref.html # bug 773482
 # Mac-specific test of 100 weight faces
 random-if(!cocoaWidget) == helveticaneue-ultra.html helveticaneue-ultra-ref.html
 
 HTTP(..) == order-1.html order-1-ref.html
-pref(layout.css.unicode-range.enabled,true) HTTP(..) == order-2.html order-2-ref.html
-pref(layout.css.unicode-range.enabled,true) HTTP(..) == order-3.html order-3-ref.html
+HTTP(..) == order-2.html order-2-ref.html
+HTTP(..) == order-3.html order-3-ref.html
 HTTP(..) == multiple-in-family-1.html multiple-in-family-1-ref.html
 HTTP(..) == multiple-in-family-1b.html multiple-in-family-1-ref.html
 HTTP(..) != multiple-in-family-1.html multiple-in-family-1-notref.html
 HTTP(..) == prop-order-over-rule-order-1a.html prop-order-over-rule-order-2a.html
 HTTP(..) == prop-order-over-rule-order-1b.html prop-order-over-rule-order-2b.html
 HTTP(..) != prop-order-over-rule-order-1a.html prop-order-over-rule-order-1b.html
 skip-if(B2G||Mulet) HTTP(..) == cross-iframe-1.html cross-iframe-1-ref.html # bug 773482 # Initial mulet triage: parity with B2G/B2G Desktop
 
 # unicode-range
-pref(layout.css.unicode-range.enabled,true) HTTP(..) == unicoderange-1.html unicoderange-1-ref.html
-pref(layout.css.unicode-range.enabled,true) HTTP(..) == unicoderange-2.html unicoderange-2-ref.html
-pref(layout.css.unicode-range.enabled,true) HTTP(..) == unicoderange-3.html unicoderange-3-ref.html
-pref(layout.css.unicode-range.enabled,true) HTTP(..) == unicoderange-4.html unicoderange-4-ref.html
+HTTP(..) == unicoderange-1.html unicoderange-1-ref.html
+HTTP(..) == unicoderange-2.html unicoderange-2-ref.html
+HTTP(..) == unicoderange-3.html unicoderange-3-ref.html
+HTTP(..) == unicoderange-4.html unicoderange-4-ref.html
 
 # Dynamic changes
 # we need to skip these because of the bug that's causing order-2.html to fail
 HTTP(..) == enable-sheet-1.html enable-sheet-1-ref.html
 skip HTTP(..) == enable-sheet-2.html multiple-in-family-1-ref.html
 skip HTTP(..) == enable-sheet-3.html multiple-in-family-1-ref.html
 HTTP(..) == enable-sheet-4.html enable-sheet-4-ref.html
 HTTP(..) == enable-sheet-5.html enable-sheet-4-ref.html
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -2292,23 +2292,16 @@ pref("layout.css.getBoxQuads.enabled", t
 
 // Is support for GeometryUtils.convert*FromNode enabled?
 #ifdef RELEASE_BUILD
 pref("layout.css.convertFromNode.enabled", false);
 #else
 pref("layout.css.convertFromNode.enabled", true);
 #endif
 
-// Is support for unicode-range enabled?
-#ifdef RELEASE_BUILD
-pref("layout.css.unicode-range.enabled", false);
-#else
-pref("layout.css.unicode-range.enabled", true);
-#endif
-
 // Is support for CSS "text-align: true X" enabled?
 pref("layout.css.text-align-true-value.enabled", false);
 
 // Is support for CSS "float: inline-{start,end}" and
 // "clear: inline-{start,end}" enabled?
 #if defined(MOZ_B2G) || defined(NIGHTLY_BUILD)
 pref("layout.css.float-logical-values.enabled", true);
 #else
--- a/testing/profiles/prefs_general.js
+++ b/testing/profiles/prefs_general.js
@@ -156,19 +156,16 @@ user_pref("layout.css.grid.enabled", tru
 user_pref("layout.css.contain.enabled", true);
 
 // Enable CSS object-fit & object-position for testing
 user_pref("layout.css.object-fit-and-position.enabled", true);
 
 // Enable CSS Ruby for testing
 user_pref("layout.css.ruby.enabled", true);
 
-// Enable unicode-range for testing
-user_pref("layout.css.unicode-range.enabled", true);
-
 // Enable webkit prefixed CSS features for testing
 user_pref("layout.css.prefixes.webkit", true);
 
 // Disable spammy layout warnings because they pollute test logs
 user_pref("layout.spammy_warnings.enabled", false);
 
 // Enable Media Source Extensions for testing
 user_pref("media.mediasource.mp4.enabled", true);