Bug 1576240 [wpt PR 18644] - Changed the WebXR required/optional features to take an array of 'any', a=testonly
☠☠ backed out by f0cc770df971 ☠ ☠
authorBrandon Jones <bajones@chromium.org>
Tue, 27 Aug 2019 04:46:15 +0000
changeset 490205 ab15bb545725c2f47f1defda934c824155e91407
parent 490204 a61cb494a0bf642833f039cfbd37f9c84e8e8b13
child 490206 6e19b535159cdfcf5e5dc1012e2c6a0eb26205d1
push id113984
push userwptsync@mozilla.com
push dateTue, 27 Aug 2019 23:48:20 +0000
treeherdermozilla-inbound@8feea1e30794 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1576240, 18644, 996949, 1766601, 690049
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1576240 [wpt PR 18644] - Changed the WebXR required/optional features to take an array of 'any', a=testonly Automatic update from web-platform-tests Changed the WebXR required/optional features to take an array of 'any' Bug: 996949 Change-Id: Ifd918931d1c4a8ad976655230efb1f5e70f53956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766601 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#690049} -- wpt-commits: 449d483adbc38cb77e07da93bf871f6f9a5db803 wpt-pr: 18644
testing/web-platform/tests/webxr/xrDevice_requestSession_optionalFeatures.https.html
testing/web-platform/tests/webxr/xrDevice_requestSession_requiredFeatures_unknown.https.html
--- a/testing/web-platform/tests/webxr/xrDevice_requestSession_optionalFeatures.https.html
+++ b/testing/web-platform/tests/webxr/xrDevice_requestSession_optionalFeatures.https.html
@@ -14,14 +14,20 @@
 
     xr_session_promise_test(
       "Tests requestSession accepts XRSessionInit dictionary with empty feature lists",
       (session) => {
         assert_not_equals(session, null);
       }, TRACKED_IMMERSIVE_DEVICE, 'immersive-vr', {requiredFeatures: [], optionalFeatures: []});
 
     xr_session_promise_test(
-      "Tests requestSession ignores unknown optionalFeatures",
+      "Tests requestSession ignores unknown strings in optionalFeatures",
       (session) => {
         assert_not_equals(session, null);
       }, TRACKED_IMMERSIVE_DEVICE, 'immersive-vr', {optionalFeatures: ['unicorns']});
+
+    xr_session_promise_test(
+      "Tests requestSession ignores unknown objects in optionalFeatures",
+      (session) => {
+        assert_not_equals(session, null);
+      }, TRACKED_IMMERSIVE_DEVICE, 'immersive-vr', {optionalFeatures: [{ unicorns: "please" }]});
   </script>
 </body>
--- a/testing/web-platform/tests/webxr/xrDevice_requestSession_requiredFeatures_unknown.https.html
+++ b/testing/web-platform/tests/webxr/xrDevice_requestSession_requiredFeatures_unknown.https.html
@@ -13,15 +13,23 @@
           .then( (controller) => new Promise((resolve) => {
             navigator.xr.test.simulateUserActivation( () => {
               resolve(promise_rejects(
                 t,
                 "NotSupportedError",
                 navigator.xr.requestSession('immersive-vr',
                                             {requiredFeatures: ['undefined-unicorns']}),
                 "unexpected requestSession success"
-              ))
+              ).then(() => {
+                return promise_rejects(
+                  t,
+                  "NotSupportedError",
+                  navigator.xr.requestSession('immersive-vr',
+                                            {requiredFeatures: [{unicorns: "please"}]}),
+                  "unexpected requestSession success with unknown object"
+                );
+              }));
             });
           }));
       });
 
   </script>
 </body>