Bug 1176886 - Add UselessParent ignore to tab_queue_prompt. r=mhaigh
authorMichael Comella <michael.l.comella@gmail.com>
Tue, 23 Jun 2015 10:55:04 -0700
changeset 250187 aacb3d4718c1240caa23c1d16f90fbb468181c5b
parent 250186 af86cc9586aaa84e3be04d1c75f39de84c17f107
child 250188 b9608f525b1fd218a178eb25cd7b93d83cd35218
push id61471
push usercbook@mozilla.com
push dateThu, 25 Jun 2015 09:33:34 +0000
treeherdermozilla-inbound@5b38df79819f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhaigh
bugs1176886
milestone41.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1176886 - Add UselessParent ignore to tab_queue_prompt. r=mhaigh
mobile/android/base/resources/layout/tab_queue_prompt.xml
mobile/android/base/resources/layout/tab_queue_toast.xml
--- a/mobile/android/base/resources/layout/tab_queue_prompt.xml
+++ b/mobile/android/base/resources/layout/tab_queue_prompt.xml
@@ -1,22 +1,25 @@
 <?xml version="1.0" encoding="utf-8"?>
 
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
+<!-- (lint: UselessParent) The second-outermost layout doesn't have a parent to position itself
+     against and would take up the whole screen without the outermost layout. -->
 <FrameLayout
     xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/tab_queue_container"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:clipChildren="false"
-    android:clipToPadding="false">
+    android:clipToPadding="false"
+    tools:ignore="UselessParent">
 
     <LinearLayout
         android:layout_width="@dimen/tab_queue_container_width"
         android:layout_height="wrap_content"
         android:layout_gravity="bottom|center"
         android:background="@android:color/white"
         android:orientation="vertical">
 
--- a/mobile/android/base/resources/layout/tab_queue_toast.xml
+++ b/mobile/android/base/resources/layout/tab_queue_toast.xml
@@ -1,19 +1,22 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
+<!-- (lint: UselessParent) The second-outermost layout doesn't have a parent to position itself
+     against and would take up the whole screen without the outermost layout. -->
 <FrameLayout
     xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
 
     android:layout_width="match_parent"
-    android:layout_height="wrap_content">
+    android:layout_height="wrap_content"
+    tools:ignore="UselessParent">
 
     <LinearLayout
         android:id="@+id/toast"
         style="@style/Toast">
 
         <TextView
             android:id="@+id/toast_message"
             style="@style/ToastMessage"