Bug 1534001 - Add page title to about:config r=Gijs,flod
authorSuriyaa Sundararuban <mozilla@suriyaa.tk>
Thu, 04 Apr 2019 11:54:58 +0000
changeset 467981 a7b2c2564ead4c7e029270b71b2b74c93576707c
parent 467980 dfc8060c8b0ef0b0efd89c2b437bfda5f23f8d69
child 467982 95484a7dc30b364232a5cc905bdfdf4f665d369b
push id112667
push useraiakab@mozilla.com
push dateThu, 04 Apr 2019 16:12:45 +0000
treeherdermozilla-inbound@230bb363f2f3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs, flod
bugs1534001
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1534001 - Add page title to about:config r=Gijs,flod The about:config site doesn't have an appropriate page title. Differential Revision: https://phabricator.services.mozilla.com/D22846
browser/components/aboutconfig/content/aboutconfig.html
browser/components/aboutconfig/test/browser/browser_basic.js
browser/locales/en-US/browser/aboutConfig.ftl
--- a/browser/components/aboutconfig/content/aboutconfig.html
+++ b/browser/components/aboutconfig/content/aboutconfig.html
@@ -10,17 +10,17 @@
           href="chrome://global/skin/in-content/common.css">
     <link rel="stylesheet" media="screen, projection" type="text/css"
           href="chrome://global/skin/in-content/info-pages.css" title="infop">
     <link rel="stylesheet" type="text/css"
           href="chrome://browser/content/aboutconfig/aboutconfig.css">
     <link rel="localization" href="browser/aboutConfig.ftl">
     <script type="application/javascript"
             src="chrome://browser/content/aboutconfig/aboutconfig.js"></script>
-    <title data-l10n-id="about-config-title"></title>
+    <title data-l10n-id="about-config2-title"></title>
   </head>
   <body>
     <div class="container" role="alertdialog" aria-labelledby="warningTitle"
          aria-describedby="warningDescription">
 
       <div class="title">
         <h1 id="warningTitle" class="title-text"
             data-l10n-id="about-config-warning-title"></h1>
--- a/browser/components/aboutconfig/test/browser/browser_basic.js
+++ b/browser/components/aboutconfig/test/browser/browser_basic.js
@@ -14,17 +14,17 @@ add_task(async function setup() {
       ["test.aboutconfig.userValueLikeLocalized",
        "chrome://test/locale/testing.properties"],
     ],
   });
 });
 
 add_task(async function test_load_title() {
   await AboutConfigTest.withNewTab(async function() {
-    Assert.equal(this.document.title, "about:config");
+    Assert.equal(this.document.title, "Advanced Configurations");
   });
 });
 
 add_task(async function test_load_settings() {
   await AboutConfigTest.withNewTab(async function() {
     // Test if page contains elements.
     Assert.equal(this.getRow(PREF_NUMBER_DEFAULT_ZERO).value, 0);
     Assert.equal(this.getRow(PREF_STRING_DEFAULT_EMPTY).value, "");
--- a/browser/locales/en-US/browser/aboutConfig.ftl
+++ b/browser/locales/en-US/browser/aboutConfig.ftl
@@ -3,17 +3,17 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 # An old map warning, see https://en.wikipedia.org/wiki/Here_be_dragons
 about-config-warning-title = Here be dragons!
 about-config-warning-text = Changing these advanced settings can be harmful to the stability, security, and performance of this application. You should only continue if you are sure of what you are doing.
 about-config-warning-checkbox = Annoy me again, please!
 about-config-warning-button = I accept the risk
 
-about-config-title = about:config
+about-config2-title = Advanced Configurations
 
 about-config-search-input =
     .placeholder = Search
 about-config-show-all = Show All
 
 about-config-pref-add = Add
 about-config-pref-toggle = Toggle
 about-config-pref-edit = Edit