Bug 1488585 - Use ImageRendering property to provide proper filtering for list-style-image on WR. r=nical
authorHenrik Winnemöller <h.winnemoeller@web.de>
Fri, 07 Sep 2018 22:29:36 +0200
changeset 435221 a79ed7cdda373e993746bf7a16320c94fe940b0b
parent 435220 723580244cfbfc5c1ad76be4dc7dcd7e8f2ec39b
child 435222 a5b2607fc1885b4f86cc7421fda89a19737788e4
push id107601
push userapavel@mozilla.com
push dateFri, 07 Sep 2018 21:36:18 +0000
treeherdermozilla-inbound@a79ed7cdda37 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnical
bugs1488585, 1488555
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1488585 - Use ImageRendering property to provide proper filtering for list-style-image on WR. r=nical Use the ImageRendering needed for Bug 1488555 to provide the correct ImageRendering argument for the PushImage call at the end of CreateWebRenderCommandsForImage instead of always using Auto filtering.
layout/generic/nsBulletFrame.cpp
--- a/layout/generic/nsBulletFrame.cpp
+++ b/layout/generic/nsBulletFrame.cpp
@@ -491,21 +491,18 @@ BulletRenderer::CreateWebRenderCommandsF
   Maybe<wr::ImageKey> key = aManager->CommandBuilder().CreateImageKey(
     aItem, container, aBuilder, aResources, rendering, aSc, size, Nothing());
   if (key.isNothing()) {
     return true;  // Nothing to do
   }
 
   wr::LayoutRect dest = wr::ToRoundedLayoutRect(destRect);
 
-  aBuilder.PushImage(dest,
-                     dest,
-                     !aItem->BackfaceIsHidden(),
-                     wr::ImageRendering::Auto,
-                     key.value());
+  aBuilder.PushImage(
+    dest, dest, !aItem->BackfaceIsHidden(), rendering, key.value());
 
   return true;
 }
 
 bool
 BulletRenderer::CreateWebRenderCommandsForPath(nsDisplayItem* aItem,
                                                wr::DisplayListBuilder& aBuilder,
                                                wr::IpcResourceUpdateQueue& aResources,