No bug: [try-staging] Use `release-type` to determine whether the build will generate a stub installer; r=Callek
authorTom Prince <mozilla@hocat.ca>
Tue, 16 Apr 2019 21:31:41 +0000
changeset 469815 a72c4fef3a4a
parent 469814 ac38a6790d00
child 469816 c4bdde9df111
push id112825
push usercbrindusan@mozilla.com
push dateWed, 17 Apr 2019 15:58:37 +0000
treeherdermozilla-inbound@7bd43da7830c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersCallek
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
No bug: [try-staging] Use `release-type` to determine whether the build will generate a stub installer; r=Callek Differential Revision: https://phabricator.services.mozilla.com/D15766
taskcluster/ci/build/windows.yml
taskcluster/taskgraph/transforms/build.py
--- a/taskcluster/ci/build/windows.yml
+++ b/taskcluster/ci/build/windows.yml
@@ -257,22 +257,25 @@ win32-shippable/opt:
     index:
         product: firefox
         job-name: win32-opt
         type: shippable
     attributes:
         shippable: true
         enable-full-crashsymbols: true
     stub-installer:
-        by-project:
-            default: false
-            mozilla-central: true
-            try: true
-            mozilla-beta: true
-            mozilla-release: true
+        by-release-type:
+            nightly: true
+            beta: true
+            release: true
+            default:
+                by-project:
+                    # browser/confvars.sh looks for nightly-try
+                    try: true
+                    default: false
     shipping-phase: build
     shipping-product: firefox
     treeherder:
         platform: windows2012-32-shippable/opt
         symbol: B
         tier: 1
     worker-type: aws-provisioner-v1/gecko-{level}-b-win2012
     worker:
@@ -816,22 +819,25 @@ win32-devedition-nightly/opt:
     index:
         product: devedition
         job-name: win32-opt
         type: nightly
     attributes:
         nightly: true
         enable-full-crashsymbols: true
     stub-installer:
-        by-project:
-            default: false
-            mozilla-central: true
-            try: true
-            mozilla-beta: true
-            mozilla-release: true
+        by-release-type:
+            nightly: true
+            beta: true
+            release: true
+            default:
+                by-project:
+                    # browser/confvars.sh looks for nightly-try
+                    try: true
+                    default: false
     shipping-phase: build
     shipping-product: devedition
     treeherder:
         platform: windows2012-32-devedition/opt
         symbol: N
         tier: 1
     worker-type: aws-provisioner-v1/gecko-{level}-b-win2012
     worker:
--- a/taskcluster/taskgraph/transforms/build.py
+++ b/taskcluster/taskgraph/transforms/build.py
@@ -38,17 +38,20 @@ def set_defaults(config, jobs):
 
         yield job
 
 
 @transforms.add
 def stub_installer(config, jobs):
     for job in jobs:
         resolve_keyed_by(
-            job, 'stub-installer', item_name=job['name'], project=config.params['project']
+            job, 'stub-installer', item_name=job['name'], project=config.params['project'],
+            **{
+                'release-type': config.params['release_type'],
+            }
         )
         job.setdefault('attributes', {})
         if job.get('stub-installer'):
             job['attributes']['stub-installer'] = job['stub-installer']
             job['worker']['env'].update({"USE_STUB_INSTALLER": "1"})
         if 'stub-installer' in job:
             del job['stub-installer']
         yield job