Bug 1336869 - modify the access key for 'unmute tab'. r=jaws
authorAlastor Wu <alwu@mozilla.com>
Tue, 07 Feb 2017 14:49:36 +0800
changeset 341243 a31cace18fc6cb25ebea5645de2ed755f17391da
parent 341242 ca78904394c05230fa20d155b2c2ec07ff5af16c
child 341244 414739984c09671ee55e40121589fbd1c26ed0d1
push id86667
push userkwierso@gmail.com
push dateWed, 08 Feb 2017 00:55:58 +0000
treeherdermozilla-inbound@497e7f87f137 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1336869, 1336309
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1336869 - modify the access key for 'unmute tab'. r=jaws Fork from bug1336309 comment2, unmuteTab used "M" as access key, but we should change to "m" because the character is lowercase in the label. MozReview-Commit-ID: 3q2luFLbFlQ
browser/base/content/test/general/browser_audioTabIcon.js
browser/locales/en-US/chrome/browser/browser.properties
--- a/browser/base/content/test/general/browser_audioTabIcon.js
+++ b/browser/base/content/test/general/browser_audioTabIcon.js
@@ -153,19 +153,20 @@ function* test_muting_using_menu(tab, ex
   // Show the popup menu
   let contextMenu = document.getElementById("tabContextMenu");
   let popupShownPromise = BrowserTestUtils.waitForEvent(contextMenu, "popupshown");
   EventUtils.synthesizeMouseAtCenter(tab, {type: "contextmenu", button: 2});
   yield popupShownPromise;
 
   // Check the menu
   let expectedLabel = expectMuted ? "Unmute Tab" : "Mute Tab";
+  let expectedAccessKey = expectMuted ? "m" : "M";
   let toggleMute = document.getElementById("context_toggleMuteTab");
   is(toggleMute.label, expectedLabel, "Correct label expected");
-  is(toggleMute.accessKey, "M", "Correct accessKey expected");
+  is(toggleMute.accessKey, expectedAccessKey, "Correct accessKey expected");
 
   is(toggleMute.hasAttribute("muted"), expectMuted, "Should have the correct state for the muted attribute");
   ok(!toggleMute.hasAttribute("soundplaying"), "Should not have the soundplaying attribute");
 
   yield play(tab);
 
   is(toggleMute.hasAttribute("muted"), expectMuted, "Should have the correct state for the muted attribute");
   ok(toggleMute.hasAttribute("soundplaying"), "Should have the soundplaying attribute");
--- a/browser/locales/en-US/chrome/browser/browser.properties
+++ b/browser/locales/en-US/chrome/browser/browser.properties
@@ -809,17 +809,17 @@ userContextNone.accesskey = N
 userContext.aboutPage.label = Manage containers
 userContext.aboutPage.accesskey = O
 
 userContextOpenLink.label = Open Link in New %S Tab
 
 muteTab.label = Mute Tab
 muteTab.accesskey = M
 unmuteTab.label = Unmute Tab
-unmuteTab.accesskey = M
+unmuteTab.accesskey = m
 playTab.label = Play Tab
 playTab.accesskey = l
 
 # LOCALIZATION NOTE (weakCryptoOverriding.message): %S is brandShortName
 weakCryptoOverriding.message = %S recommends that you don’t enter your password, credit card and other personal information on this website.
 revokeOverride.label = Don’t Trust This Website
 revokeOverride.accesskey = D