servo: Merge #19304 - Renamed mach test-perf -submit to --submit (from asajeffrey:test-perf-dash-dash-submit); r=jdm
authorAlan Jeffrey <ajeffrey@mozilla.com>
Mon, 20 Nov 2017 14:15:23 -0600
changeset 392792 a2c34dc1f3eb69a16d8a8f1f2c211ec0d9ec575c
parent 392791 69465fa861e14da6b903ec4f154abf355e5d6d79
child 392793 da5ab75b0e9b0aed981eb6cf29f73990fb4db9f5
push id97527
push usertoros@mozilla.com
push dateTue, 21 Nov 2017 10:20:05 +0000
treeherdermozilla-inbound@60d0f3ee0c43 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdm
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
servo: Merge #19304 - Renamed mach test-perf -submit to --submit (from asajeffrey:test-perf-dash-dash-submit); r=jdm <!-- Please describe your changes on the following line: --> The `-submit` option should be `--submit` (2 dashes, not one). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because they are test infrastructure <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 2469808b6e09548e7ac7213474afd29aede3c2bc
servo/python/servo/testing_commands.py
--- a/servo/python/servo/testing_commands.py
+++ b/servo/python/servo/testing_commands.py
@@ -170,17 +170,17 @@ class MachCommands(CommandBase):
                     return suite
         return None
 
     @Command('test-perf',
              description='Run the page load performance test',
              category='testing')
     @CommandArgument('--base', default=None,
                      help="the base URL for testcases")
-    @CommandArgument('-submit', '-a', default=False, action="store_true",
+    @CommandArgument('--submit', '-a', default=False, action="store_true",
                      help="submit the data to perfherder")
     def test_perf(self, base=None, submit=False):
         self.set_software_rendering_env(True)
 
         self.ensure_bootstrapped()
         env = self.build_env()
         cmd = ["bash", "test_perf.sh"]
         if base: