Bug 1575983 - Remove duplicate browser.* prefs. r=njn
authorKristen Wright <kwright@mozilla.com>
Sun, 01 Sep 2019 23:39:37 +0000
changeset 491276 9fffc1ffc199830292b54282a53a174f91cbd544
parent 491275 7deecbbc45df3f15f528eff0118c81a0276f244b
child 491277 e14cef561be1fd657eba217ea57453ee79d8f592
push id114020
push userrmaries@mozilla.com
push dateTue, 03 Sep 2019 09:51:48 +0000
treeherdermozilla-inbound@08b1736b12e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn
bugs1575983
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1575983 - Remove duplicate browser.* prefs. r=njn Removes the 15 duplicate browser.* prefs from all.js. Replaces default values in StaticPrefList.yaml with their all.js counterparts where needed. Imports comments from all.js. Differential Revision: https://phabricator.services.mozilla.com/D44254
modules/libpref/init/StaticPrefList.yaml
modules/libpref/init/all.js
--- a/modules/libpref/init/StaticPrefList.yaml
+++ b/modules/libpref/init/StaticPrefList.yaml
@@ -634,21 +634,21 @@
   mirror: always
 
 #---------------------------------------------------------------------------
 # Prefs starting with "browser."
 #---------------------------------------------------------------------------
 
 - name: browser.active_color
   type: String
-  value: ""
+  value: "#EE0000"
   mirror: never
 - name: browser.anchor_color
   type: String
-  value: ""
+  value: "#0000EE"
   mirror: never
 
 # See http://dev.w3.org/html5/spec/forms.html#attr-fe-autofocus
 - name: browser.autofocus
   type: bool
   value: true
   mirror: always
 
@@ -766,17 +766,17 @@
 # Content Blocking log for each top-level window.
 - name: browser.contentblocking.originlog.length
   type: uint32_t
   value: 32
   mirror: always
 
 - name: browser.display.background_color
   type: String
-  value: ""
+  value: "#FFFFFF"
   mirror: never
 
 # 0 = default: always, except in high contrast mode
 # 1 = always
 # 2 = never
 - name: browser.display.document_color_use
   type: RelaxedAtomicUint32
   value: 0
@@ -790,32 +790,33 @@
 
 - name: browser.display.focus_ring_width
   type: uint32_t
   value: 1
   mirror: always
 
 - name: browser.display.focus_background_color
   type: String
-  value: ""
+  value: "#117722"
   mirror: never
 
-# 0=solid, 1=dotted
+# Focus ring border style.
+# 0 = solid border, 1 = dotted border
 - name: browser.display.focus_ring_style
   type: uint32_t
   value: 1
   mirror: always
 
 - name: browser.display.focus_text_color
   type: String
-  value: ""
+  value: "#ffffff"
   mirror: never
 - name: browser.display.foreground_color
   type: String
-  value: ""
+  value: "#000000"
   mirror: never
 
 - name: browser.display.show_focus_rings
   type: bool
 # Focus rings are not shown on Mac or Android by default.
 #if defined(XP_MACOSX) || defined(ANDROID)
   value: false
 #else
@@ -833,17 +834,17 @@
 
 - name: browser.display.use_focus_colors
   type: bool
   value: false
   mirror: always
 
 - name: browser.display.use_system_colors
   type: bool
-  value: true
+  value: false
   mirror: always
 
 - name: browser.dom.window.dump.enabled
   type: RelaxedAtomicBool
   value: @IS_NOT_MOZILLA_OFFICIAL@
   mirror: always
 
 # Fix up common scheme typos?
@@ -950,17 +951,17 @@
 
 - name: browser.viewport.desktopWidth
   type: RelaxedAtomicInt32
   value: 980
   mirror: always
 
 - name: browser.visited_color
   type: String
-  value: ""
+  value: "#551A8B"
   mirror: never
 
 # Enable xul error pages.
 - name: browser.xul.error_pages.enabled
   type: bool
   value: true
   mirror: always
 
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -331,55 +331,35 @@ pref("ui.click_hold_context_menus", fals
 // 0 = false, 1 = true, 2 = autodetect.
 pref("ui.android.mouse_as_touch", 1);
 
 // Duration of timeout of incremental search in menus (ms).  0 means infinite.
 pref("ui.menu.incremental_search.timeout", 1000);
 // If true, all popups won't hide automatically on blur
 pref("ui.popup.disable_autohide", false);
 
-// 0 = default: always, except in high contrast mode
-// 1 = always
-// 2 = never
-pref("browser.display.document_color_use", 0);
-pref("browser.display.use_system_colors",   false);
-pref("browser.display.foreground_color",    "#000000");
-pref("browser.display.background_color",    "#FFFFFF");
 pref("browser.display.force_inline_alttext", false); // true = force ALT text for missing images to be layed out inline
 // 0 = no external leading,
 // 1 = use external leading only when font provides,
 // 2 = add extra leading both internal leading and external leading are zero
 pref("browser.display.normal_lineheight_calc_control", 2);
 // enable showing image placeholders while image is loading or when image is broken
 pref("browser.display.show_image_placeholders", true);
 // if browser.display.show_image_placeholders is true then this controls whether the loading image placeholder and border is shown or not
 pref("browser.display.show_loading_image_placeholder", false);
 // min font device pixel size at which to turn on high quality
 pref("browser.display.auto_quality_min_font_size", 20);
-pref("browser.anchor_color",                "#0000EE");
-pref("browser.active_color",                "#EE0000");
-pref("browser.visited_color",               "#551A8B");
-pref("browser.underline_anchors",           true);
 pref("browser.enable_automatic_image_resizing", false);
 pref("browser.enable_click_image_resizing", true);
 
 // See http://whatwg.org/specs/web-apps/current-work/#ping
 pref("browser.send_pings", false);
 pref("browser.send_pings.max_per_link", 1);           // limit the number of pings that are sent per link click
 pref("browser.send_pings.require_same_host", false);  // only send pings to the same host if this is true
 
-pref("browser.display.use_focus_colors",    false);
-pref("browser.display.focus_background_color", "#117722");
-pref("browser.display.focus_text_color",     "#ffffff");
-pref("browser.display.focus_ring_width",     1);
-pref("browser.display.focus_ring_on_anything", false);
-// focus ring border style.
-// 0 = solid border, 1 = dotted border
-pref("browser.display.focus_ring_style", 1);
-
 pref("browser.helperApps.neverAsk.saveToDisk", "");
 pref("browser.helperApps.neverAsk.openFile", "");
 pref("browser.helperApps.deleteTempFileOnExit", false);
 
 // xxxbsmedberg: where should prefs for the toolkit go?
 pref("browser.chrome.toolbar_tips",         true);
 // max image size for which it is placed in the tab icon for tabbrowser.
 // if 0, no images are used for tab icons for image documents.