Follow-up fix for bug 778921. We want tests to pass even when we have an even number of them. rs=luke via IRC.
authorJason Orendorff <jorendorff@mozilla.com>
Tue, 31 Jul 2012 13:51:34 -0500
changeset 101015 9fa54a1fc055eb3cef6b8357b23e18612f58afe6
parent 101014 25e961798919f6c1d8ac0c236a76e5cfcbb3bc2e
child 101016 710a0800bbef2048790cdcbc91053377c4ba8ca4
push id12800
push userjorendorff@mozilla.com
push dateTue, 31 Jul 2012 18:51:42 +0000
treeherdermozilla-inbound@9fa54a1fc055 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersluke
bugs778921
milestone17.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Follow-up fix for bug 778921. We want tests to pass even when we have an even number of them. rs=luke via IRC.
js/src/tests/lib/tests.py
--- a/js/src/tests/lib/tests.py
+++ b/js/src/tests/lib/tests.py
@@ -77,18 +77,18 @@ class Test(object):
             return [ '-f', 'shell.js' ]
         head, base = os.path.split(path)
         return Test.prefix_command(head) + [ '-f', os.path.join(path, 'shell.js') ]
 
     def get_command(self, js_cmd_prefix):
         dirname, filename = os.path.split(self.path)
         cmd = js_cmd_prefix
         if self.allowXml:
-            cmd += [ '-e', 'options("allow_xml")' ]
-        cmd += Test.prefix_command(dirname)
+            cmd = cmd + [ '-e', 'options("allow_xml")' ]
+        cmd = cmd + Test.prefix_command(dirname)
         if self.debugMode:
             cmd += [ '-d' ]
         # There is a test that requires the path to start with './'.
         cmd += [ '-f', './' + self.path ]
         return cmd
 
     def run(self, js_cmd_prefix, timeout=30.0):
         cmd = self.get_command(js_cmd_prefix)