Bug 978833 patch 13 - Remove important rule creation from css::StyleRule. r=heycam
authorL. David Baron <dbaron@dbaron.org>
Thu, 05 Nov 2015 16:44:10 +0800
changeset 271219 9f2470877279bdaeed2128a527b81183a3d71bbd
parent 271218 f340cdf67edb870645ddf499da690e60eff7f73f
child 271220 5a8bb99e8c87d317306213d6ac600e32266edc58
push id67603
push userdbaron@mozilla.com
push dateThu, 05 Nov 2015 08:44:59 +0000
treeherdermozilla-inbound@cf480f83f25d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersheycam
bugs978833
milestone45.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 978833 patch 13 - Remove important rule creation from css::StyleRule. r=heycam This is the removal half corresponding to the additions in patch 7; the removal needs to happen after patch 12.
layout/style/StyleRule.h
layout/style/nsCSSRules.h
--- a/layout/style/StyleRule.h
+++ b/layout/style/StyleRule.h
@@ -321,20 +321,16 @@ public:
    * the declaration is modified.
    *
    * |DeclarationChanged| handles replacing the object in the container
    * sheet or group rule if |aHandleContainer| is true.
    */
   already_AddRefed<StyleRule>
   DeclarationChanged(Declaration* aDecl, bool aHandleContainer);
 
-  nsIStyleRule* GetImportantRule() const {
-    return mDeclaration->GetImportantStyleData();
-  }
-
   /**
    * The rule processor must call this method before calling
    * nsRuleWalker::Forward on this rule during rule matching.
    */
   void RuleMatched();
 
   // hooks for DOM rule
   void GetCssText(nsAString& aCssText);
--- a/layout/style/nsCSSRules.h
+++ b/layout/style/nsCSSRules.h
@@ -551,20 +551,16 @@ public:
 
   // nsIDOMCSSPageRule interface
   NS_DECL_NSIDOMCSSPAGERULE
 
   mozilla::css::Declaration* Declaration()   { return mDeclaration; }
 
   void ChangeDeclaration(mozilla::css::Declaration* aDeclaration);
 
-  mozilla::css::ImportantStyleData* GetImportantRule() {
-    return mDeclaration->GetImportantStyleData();
-  }
-
   virtual size_t SizeOfIncludingThis(mozilla::MallocSizeOf aMallocSizeOf) const override;
 private:
   RefPtr<mozilla::css::Declaration>     mDeclaration;
   // lazily created when needed:
   RefPtr<nsCSSPageStyleDeclaration>     mDOMDeclaration;
 };
 
 namespace mozilla {