Bug 1596659 - Delete declineDisabled from engines.js. r=lina
authorMark Hammond <mhammond@skippinet.com.au>
Fri, 15 Nov 2019 20:04:53 +0000
changeset 502278 9f0cb3df34c4d9a4d9d10c9729c864401eca9c78
parent 502277 6a6de47cc1f6fc63af0ec1172712213507a40021
child 502279 8d60ae80f33b8f88e947b17b34d89b384bb472c8
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslina
bugs1596659
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1596659 - Delete declineDisabled from engines.js. r=lina Differential Revision: https://phabricator.services.mozilla.com/D53141
services/sync/modules/engines.js
--- a/services/sync/modules/engines.js
+++ b/services/sync/modules/engines.js
@@ -621,31 +621,16 @@ EngineManager.prototype = {
   undecline(engines) {
     for (let e of engines) {
       this._declined.delete(e);
     }
     this.persistDeclined();
   },
 
   /**
-   * Mark any non-enabled engines as declined.
-   *
-   * This is useful after initial customization during setup.
-   */
-  declineDisabled() {
-    for (let e of this.getAll()) {
-      if (!e.enabled) {
-        this._log.debug("Declining disabled engine " + e.name);
-        this._declined.add(e.name);
-      }
-    }
-    this.persistDeclined();
-  },
-
-  /**
    * Register an Engine to the service. Alternatively, give an array of engine
    * objects to register.
    *
    * @param engineObject
    *        Engine object used to get an instance of the engine
    * @return The engine object if anything failed
    */
   async register(engineObject) {