Bug 1551834 - Move legacy autocomplete attributes from shared browser.xul markup to the legacy-urlbar binding. r=mak
authorDão Gottwald <dao@mozilla.com>
Wed, 15 May 2019 15:59:56 +0000
changeset 473972 9e68d485f7ccea5d8f065fb5f833858e71b4b04a
parent 473971 74252063fc9ec6f72bd27968444ac5de397c6bc1
child 473973 0e8d68920793aca5c383e4977aa3899a2bc5876b
child 473974 03b1762fb0734dc1f58ce5453a8aef8770745538
push id113119
push userdvarga@mozilla.com
push dateWed, 15 May 2019 21:35:00 +0000
treeherdermozilla-inbound@0e8d68920793 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmak
bugs1551834
milestone68.0a1
first release with
nightly linux32
9e68d485f7cc / 68.0a1 / 20190515213039 / files
nightly linux64
9e68d485f7cc / 68.0a1 / 20190515213039 / files
nightly mac
9e68d485f7cc / 68.0a1 / 20190515213039 / files
nightly win32
9e68d485f7cc / 68.0a1 / 20190515213039 / files
nightly win64
9e68d485f7cc / 68.0a1 / 20190515213039 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1551834 - Move legacy autocomplete attributes from shared browser.xul markup to the legacy-urlbar binding. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31227
browser/base/content/browser.xul
browser/base/content/urlbarBindings.xml
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -841,24 +841,16 @@
         <toolbaritem id="urlbar-container" flex="400" persist="width"
                      removable="false"
                      class="chromeclass-location" overflows="false">
             <toolbartabstop/>
             <textbox id="urlbar" flex="1"
                      placeholder="&urlbar.placeholder2;"
                      defaultPlaceholder="&urlbar.placeholder2;"
                      focused="true"
-                     type="autocomplete"
-                     autocompletesearch="unifiedcomplete"
-                     autocompletesearchparam="enable-actions"
-                     autocompletepopup="PopupAutoCompleteRichResult"
-                     completeselectedindex="true"
-                     tabscrolling="true"
-                     ontextentered="this.handleCommand(param);"
-                     ontextreverted="return this.handleRevert();"
                      pageproxystate="invalid">
               <!-- Use onclick instead of normal popup= syntax since the popup
                    code fires onmousedown, and hence eats our favicon drag events. -->
               <box id="identity-box" role="button"
                    align="center"
                    aria-label="&urlbar.viewSiteInfo.label;"
                    onclick="gIdentityHandler.handleIdentityButtonEvent(event);"
                    onkeypress="gIdentityHandler.handleIdentityButtonEvent(event);"
--- a/browser/base/content/urlbarBindings.xml
+++ b/browser/base/content/urlbarBindings.xml
@@ -52,17 +52,25 @@ file, You can obtain one at http://mozil
                       tooltiptext="&urlbar.openHistoryPopup.tooltip;"
                       allowevents="true"
                       xbl:inherits="open,parentfocused=focused,usertyping"/>
       <children includes="hbox"/>
     </content>
   </binding>
 
   <binding id="legacy-urlbar" extends="chrome://global/content/bindings/autocomplete.xml#autocomplete">
-    <content newlines="stripsurroundingwhitespace">
+    <content newlines="stripsurroundingwhitespace"
+             type="autocomplete"
+             autocompletesearch="unifiedcomplete"
+             autocompletesearchparam="enable-actions"
+             autocompletepopup="PopupAutoCompleteRichResult"
+             completeselectedindex="true"
+             tabscrolling="true"
+             ontextentered="this.handleCommand(param);"
+             ontextreverted="return this.handleRevert();">
       <children includes="box"/>
       <xul:moz-input-box anonid="moz-input-box"
                          tooltip="aHTMLTooltip"
                          class="urlbar-input-box"
                          flex="1">
         <children/>
         <html:input anonid="scheme"
                     class="urlbar-scheme textbox-input"