Bug 1439181: Stop mangling stack traces in AOM errors. r=aswan
authorKris Maglione <maglione.k@gmail.com>
Sat, 17 Feb 2018 19:27:01 -0800
changeset 406518 99fd2c41687b7a9f7912a2b74b1eaaf4fa7a96f9
parent 406517 2a70fdfcfde97397e2c47844d85a8a9d7437385c
child 406519 ed9129a6115596564bffe8b855ef014d42eec646
child 406535 51200c0fdaddb2749549a82596da5323a4cbd499
push id100448
push usermaglione.k@gmail.com
push dateMon, 05 Mar 2018 04:45:34 +0000
treeherdermozilla-inbound@99fd2c41687b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaswan
bugs1439181
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1439181: Stop mangling stack traces in AOM errors. r=aswan MozReview-Commit-ID: 6Nh4hwwvrWb
toolkit/modules/Log.jsm
--- a/toolkit/modules/Log.jsm
+++ b/toolkit/modules/Log.jsm
@@ -182,26 +182,26 @@ var Log = {
           str = frame.name + "()@" + str;
         }
 
         if (str) {
           output.push(str);
         }
         frame = frame.caller;
       }
-      return "Stack trace: " + output.join(" < ");
+      return "Stack trace: " + output.join("\n");
     }
     // Standard JS exception
     if (e.stack) {
       let stack = e.stack;
       // Avoid loading Task.jsm if there's no task on the stack.
       if (stack.includes("/Task.jsm:"))
         stack = Task.Debugging.generateReadableStack(stack);
       return "JS Stack trace: " + stack.trim()
-        .replace(/\n/g, " < ").replace(/@[^@]*?([^\/\.]+\.\w+:)/g, "@$1");
+        .replace(/@[^@]*?([^\/\.]+\.\w+:)/g, "@$1");
     }
 
     return "No traceback available";
   }
 };
 
 /*
  * LogMessage