Bug 632954 - Add -Wno-error=backend-plugin to support Android PGO; r=glandium
authorMike Shal <mshal@mozilla.com>
Mon, 18 Mar 2019 23:52:22 +0000
changeset 465186 9954a61f0b3a10f972a1c5fa86860948cce31b1d
parent 465185 d7e6fff52db3179219d39da39b248c8f2571c048
child 465187 5fce433c867072e00ea91410d18e619e5fc68b69
push id112496
push usershindli@mozilla.com
push dateThu, 21 Mar 2019 04:37:39 +0000
treeherdermozilla-inbound@29476d3ca61d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs632954
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 632954 - Add -Wno-error=backend-plugin to support Android PGO; r=glandium Without this flag, Android PGO profile-use builds may fail with "Function control flow change detected" errors. Differential Revision: https://phabricator.services.mozilla.com/D22816
build/moz.configure/warnings.configure
--- a/build/moz.configure/warnings.configure
+++ b/build/moz.configure/warnings.configure
@@ -118,17 +118,23 @@ check_and_add_gcc_warning('-Wno-error=ma
 # we don't want our builds held hostage when a platform-specific API
 # becomes deprecated.
 check_and_add_gcc_warning('-Wno-error=deprecated-declarations')
 
 # false positives depending on optimization
 check_and_add_gcc_warning('-Wno-error=array-bounds')
 
 # can't get rid of those PGO warnings
-check_and_add_gcc_warning('-Wno-error=coverage-mismatch', when='MOZ_PGO')
+check_and_add_gcc_warning('-Wno-error=coverage-mismatch')
+
+# -Wbackend-plugin warnings from Android PGO profile-use builds:
+# error: /builds/worker/workspace/build/src/mozglue/misc/AutoProfilerLabel.cpp:
+#  Function control flow change detected (hash mismatch)
+#  _ZN7mozilla17AutoProfilerLabelD2Ev [-Werror,-Wbackend-plugin]
+check_and_add_gcc_warning('-Wno-error=backend-plugin')
 
 # false positives depending on optimizations
 check_and_add_gcc_warning('-Wno-error=free-nonheap-object')
 
 # Would be a pain to fix all occurrences, for very little gain
 check_and_add_gcc_warning('-Wno-error=multistatement-macros')
 
 # Disable the -Werror for return-std-move because of a false positive