Bug 1526610 [wpt PR 15273] - Revert "Link element events should be able to fire more than once", a=testonly
☠☠ backed out by 749b314d6c28 ☠ ☠
authorDominic Farolino <domfarolino@gmail.com>
Mon, 18 Feb 2019 19:25:52 +0000
changeset 460283 963cd1e41204f836910a951360f6080b39cd003f
parent 460282 25ce8e1fb42576b24d4994dd62773c67bbe81830
child 460284 e2346048d1dc0e5f8cf4ae89db15c89a3ca00659
push id112074
push userwptsync@mozilla.com
push dateThu, 21 Feb 2019 19:59:15 +0000
treeherdermozilla-inbound@a15983fcecca [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1526610, 15273, 927427, 928796, 929153, 929265, 922618, 1423601, 628010, 1457745, 629956
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1526610 [wpt PR 15273] - Revert "Link element events should be able to fire more than once", a=testonly Automatic update from web-platform-tests Revert "Link element events should be able to fire more than once" This reverts commit 66236c640db16d71a5cd3f3e59638fb323d5f542. Reason for revert: Bad and unexpected performance regressions were introduced with this change. It is possible to incur an infinite loop of loading a <link> and firing the load event, if the onload function tampers with the `rel` attribute, as is sometimes done with preload links. This may prevent a window's load event from ever being fired. Mitigating problems like this needs to more looking into before this change can land apparently. Performance regression bugs: https://crbug.com/927427, https://crbug.com/928796, https://crbug.com/929153, https://crbug.com/929265. The original bug (https://crbug.com/922618) has been re-opened to track future work for this. Original change's description: > Link element events should be able to fire more than once > > As per spec https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet, > the <link> element can have its load and error events fire multiple times, > per resource it loads. > > Bug: 922618 > Change-Id: Ifc9ade076e119d5cf9f4eaf656c6ea7c1deb0ba9 > Reviewed-on: https://chromium-review.googlesource.com/c/1423601 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Dominic Farolino <domfarolino@gmail.com> > Cr-Commit-Position: refs/heads/master@{#628010} TBR=yhirano@chromium.org,kouhei@chromium.org,domfarolino@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 922618 Change-Id: I0affe5a242bf472743d11a4905a630da7895cfca Reviewed-on: https://chromium-review.googlesource.com/c/1457745 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Dominic Farolino <domfarolino@gmail.com> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#629956} -- wpt-commits: 56f29c8b1fb483069ceb4d4376ed369bb9543c1d wpt-pr: 15273
testing/web-platform/tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events.html
testing/web-platform/tests/html/semantics/document-metadata/the-link-element/link-multiple-load-events.html
deleted file mode 100644
--- a/testing/web-platform/tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events.html
+++ /dev/null
@@ -1,21 +0,0 @@
-<!DOCTYPE html>
-<link rel="author" title="Dom Farolino" href="mailto:dom@chromium.org">
-<link rel="help" href="https://html.spec.whatwg.org/multipage/#the-link-element">
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<link id=link rel=stylesheet id=style_test
-      onload="t.unreached_func('Sheet should fail to load')">
-<script>
-  var t = async_test("Check if the <link>'s error event fires for each style " +
-                     "sheet it fails to load");
-
-  link.onerror = t.step_func(() => {
-    link.onerror = t.step_func_done(() => {});
-    link.href = 'nonexistent.css?second';
-  });
-
-  link.href = 'nonexistent.css?first';
-</script>
-
-</head>
-</html>
deleted file mode 100644
--- a/testing/web-platform/tests/html/semantics/document-metadata/the-link-element/link-multiple-load-events.html
+++ /dev/null
@@ -1,21 +0,0 @@
-<!DOCTYPE html>
-<link rel="author" title="Dom Farolino" href="mailto:dom@chromium.org">
-<link rel="help" href="https://html.spec.whatwg.org/multipage/#the-link-element">
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<link id=link rel=stylesheet id=style_test
-      onerror="t.unreached_func('Sheet should load successfully')">
-<script>
-  var t = async_test("Check if the <link>'s load event fires for each style " +
-                     "sheet it loads");
-
-  link.onload = t.step_func(() => {
-    link.onload = t.step_func_done(() => {});
-    link.href = 'style.css?second';
-  });
-
-  link.href = 'style.css?first';
-</script>
-
-</head>
-</html>