Bug 1308110 - make tab-size animatable. r=cam
authorThomas Wisniewski <wisniewskit@gmail.com>
Tue, 13 Dec 2016 15:31:23 -0500
changeset 325794 95e969c0031714d2f6538afbc0cc5e55c203cd35
parent 325793 843b98464b4026115e37b945d56bc9b70b213de3
child 325795 3561e1497acf6a3288d5a31cc832868d24d3b02d
push id84801
push usercbook@mozilla.com
push dateWed, 14 Dec 2016 08:19:04 +0000
treeherdermozilla-inbound@1fd906e69d35 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscam
bugs1308110
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1308110 - make tab-size animatable. r=cam
dom/animation/test/mozilla/file_discrete-animations.html
layout/style/nsCSSPropList.h
layout/style/test/test_transitions_per_property.html
--- a/dom/animation/test/mozilla/file_discrete-animations.html
+++ b/dom/animation/test/mozilla/file_discrete-animations.html
@@ -70,21 +70,16 @@ const gMozillaSpecificProperties = {
     from: "-moz-crisp-edges",
     to: "auto"
   },
   "-moz-stack-sizing": {
     // https://developer.mozilla.org/en/docs/Web/CSS/-moz-stack-sizing
     from: "ignore",
     to: "stretch-to-fit"
   },
-  "-moz-tab-size": {
-    // https://drafts.csswg.org/css-text-3/#propdef-tab-size
-    from: "1",
-    to: "5"
-  },
   "-moz-text-size-adjust": {
     // https://drafts.csswg.org/css-size-adjust/#propdef-text-size-adjust
     from: "none",
     to: "auto"
   },
   "-webkit-text-stroke-width": {
     // https://compat.spec.whatwg.org/#propdef--webkit-text-stroke-width
     from: "10px",
--- a/layout/style/nsCSSPropList.h
+++ b/layout/style/nsCSSPropList.h
@@ -3873,17 +3873,17 @@ CSS_PROP_TEXT(
     _moz_tab_size,
     CSS_PROP_DOMPROP_PREFIXED(TabSize),
     CSS_PROPERTY_PARSE_VALUE |
         CSS_PROPERTY_VALUE_NONNEGATIVE,
     "",
     VARIANT_INHERIT | VARIANT_LNCALC,
     nullptr,
     offsetof(nsStyleText, mTabSize),
-    eStyleAnimType_Discrete)
+    eStyleAnimType_Coord)
 CSS_PROP_TABLE(
     table-layout,
     table_layout,
     TableLayout,
     CSS_PROPERTY_PARSE_VALUE,
     "",
     VARIANT_HK,
     kTableLayoutKTable,
--- a/layout/style/test/test_transitions_per_property.html
+++ b/layout/style/test/test_transitions_per_property.html
@@ -243,16 +243,18 @@ var supported_properties = {
     "stroke-opacity" : [ test_float_zeroToOne_transition,
                          // opacity is clamped in computed style
                          // (not parsing/interpolation)
                          test_float_zeroToOne_clamped ],
     // NOTE: when calc() is supported on 'stroke-width', we should add
     // test_length_percent_calc_transition.
     "stroke-width": [ test_length_transition_svg, test_percent_transition,
                       test_length_clamped_svg, test_percent_clamped ],
+    "-moz-tab-size": [ test_float_zeroToOne_transition,
+                       test_float_aboveOne_transition, test_length_clamped ],
     "text-decoration": [ test_color_shorthand_transition,
                          test_true_currentcolor_shorthand_transition ],
     "text-decoration-color": [ test_color_transition,
                                test_true_currentcolor_transition ],
     "text-emphasis-color": [ test_color_transition,
                              test_true_currentcolor_transition ],
     "text-indent": [ test_length_transition, test_percent_transition,
                      test_length_unclamped, test_percent_unclamped ],