Backed out changeset ecb1ebb96315 (bug 1499426) for causing failures at media/webrtc/MediaEngineWebRTCAudio.cpp a=backout
authorGurzau Raul <rgurzau@mozilla.com>
Tue, 06 Nov 2018 11:59:15 +0200
changeset 444597 957a743c4ca2907d8e357fce43fbcd9f619f1122
parent 444596 c6a6e76dc5424395e45c3d47aa696eb2f7d09e5e
child 444598 bd0ce1c2d8f6afadecc36a17ba6f8512e2717f4e
child 444634 981aa569f6de7c3b367acd92a8b2cfd64adda6fa
push id109603
push userrgurzau@mozilla.com
push dateTue, 06 Nov 2018 10:04:45 +0000
treeherdermozilla-inbound@bd0ce1c2d8f6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1499426
milestone65.0a1
backs outecb1ebb963155e84185700424c4af0f4f03562ff
first release with
nightly linux32
957a743c4ca2 / 65.0a1 / 20181106100114 / files
nightly linux64
957a743c4ca2 / 65.0a1 / 20181106100114 / files
nightly mac
957a743c4ca2 / 65.0a1 / 20181106100114 / files
nightly win32
957a743c4ca2 / 65.0a1 / 20181106100114 / files
nightly win64
957a743c4ca2 / 65.0a1 / 20181106100114 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset ecb1ebb96315 (bug 1499426) for causing failures at media/webrtc/MediaEngineWebRTCAudio.cpp a=backout
dom/media/webrtc/MediaEngineWebRTCAudio.cpp
--- a/dom/media/webrtc/MediaEngineWebRTCAudio.cpp
+++ b/dom/media/webrtc/MediaEngineWebRTCAudio.cpp
@@ -649,20 +649,18 @@ MediaEngineWebRTCMicrophoneSource::Start
       mStream->GraphImpl()->InputDeviceID() != deviceID) {
     // For now, we only allow opening a single audio input device per document,
     // because we can only have one MSG per document.
     return NS_ERROR_FAILURE;
   }
 
 
 
-  if (!mInputProcessing) {
-    mInputProcessing = new AudioInputProcessing(
-      mDeviceMaxChannelCount, mStream, mTrackID, mPrincipal);
-  }
+  mInputProcessing = new AudioInputProcessing(
+    mDeviceMaxChannelCount, mStream, mTrackID, mPrincipal);
 
   RefPtr<MediaEngineWebRTCMicrophoneSource> that = this;
   RefPtr<MediaStreamGraphImpl> gripGraph = mStream->GraphImpl();
   NS_DispatchToMainThread(media::NewRunnableFrom(
     [that, graph = std::move(gripGraph), deviceID]() mutable {
       if (graph) {
         graph->AppendMessage(MakeUnique<StartStopMessage>(
           that->mInputProcessing, StartStopMessage::Start));