Bug 1596193 - Replace outdated references to XUL textbox. r=dao
authorTim Nguyen <ntim.bugs@gmail.com>
Fri, 15 Nov 2019 13:35:14 +0000
changeset 502167 956e4283483b7be971b2446c6bcaa005dd067d14
parent 502166 cde2ca39e32b7e344ebd4f6eac900c7ac1dee26a
child 502168 152910bc090bbef282563755230bec4f2497324a
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1596193
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1596193 - Replace outdated references to XUL textbox. r=dao Differential Revision: https://phabricator.services.mozilla.com/D53177
accessible/html/HTMLFormControlAccessible.h
browser/base/content/contentSearchUI.js
browser/components/places/content/bookmarkProperties.js
browser/components/places/content/places.js
browser/components/preferences/connection.js
security/manager/pki/resources/content/certViewer.xul
toolkit/content/xul.css
--- a/accessible/html/HTMLFormControlAccessible.h
+++ b/accessible/html/HTMLFormControlAccessible.h
@@ -93,18 +93,18 @@ class HTMLTextFieldAccessible final : pu
 
  protected:
   virtual ~HTMLTextFieldAccessible() {}
 
   // Accessible
   virtual ENameValueFlag NativeName(nsString& aName) const override;
 
   /**
-   * Return a widget element this input is part of, for example, XUL:textbox or
-   * HTML:input@type="number".
+   * Return a widget element this input is part of, for example, search-textbox
+   * or HTML:input@type="number".
    */
   nsIContent* BindingOrWidgetParent() const {
     nsIContent* el = mContent->GetBindingParent();
     if (el) {
       return el;
     }
     // XUL search-textbox custom element
     ErrorResult rv;
--- a/browser/base/content/contentSearchUI.js
+++ b/browser/base/content/contentSearchUI.js
@@ -16,17 +16,17 @@ this.ContentSearchUIController = (functi
    * Creates a new object that manages search suggestions and their UI for a text
    * box.
    *
    * The UI consists of an html:table that's inserted into the DOM after the given
    * text box and styled so that it appears as a dropdown below the text box.
    *
    * @param inputElement
    *        Search suggestions will be based on the text in this text box.
-   *        Assumed to be an html:input.  xul:textbox is untested but might work.
+   *        Assumed to be an html:input.
    * @param tableParent
    *        The suggestion table is appended as a child to this element.  Since
    *        the table is absolutely positioned and its top and left values are set
    *        to be relative to the top and left of the page, either the parent and
    *        all its ancestors should not be positioned elements (i.e., their
    *        positions should be "static"), or the parent's position should be the
    *        top left of the page.
    * @param healthReportKey
--- a/browser/components/places/content/bookmarkProperties.js
+++ b/browser/components/places/content/bookmarkProperties.js
@@ -435,17 +435,17 @@ var BookmarkPropertiesPanel = {
     ) {
       return false;
     }
 
     return true;
   },
 
   /**
-   * Determines whether the XUL textbox with the given ID contains a
+   * Determines whether the input with the given ID contains a
    * string that can be converted into an nsIURI.
    *
    * @param aTextboxID
    *        the ID of the textbox element whose contents we'll test
    *
    * @returns true if the textbox contains a valid URI string, false otherwise
    */
   _containsValidURI: function BPP__containsValidURI(aTextboxID) {
--- a/browser/components/places/content/places.js
+++ b/browser/components/places/content/places.js
@@ -719,17 +719,17 @@ var PlacesOrganizer = {
     var infoBox = document.getElementById("infoBox");
     var detailsDeck = document.getElementById("detailsDeck");
 
     // Make sure the infoBox UI is visible if we need to use it, we hide it
     // below when we don't.
     infoBox.hidden = false;
     let selectedNode = aNodeList.length == 1 ? aNodeList[0] : null;
 
-    // If a textbox within a panel is focused, force-blur it so its contents
+    // If an input within a panel is focused, force-blur it so its contents
     // are saved
     if (gEditItemOverlay.itemId != -1) {
       var focusedElement = document.commandDispatcher.focusedElement;
       if (
         (focusedElement instanceof HTMLInputElement ||
           focusedElement instanceof HTMLTextAreaElement) &&
         /^editBMPanel.*/.test(focusedElement.parentNode.parentNode.id)
       ) {
--- a/browser/components/preferences/connection.js
+++ b/browser/components/preferences/connection.js
@@ -227,17 +227,17 @@ var gConnectionsDialog = {
     var isDefinitelySocks4 =
       !socksVersionPref.disabled && socksVersionPref.value == 4;
     socksDNSPref.disabled = isDefinitelySocks4 || proxyTypePref.value == 0;
     return undefined;
   },
 
   updateReloadButton() {
     // Disable the "Reload PAC" button if the selected proxy type is not PAC or
-    // if the current value of the PAC textbox does not match the value stored
+    // if the current value of the PAC input does not match the value stored
     // in prefs.  Likewise, disable the reload button if PAC is not configured
     // in prefs.
 
     var typedURL = document.getElementById("networkProxyAutoconfigURL").value;
     var proxyTypeCur = Preferences.get("network.proxy.type").value;
 
     var pacURL = Services.prefs.getCharPref("network.proxy.autoconfig_url");
     var proxyType = Services.prefs.getIntPref("network.proxy.type");
--- a/security/manager/pki/resources/content/certViewer.xul
+++ b/security/manager/pki/resources/content/certViewer.xul
@@ -24,17 +24,17 @@
 <script src="chrome://pippki/content/pippki.js"/>
 <script src="chrome://global/content/globalOverlay.js"/>
 <script src="chrome://global/content/editMenuOverlay.js"/>
 <script src="chrome://pippki/content/certViewer.js"/>
 <html:style>
   table {
     border-spacing: 0.5ch 2px;
   }
-  td > textbox {
+  td > input {
     width: 100%;
   }
   th {
     vertical-align: middle;
     text-align: start;
   }
   th[scope="row"] {
     font-weight: normal;
--- a/toolkit/content/xul.css
+++ b/toolkit/content/xul.css
@@ -170,17 +170,18 @@ toolbar:not([nowindowdrag="true"]):not([
 }
 %endif
 
 /* The list below is non-comprehensive and will probably need some tweaking. */
 toolbaritem,
 toolbarbutton,
 toolbarseparator,
 button,
-textbox,
+search-textbox,
+html|input,
 tab,
 radio,
 splitter,
 menulist {
   -moz-window-dragging: no-drag;
 }
 
 /******* toolbar *******/