Bug 1553029 - Update WebIDE deprecation message to stop mentioning release 69 r=flod,daisuke
authorJulian Descottes <jdescottes@mozilla.com>
Tue, 21 May 2019 08:48:51 +0000
changeset 474699 92a16e67af5e23e7dd5f6812bb264c48be6c8ad5
parent 474698 476139ca9d4a5802cfd786fccb1fd87d088e78fa
child 474700 38a89c91277887c28240c6a95ca93813d08ebf89
push id113168
push userrmaries@mozilla.com
push dateTue, 21 May 2019 16:39:23 +0000
treeherdermozilla-inbound@3c0f78074b72 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersflod, daisuke
bugs1553029
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1553029 - Update WebIDE deprecation message to stop mentioning release 69 r=flod,daisuke There was a last minute schedule change for remote debugging release and we will not ride the trains with Firefox 68 The deprecation schedule is therefore shifting by one release. We update the deprecation message in WebIDE here and we should uplift this change to beta if possible. The patch was written in order to be uplifted, we can go for a simpler version if the uplift is a no go. Differential Revision: https://phabricator.services.mozilla.com/D31970
devtools/client/locales/en-US/webide.properties
devtools/client/webide/content/webide.js
--- a/devtools/client/locales/en-US/webide.properties
+++ b/devtools/client/locales/en-US/webide.properties
@@ -55,18 +55,18 @@ error_runtimeVersionTooOld=The connected
 # for a backward compatibility issue that occurs when connecting:
 # - from Fx 67 to 66 or to 65
 # - from Fx 68 to 66
 # Those are normally in range for DevTools compatibility policy, but specific non
 # backward compatible changes broke the debugger in those scenarios (Bug 1528219).
 # Variable: runtime app version (looks like this 52.a3)
 error_runtimeVersionTooOld67Debugger=The Debugger panel may not work with the connected runtime. Please use Firefox %S if you need to use the Debugger with this runtime.
 
-# LOCALIZATION NOTE (error_webIDEDeprecated): Text for the deprecation message displayed when starting WebIDE.
-error_webIDEDeprecated=WebIDE will be disabled in release 69. Remote debugging is now available in about:debugging.
+# LOCALIZATION NOTE (error_webIDEDeprecated2): Text for the deprecation message displayed when starting WebIDE.
+error_webIDEDeprecated2=WebIDE will be disabled in an upcoming release. Remote debugging is now available in about:debugging.
 
 # LOCALIZATION NOTE (notification_openAboutDebugging): Text for a button displayed in the deprecation message for WebIDE.
 # Clicking on the button will open a tab on about:debugging.
 notification_openAboutDebugging.label=Open about:debugging
 notification_openAboutDebugging.accesskey=O
 
 addons_stable=stable
 addons_unstable=unstable
--- a/devtools/client/webide/content/webide.js
+++ b/devtools/client/webide/content/webide.js
@@ -313,17 +313,25 @@ var UI = {
 
     const nbox = this.notificationBox;
     nbox.removeAllNotifications(true);
     nbox.appendNotification(text, "webide:errornotification", null,
       nbox.PRIORITY_WARNING_LOW, buttons);
   },
 
   showDeprecationMessage: function() {
-    const text = Strings.GetStringFromName("error_webIDEDeprecated");
+    let text;
+    try {
+      text = Strings.GetStringFromName("error_webIDEDeprecated2");
+    } catch (e) {
+      // The string error_webIDEDeprecated2 should be upflited to Beta 68. In this
+      // situation, some language packs might not be updated and provide the new string
+      // immediately. Fallback to the previous string in this case.
+      text = Strings.GetStringFromName("error_webIDEDeprecated");
+    }
     const buttons = [{
       label: Strings.GetStringFromName("notification_openAboutDebugging.label"),
       accessKey: Strings.GetStringFromName("notification_openAboutDebugging.accesskey"),
       callback: function() {
         const { openTrustedLink } = require("devtools/client/shared/link");
         openTrustedLink("about:debugging");
       },
     }];