Bug 1545697 - Fixes right breakpoint pane toggle button r=davidwalsh
authorDerek Li <the.derekli@gmail.com>
Mon, 22 Apr 2019 15:55:28 +0000
changeset 470373 927791bc9befd7ec45fed4a8ac5eca36538e9e60
parent 470372 98df47a219e2088d431e3961fe6ea7f99017a1be
child 470374 9dec6983ccaca948dcde3db9cdd6a9ee94d53c3c
push id112868
push useropoprus@mozilla.com
push dateMon, 22 Apr 2019 22:19:22 +0000
treeherdermozilla-inbound@24537856cc88 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdavidwalsh
bugs1545697
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1545697 - Fixes right breakpoint pane toggle button r=davidwalsh Reverts change to the Pane Toggle Button from another patch Differential Revision: https://phabricator.services.mozilla.com/D28171
devtools/client/debugger/src/components/Editor/Footer.js
devtools/client/debugger/src/components/Editor/tests/__snapshots__/Footer.spec.js.snap
--- a/devtools/client/debugger/src/components/Editor/Footer.js
+++ b/devtools/client/debugger/src/components/Editor/Footer.js
@@ -165,16 +165,17 @@ class SourceFooter extends PureComponent
     }
 
     return (
       <PaneToggleButton
         key="toggle"
         collapsed={this.props.endPanelCollapsed}
         horizontal={this.props.horizontal}
         handleClick={(this.props.togglePaneCollapse: any)}
+        position="end"
       />
     );
   }
 
   renderCommands() {
     const commands = [this.blackBoxButton(), this.prettyPrintButton()].filter(
       Boolean
     );
--- a/devtools/client/debugger/src/components/Editor/tests/__snapshots__/Footer.spec.js.snap
+++ b/devtools/client/debugger/src/components/Editor/tests/__snapshots__/Footer.spec.js.snap
@@ -15,17 +15,17 @@ exports[`SourceFooter Component default 
       title="(Line 1, column 1)"
     >
       (1, 1)
     </div>
     <PaneToggleButton
       collapsed={false}
       horizontal={false}
       key="toggle"
-      position="start"
+      position="end"
     />
   </div>
 </div>
 `;
 
 exports[`SourceFooter Component move cursor should render new cursor position 1`] = `
 <div
   className="source-footer"
@@ -41,13 +41,13 @@ exports[`SourceFooter Component move cur
       title="(Line 6, column 11)"
     >
       (6, 11)
     </div>
     <PaneToggleButton
       collapsed={false}
       horizontal={false}
       key="toggle"
-      position="start"
+      position="end"
     />
   </div>
 </div>
 `;