Bug 985597 - Don't highlight hidden nodes; r=miker
authorPatrick Brosset <pbrosset@mozilla.com>
Thu, 06 Nov 2014 13:04:44 +0100
changeset 214459 8ff2fd3817907bd6ec6db563b8b054ef4990bc45
parent 214458 779e64334c1d862ff3516e213f1f854a1e84c2c2
child 214460 8e9b2357abcbc145416572210c7994ba408120f1
push id51494
push userkwierso@gmail.com
push dateFri, 07 Nov 2014 03:08:20 +0000
treeherdermozilla-inbound@c4b831696f15 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmiker
bugs985597
milestone36.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 985597 - Don't highlight hidden nodes; r=miker
toolkit/devtools/server/actors/highlighter.js
--- a/toolkit/devtools/server/actors/highlighter.js
+++ b/toolkit/devtools/server/actors/highlighter.js
@@ -994,21 +994,26 @@ BoxModelHighlighter.prototype = Heritage
       return true;
     }
 
     this._hideBoxModel();
     return false;
   },
 
   _nodeNeedsHighlighting: function() {
+    let hasNoQuads = !this.currentQuads.margin &&
+                     !this.currentQuads.border &&
+                     !this.currentQuads.padding &&
+                     !this.currentQuads.content;
     if (!this.currentNode ||
         Cu.isDeadWrapper(this.currentNode) ||
         this.currentNode.nodeType !== Ci.nsIDOMNode.ELEMENT_NODE ||
         !this.currentNode.ownerDocument ||
-        !this.currentNode.ownerDocument.defaultView) {
+        !this.currentNode.ownerDocument.defaultView ||
+        hasNoQuads) {
       return false;
     }
 
     if (!this._computedStyle) {
       this._computedStyle = CssLogic.getComputedStyle(this.currentNode);
     }
 
     return this._computedStyle.getPropertyValue("display") !== "none";