Bug 1284301: Remove duplicated code, add a comment. r=eflores
authorMilan Sreckovic <milan@mozilla.com>
Tue, 05 Jul 2016 11:50:02 -0400
changeset 303833 8d66e60af350fd0255f798e608db1b6bfe61beda
parent 303832 64af1bfa1340df673b30a5d368df13c81de43dcc
child 303834 ad03068456bbc9c96e3c04416e462ffdd5cc14be
push id79199
push usergszorc@mozilla.com
push dateThu, 07 Jul 2016 01:27:06 +0000
treeherdermozilla-inbound@d666f37dfa89 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerseflores
bugs1284301
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1284301: Remove duplicated code, add a comment. r=eflores MozReview-Commit-ID: CBbrTxa0OZl
widget/GfxInfoBase.cpp
widget/nsIGfxInfo.idl
--- a/widget/GfxInfoBase.cpp
+++ b/widget/GfxInfoBase.cpp
@@ -457,20 +457,16 @@ BlacklistEntryToDriverInfo(nsCString& aB
     } else if (key.EqualsLiteral("driverVersion")) {
       uint64_t version;
       if (ParseDriverVersion(dataValue, &version))
         aDriverInfo.mDriverVersion = version;
     } else if (key.EqualsLiteral("driverVersionMax")) {
       uint64_t version;
       if (ParseDriverVersion(dataValue, &version))
         aDriverInfo.mDriverVersionMax = version;
-    } else if (key.EqualsLiteral("driverVersionMax")) {
-      uint64_t version;
-      if (ParseDriverVersion(dataValue, &version))
-        aDriverInfo.mDriverVersionMax = version;
     } else if (key.EqualsLiteral("driverVersionComparator")) {
       aDriverInfo.mComparisonOp = BlacklistComparatorToComparisonOp(dataValue);
     } else if (key.EqualsLiteral("model")) {
       aDriverInfo.mModel = dataValue;
     } else if (key.EqualsLiteral("product")) {
       aDriverInfo.mProduct = dataValue;
     } else if (key.EqualsLiteral("manufacturer")) {
       aDriverInfo.mManufacturer = dataValue;
--- a/widget/nsIGfxInfo.idl
+++ b/widget/nsIGfxInfo.idl
@@ -102,19 +102,19 @@ interface nsIGfxInfo : nsISupports
   /* Whether Direct3D 11 is supported for ANGLE, starting in 38. */
   const long FEATURE_DIRECT3D_11_ANGLE = 13;
   /* Whether Webrtc Hardware acceleration is supported, starting in 42. */
   const long FEATURE_WEBRTC_HW_ACCELERATION_ENCODE = 14;
   /* Whether Webrtc Hardware acceleration is supported, starting in 42. */
   const long FEATURE_WEBRTC_HW_ACCELERATION_DECODE = 15;
   /* Whether Canvas acceleration is supported, starting in 45 */
   const long FEATURE_CANVAS2D_ACCELERATION = 16;
-  /* Whether hardware VP8 decoding is supported. */
+  /* Whether hardware VP8 decoding is supported, starting in 48. */
   const long FEATURE_VP8_HW_DECODE = 17;
-  /* Whether hardware VP9 decoding is supported. */
+  /* Whether hardware VP9 decoding is supported, starting in 48. */
   const long FEATURE_VP9_HW_DECODE = 18;
 
   /*
    * A set of return values from GetFeatureStatus
    */
 
   /* The driver is safe to the best of our knowledge */
   const long FEATURE_STATUS_OK = 1;