Bug 1466931 - Correctly identify the first invalid wasm opcode. r=jseward
authorLars T Hansen <lhansen@mozilla.com>
Wed, 06 Jun 2018 13:13:44 +0200
changeset 421563 8a4b9dd1d15ee10c1b2509202085cf151a4bf0ae
parent 421562 d9de6329f9adb0fe2af88e40b69e22f1d88b86b7
child 421564 fac57eb7e7aaaa0c5396d39dc67eae2451754b9f
push id104061
push userlhansen@mozilla.com
push dateWed, 06 Jun 2018 11:46:51 +0000
treeherdermozilla-inbound@8a4b9dd1d15e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjseward
bugs1466931
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1466931 - Correctly identify the first invalid wasm opcode. r=jseward Previously, the new wasm sign extension ops were part of the threads proposal and so our test cases would guard on those ops using wasmThreadsSupported(). But now that the extension ops have landed independently of the threads proposal that guard is incorrect. So just remove the guard; we don't need it.
js/src/jit-test/lib/wasm-binary.js
--- a/js/src/jit-test/lib/wasm-binary.js
+++ b/js/src/jit-test/lib/wasm-binary.js
@@ -89,17 +89,17 @@ const I64TruncSF32Code = 0xae;
 const I64TruncUF32Code = 0xaf;
 const I64TruncSF64Code = 0xb0;
 const I64TruncUF64Code = 0xb1;
 const I64DivSCode      = 0x7f;
 const I64DivUCode      = 0x80;
 const I64RemSCode      = 0x81;
 const I64RemUCode      = 0x82;
 
-const FirstInvalidOpcode = wasmThreadsSupported() ? 0xc5 : 0xc0;
+const FirstInvalidOpcode = 0xc5;
 const LastInvalidOpcode = 0xfb;
 const MiscPrefix = 0xfc;
 const SimdPrefix = 0xfd;
 const ThreadPrefix = 0xfe;
 const MozPrefix = 0xff;
 
 // DefinitionKind
 const FunctionCode     = 0x00;