Bug 1541560 [wpt PR 16058] - Fixed some typos and mistakes in the css-text WTP test suite, a=testonly
authorJavier Fernandez <jfernandez@igalia.com>
Thu, 18 Apr 2019 11:54:51 +0000
changeset 470981 880ac981b63b61a0710988c7fceeb3647117d6de
parent 470980 08bd8cbc8ef582cc83ceaccbcf82efe8344601bd
child 470982 ade8bfcb3a2ddc8f679616fe7917261590fd09e0
push id112883
push userjames@hoppipolla.co.uk
push dateWed, 24 Apr 2019 10:45:08 +0000
treeherdermozilla-inbound@a9e8bb1d8a16 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1541560, 16058, 1538189, 643832
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1541560 [wpt PR 16058] - Fixed some typos and mistakes in the css-text WTP test suite, a=testonly Automatic update from web-platform-tests Fixed some typos and mistakes in the css-text WTP test suite Typos and formatting changes mostly, but also some errors related to the line-height property that caused errors in Firefox. Change-Id: Ieac66a25511dbd3386d6a737b63dfbd5e677ec2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538189 Reviewed-by: Manuel Rego <rego@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#643832} -- wpt-commits: 0b2be811fa3587838fdb1399195610a176de3872 wpt-pr: 16058
testing/web-platform/tests/css/css-text/overflow-wrap/overflow-wrap-break-word-006.html
testing/web-platform/tests/css/css-text/white-space/break-spaces-004.html
testing/web-platform/tests/css/css-text/white-space/break-spaces-005.html
testing/web-platform/tests/css/css-text/white-space/break-spaces-006.html
testing/web-platform/tests/css/css-text/white-space/break-spaces-007.html
testing/web-platform/tests/css/css-text/white-space/break-spaces-008.html
testing/web-platform/tests/css/css-text/white-space/pre-wrap-015.html
testing/web-platform/tests/css/css-text/white-space/pre-wrap-016.html
testing/web-platform/tests/css/css-text/word-break/word-break-break-all-010.html
testing/web-platform/tests/css/css-text/word-break/word-break-break-all-012.html
testing/web-platform/tests/css/css-text/word-break/word-break-break-all-013.html
--- a/testing/web-platform/tests/css/css-text/overflow-wrap/overflow-wrap-break-word-006.html
+++ b/testing/web-platform/tests/css/css-text/overflow-wrap/overflow-wrap-break-word-006.html
@@ -4,32 +4,33 @@
 <link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:jfernandez@igalia.com">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-overflow-wrap-break-word">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces">
 <meta name="flags" content="ahem">
 <link rel="match" href="reference/overflow-wrap-break-word-001-ref.html">
 <meta name="assert" content="A Single leading white-space constitutes a soft breaking opportunity, honoring the 'white-space: break-spaces' property, that must prevent the word to be broken.">
 <style>
 div {
-   position: relative;
-   font-size: 20px;
-   font-family: Ahem;
+  position: relative;
+  font-size: 20px;
+  font-family: Ahem;
+  line-height: 1em;
 }
 .red {
   position: absolute;
   background: green;
   color: red;
   width: 100px;
   height: 100px;
   z-index: -1;
 }
 .test {
   color: green;
-  line-height: 1em;
   width: 5ch;
+
   white-space: break-spaces;
   overflow-wrap: break-word;
 }
 </style>
 <body>
   <p>Test passes if there is a <strong>filled green square</strong> and <strong>no red</strong>.</p>
   <div class="red"><br>XXXXX</div>
   <div class="test"> XXXXX </div>
--- a/testing/web-platform/tests/css/css-text/white-space/break-spaces-004.html
+++ b/testing/web-platform/tests/css/css-text/white-space/break-spaces-004.html
@@ -6,18 +6,18 @@
 <link rel="help" title="5.2. Breaking Rules for Letters: the word-break property" href="https://drafts.csswg.org/css-text-3/#word-break-property">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-word-break-break-word">
 <meta name="flags" content="ahem">
 <link rel="match" href="reference/pre-wrap-001-ref.html">
 <meta name="assert" content="The word is not broken if there are previous breaking opportunities, honoring the 'white-space: break-spaces' value.">
 <style>
 div {
-   position: relative;
-   font: 20px/1 Ahem;
+  position: relative;
+  font: 20px/1 Ahem;
 }
 .fail {
   position: absolute;
   color: red;
   z-index: -1;
 }
 span { color: green; }
 .test {
--- a/testing/web-platform/tests/css/css-text/white-space/break-spaces-005.html
+++ b/testing/web-platform/tests/css/css-text/white-space/break-spaces-005.html
@@ -4,18 +4,18 @@
 <link rel="author" title="Javier Fernandez" href="mailto:jfernandez@igalia.com" />
 <link rel="help" title="3. White Space and Wrapping: the white-space property" href="https://drafts.csswg.org/css-text-3/#white-space-property">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces">
 <link rel="match" href="reference/white-space-break-spaces-005-ref.html">
 <meta name="flags" content="ahem">
 <meta name="assert" content="If 'white-space' is set to 'break-spaces', collapsing preserved white-spaces' advance width is not allowed, so that they can be wrapped honoring the 'white-space' propery.">
 <style>
 div {
-   position: relative;
-   font: 10px/1 Ahem;
+  position: relative;
+  font: 10px/1 Ahem;
 }
 .fail {
   position: absolute;
   color: red;
   z-index: -1;
 }
 span { color: green; }
 .test {
--- a/testing/web-platform/tests/css/css-text/white-space/break-spaces-006.html
+++ b/testing/web-platform/tests/css/css-text/white-space/break-spaces-006.html
@@ -6,18 +6,18 @@
 <link rel="help" title="5.2. Breaking Rules for Letters: the word-break property" href="https://drafts.csswg.org/css-text-3/#word-break-property">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-word-break-break-all">
 <link rel="match" href="reference/white-space-break-spaces-005-ref.html">
 <meta name="flags" content="ahem">
 <meta name="assert" content="White spaces are preserved, honoring the 'white-space: break-spaces', but the words are broken, honring the 'word-beak: break-all' even though there are previous breaking opportunities in the white-spaces.">
 <style>
 div {
-   position: relative;
-   font: 25px/1 Ahem;
+  position: relative;
+  font: 25px/1 Ahem;
 }
 .fail {
   position: absolute;
   color: red;
   z-index: -1;
 }
 span { color: green; }
 .test {
--- a/testing/web-platform/tests/css/css-text/white-space/break-spaces-007.html
+++ b/testing/web-platform/tests/css/css-text/white-space/break-spaces-007.html
@@ -6,18 +6,18 @@
 <link rel="help" title="5.2. Breaking Rules for Letters: the word-break property" href="https://drafts.csswg.org/css-text-3/#word-break-property">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-word-break-break-all">
 <link rel="match" href="reference/white-space-break-spaces-005-ref.html">
 <meta name="flags" content="ahem">
 <meta name="assert" content="A single leading white-space should be used, honoring white-space: break-spaces, to avoid overflow; however, a single preserved white-space at the end of the line cannot be wrapped, hence it hangs when breaking after it to move the rest of the text to the next line.">
 <style>
 div {
-   position: relative;
-   font: 25px/1 Ahem;
+  position: relative;
+  font: 25px/1 Ahem;
 }
 .fail {
   position: absolute;
   color: red;
   z-index: -1;
 }
 span { color: green; }
 .test {
--- a/testing/web-platform/tests/css/css-text/white-space/break-spaces-008.html
+++ b/testing/web-platform/tests/css/css-text/white-space/break-spaces-008.html
@@ -6,18 +6,18 @@
 <link rel="help" title="5.2. Breaking Rules for Letters: the word-break property" href="https://drafts.csswg.org/css-text-3/#word-break-property">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-word-break-break-all">
 <link rel="match" href="reference/white-space-break-spaces-005-ref.html">
 <meta name="flags" content="ahem">
 <meta name="assert" content="White spaces are preserved, honoring the 'white-space: break-spaces', which may lead to overfow. However, we can break before the first white-space after the word honoring the 'break-all' value.">
 <style>
 div {
-   position: relative;
-   font: 25px/1 Ahem;
+  position: relative;
+  font: 25px/1 Ahem;
 }
 .fail {
   position: absolute;
   color: red;
   z-index: -1;
 }
 span { color: green; }
 .test {
--- a/testing/web-platform/tests/css/css-text/white-space/pre-wrap-015.html
+++ b/testing/web-platform/tests/css/css-text/white-space/pre-wrap-015.html
@@ -4,18 +4,18 @@
 <link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:jfernandez@igalia.com">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-white-space-pre-wrap">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-word-break-break-all">
 <meta name="flags" content="ahem">
 <link rel="match" href="reference/pre-wrap-001-ref.html">
 <meta name="assert" content="The text is broken at the end of the space between the two words, never before, so it hangs and cause an overflow">
 <style>
 div {
-   position: relative;
-   font: 20px/1 Ahem;
+  position: relative;
+  font: 20px/1 Ahem;
 }
 .ref {
   position: absolute;
   color: red;
   z-index: -1;
 }
 .test {
   color: green;
--- a/testing/web-platform/tests/css/css-text/white-space/pre-wrap-016.html
+++ b/testing/web-platform/tests/css/css-text/white-space/pre-wrap-016.html
@@ -7,29 +7,29 @@
 <meta name="flags" content="ahem">
 <link rel="match" href="reference/pre-wrap-001-ref.html">
 <meta name="assert" content="The word is not broken if there are previous breaking opportunities, honoring the white-space: pre-wrap value.">
 <style>
 div {
    position: relative;
    font-size: 20px;
    font-family: Ahem;
+   line-height: 1em;
 }
 .red {
   position: absolute;
   white-space: pre;
   background: green;
   color: red;
   width: 40px;
   height: 40px;
   z-index: -1;
 }
 .test {
   color: green;
-  line-height: 1em;
   width: 2ch;
 
   white-space: pre-wrap;
   word-break: break-word;
 }
 </style>
 <body>
   <p>Test passes if there is a <strong>filled green square</strong> and <strong>no red</strong>.</p>
--- a/testing/web-platform/tests/css/css-text/word-break/word-break-break-all-010.html
+++ b/testing/web-platform/tests/css/css-text/word-break/word-break-break-all-010.html
@@ -21,16 +21,17 @@ div {
   color: red;
   width: 100px;
   height: 100px;
   z-index: -1;
 }
 .test {
   color: green;
   width: 5ch;
+
   white-space: pre-wrap;
   word-break: break-all;
 }
 </style>
 <body>
   <p>Test passes if there is a <strong>filled green square</strong> and <strong>no red</strong>.</p>
   <div class="red"> XXXX<br>X</div>
   <div class="test"> XXXXX</div>
--- a/testing/web-platform/tests/css/css-text/word-break/word-break-break-all-012.html
+++ b/testing/web-platform/tests/css/css-text/word-break/word-break-break-all-012.html
@@ -4,32 +4,32 @@
 <link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:jfernandez@igalia.com">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-word-break-break-all">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces">
 <meta name="flags" content="ahem">
 <link rel="match" href="reference/word-break-break-all-010-ref.html">
 <meta name="assert" content="The word is broken even if white-space: break-spaces provides a former breaking opportunity in leading white-space.">
 <style>
 div {
-   position: relative;
-   font-size: 20px;
-   font-family: Ahem;
+  position: relative;
+  font-size: 20px;
+  font-family: Ahem;
+  line-height: 1em;
 }
 .red {
   position: absolute;
   background: green;
   color: red;
   width: 100px;
   height: 100px;
   z-index: -1;
   white-space: pre;
 }
 .test {
   color: green;
-  line-height: 1em;
   width: 5ch;
 
   white-space: break-spaces;
   word-break: break-all;
 }
 </style>
 <body>
   <p>Test passes if there is a <strong>filled green square</strong> and <strong>no red</strong>.</p>
--- a/testing/web-platform/tests/css/css-text/word-break/word-break-break-all-013.html
+++ b/testing/web-platform/tests/css/css-text/word-break/word-break-break-all-013.html
@@ -4,32 +4,32 @@
 <link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:jfernandez@igalia.com">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-word-break-break-all">
 <link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces">
 <meta name="flags" content="ahem">
 <link rel="match" href="reference/word-break-break-all-010-ref.html">
 <meta name="assert" content="A single leading white-space should account as soft breaking opportunity, honoring the 'white-space: break-spaces', on top to the ones provided by 'word-break: break-all'.">
 <style>
 div {
-   position: relative;
-   font-size: 20px;
-   font-family: Ahem;
+  position: relative;
+  font-size: 20px;
+  font-family: Ahem;
+  line-height: 1em;
 }
 .red {
   position: absolute;
   background: green;
   color: red;
   width: 100px;
   height: 100px;
   z-index: -1;
   white-space: pre;
 }
 .test {
   color: green;
-  line-height: 1em;
   width: 1ch;
   white-space: break-spaces;
   word-break: break-all;
 }
 </style>
 <body>
   <p>Test passes if there is a <strong>filled green square</strong> and <strong>no red</strong>.</p>
   <div class="red"> <br>X<br>X</div>