Backed out changeset 3ccb231829a9 (bug 1349690)
authorCarsten "Tomcat" Book <cbook@mozilla.com>
Thu, 23 Mar 2017 08:45:41 +0100
changeset 348944 85658d613c7706ebe449c669c3818a3a8fecfc53
parent 348943 0893e7c2a3bb9abd4df4c0e90915e73f7f5fa840
child 348945 42b182f3367ec8334c28bdf4081bd7605926160f
push id88367
push usercbook@mozilla.com
push dateThu, 23 Mar 2017 07:46:16 +0000
treeherdermozilla-inbound@1e0598886d34 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1349690
milestone55.0a1
backs out3ccb231829a94c8d5aff22222ecfe0ef1f1d50a7
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 3ccb231829a9 (bug 1349690)
dom/base/ScriptSettings.cpp
--- a/dom/base/ScriptSettings.cpp
+++ b/dom/base/ScriptSettings.cpp
@@ -371,23 +371,16 @@ AutoJSAPI::InitInternal(nsIGlobalObject*
   if (haveException) {
     JS::Rooted<JS::Value> exn(aCx);
     JS_GetPendingException(aCx, &exn);
 
     JS_ClearPendingException(aCx);
     if (exn.isObject()) {
       JS::Rooted<JSObject*> exnObj(aCx, &exn.toObject());
 
-      // Make sure we can actually read things from it.  This UncheckedUwrap is
-      // safe because we're only getting data for a debug printf.  In
-      // particular, we do not expose this data to anyone, which is very
-      // important; otherwise it could be a cross-origin information leak.
-      exnObj = js::UncheckedUwrap(exnObj);
-      JSAutoCompartment ac(aCx, exnObj);
-
       nsAutoJSString stack, filename, name, message;
       int32_t line;
 
       JS::Rooted<JS::Value> tmp(aCx);
       if (!JS_GetProperty(aCx, exnObj, "filename", &tmp)) {
         JS_ClearPendingException(aCx);
       }
       if (tmp.isUndefined()) {