Bug 839434 - Set the isPrivate flag when showing popups on Firefox for Android. r=mleibovic
authorAbir Viqar <abiviq@hushmail.com>
Thu, 02 May 2013 20:33:52 -0400
changeset 130685 855e266af240024169d561479f07a36cc2f10658
parent 130684 898891617618b587075590f003ac28ef554a3a9a
child 130686 6a3351e5b033cc8f2c5c303c94906b87f7d96457
push id27490
push userryanvm@gmail.com
push dateFri, 03 May 2013 00:36:23 +0000
treeherdermozilla-inbound@11bbf55bbad1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmleibovic
bugs839434
milestone23.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 839434 - Set the isPrivate flag when showing popups on Firefox for Android. r=mleibovic
mobile/android/chrome/content/browser.js
--- a/mobile/android/chrome/content/browser.js
+++ b/mobile/android/chrome/content/browser.js
@@ -5377,17 +5377,18 @@ var PopupBlockerObserver = {
         // useful to the user, so we won't create a menu item for it.
         if (popupURIspec == "" || popupURIspec == "about:blank" || popupURIspec == uri.spec)
           continue;
 
         let popupFeatures = pageReport[i].popupWindowFeatures;
         let popupName = pageReport[i].popupWindowName;
 
         let parent = BrowserApp.selectedTab;
-        BrowserApp.addTab(popupURIspec, { parentId: parent.id });
+        let isPrivate = PrivateBrowsingUtils.isWindowPrivate(parent.browser.contentWindow);
+        BrowserApp.addTab(popupURIspec, { parentId: parent.id, isPrivate: isPrivate });
       }
     }
   }
 };
 
 
 var IndexedDB = {
   _permissionsPrompt: "indexedDB-permissions-prompt",