Bug 851892 followup to placate static analysis and reopen the CLOSED TREE.
authorBoris Zbarsky <bzbarsky@mit.edu>
Fri, 13 Jan 2017 11:08:01 -0500
changeset 329316 855a521093782f84db7226144ea1bfe6444457ba
parent 329315 e7da58c2df9a502237616a45e8957775bb65e634
child 329317 7a82c1099a05d9dfa32a3d04ab79db22b29a31ba
push id85677
push userbzbarsky@mozilla.com
push dateFri, 13 Jan 2017 16:08:10 +0000
treeherdermozilla-inbound@855a52109378 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs851892
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 851892 followup to placate static analysis and reopen the CLOSED TREE.
layout/style/BindingStyleRule.h
--- a/layout/style/BindingStyleRule.h
+++ b/layout/style/BindingStyleRule.h
@@ -28,16 +28,22 @@ protected:
   }
   BindingStyleRule(const BindingStyleRule& aCopy)
     : css::Rule(aCopy)
   {
   }
   virtual ~BindingStyleRule() {}
 
 public:
+  // This is pure virtual because we have no members, and are an abstract class
+  // to start with.  The fact that we have to have this declaration at all is
+  // kinda dumb.  :(
+  virtual size_t SizeOfIncludingThis(mozilla::MallocSizeOf aMallocSizeOf)
+    const MOZ_MUST_OVERRIDE = 0;
+
   // WebIDL API
   // For GetSelectorText/SetSelectorText, we purposefully use a signature that
   // matches the nsIDOMCSSStyleRule one for now, so subclasses can just
   // implement both at once.  The actual implementations must never return
   // anything other than NS_OK;
   NS_IMETHOD GetSelectorText(nsAString& aSelectorText) = 0;
   NS_IMETHOD SetSelectorText(const nsAString& aSelectorText) = 0;
   virtual nsICSSDeclaration* Style() = 0;