Bug 1596800 - Remove unneeded forced layout flush in PluginChild.jsm. r=mconley
authorEmilio Cobos Álvarez <emilio@crisal.io>
Mon, 18 Nov 2019 19:06:50 +0000
changeset 502470 85408aaba4a32de2ecf495093f24643e93154292
parent 502469 5a76ddcb1ac13213e905126cf8e5136ee3b7f6f1
child 502471 5bc4fbe48df7276c4b6da448e9b85953620ac913
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley
bugs1596800
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1596800 - Remove unneeded forced layout flush in PluginChild.jsm. r=mconley We don't need layout flushes to attach XBL bindings anymore, as there are no XBL bindings. This is drive-by. Depends on D53336 Differential Revision: https://phabricator.services.mozilla.com/D53337
browser/actors/PluginChild.jsm
--- a/browser/actors/PluginChild.jsm
+++ b/browser/actors/PluginChild.jsm
@@ -946,18 +946,16 @@ class PluginChild extends JSWindowActorC
     this.setCrashedNPAPIPluginState({
       pluginElement: target,
       state: crashData.state,
       pluginName: crashData.pluginName,
     });
   }
 
   setCrashedNPAPIPluginState({ pluginElement, state, pluginName }) {
-    // Force a layout flush so the binding is attached.
-    pluginElement.clientTop;
     let overlay = this.getPluginUI(pluginElement, "main");
     let statusDiv = this.getPluginUI(pluginElement, "submitStatus");
     let optInCB = this.getPluginUI(pluginElement, "submitURLOptIn");
 
     this.getPluginUI(pluginElement, "submitButton").addEventListener(
       "click",
       event => {
         if (event.button != 0 || !event.isTrusted) {