Bug 798356 - Do not convert a boolean literal into a null pointer constant in TransportDIB::Map; r=cjones
authorEhsan Akhgari <ehsan@mozilla.com>
Fri, 05 Oct 2012 16:15:34 -0400
changeset 109430 82f88f349519207bca3adae03214224ebb5c3b19
parent 109429 b9d3402e928530e125865950b08de731a60c853e
child 109431 747ca210aaa08de3ce0ffd921d3e53b194da1183
push id16025
push usereakhgari@mozilla.com
push dateFri, 05 Oct 2012 20:20:45 +0000
treeherdermozilla-inbound@1ddc6403c060 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscjones
bugs798356
milestone18.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 798356 - Do not convert a boolean literal into a null pointer constant in TransportDIB::Map; r=cjones
ipc/chromium/src/chrome/common/transport_dib_mac.cc
--- a/ipc/chromium/src/chrome/common/transport_dib_mac.cc
+++ b/ipc/chromium/src/chrome/common/transport_dib_mac.cc
@@ -39,17 +39,17 @@ TransportDIB* TransportDIB::Create(size_
 TransportDIB* TransportDIB::Map(TransportDIB::Handle handle) {
   TransportDIB* dib = new TransportDIB(handle);
   struct stat st;
   fstat(handle.fd, &st);
 
   if (!dib->shared_memory_.Map(st.st_size)) {
     delete dib;
     HANDLE_EINTR(close(handle.fd));
-    return false;
+    return nullptr;
   }
 
   dib->size_ = st.st_size;
 
   return dib;
 }
 
 void* TransportDIB::memory() const {