Bug 1477131 [wpt PR 12076] - Fix typo in panner-distance-clampling.html test, a=testonly
authorRaymond Toy <rtoy@chromium.org>
Wed, 25 Jul 2018 17:54:25 +0000
changeset 429038 80283f276cf7776ae6634bcd4e88fa16dca2a87f
parent 429037 4a9903a5c8c5bd859dea1b1f12846b7740b7ee32
child 429039 1819ff0583e47d14f6ff7f2f4eb4873db2df4a8b
push id105805
push userjames@hoppipolla.co.uk
push dateSun, 29 Jul 2018 18:28:58 +0000
treeherdermozilla-inbound@7ca03e42cbdf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1477131, 12076, 865371, 1144128, 576856
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1477131 [wpt PR 12076] - Fix typo in panner-distance-clampling.html test, a=testonly Automatic update from web-platform-testsFix typo in panner-distance-clampling.html test The should.throw() method now expects an actual error object instead of a string and I think someone just forgot to change the 'RangeError' strings in this test to be just the RangeError object. Bug: 865371 Test: test passes again Change-Id: I07cc057ff4f608a01ed3f35a0268b6e267078d13 Reviewed-on: https://chromium-review.googlesource.com/1144128 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#576856} -- wpt-commits: 0a5194d5b94f64d36cf0fd399b650fc53f1d7bd0 wpt-pr: 12076
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -624650,17 +624650,17 @@
    "43edf7a7bef1f4e9989b048c571659c83ad234f2",
    "testharness"
   ],
   "webaudio/the-audio-api/the-pannernode-interface/panner-automation-position.html": [
    "81123665ad1f8201907251ddb0bb2707b14925e1",
    "testharness"
   ],
   "webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping.html": [
-   "820c902b9bcfeed9611ec9c3cba3ee2179a8cee7",
+   "7ea63964142ab76e3883bef9e73c2e8e0b28ea96",
    "testharness"
   ],
   "webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-stereo.html": [
    "ebe3d2622a8bdc3802159fa0809c1aea28053b09",
    "testharness"
   ],
   "webaudio/the-audio-api/the-pannernode-interface/panner-equalpower.html": [
    "28120d05419bb478f49f6bb2449fdf282af6624e",
--- a/testing/web-platform/tests/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping.html
+++ b/testing/web-platform/tests/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping.html
@@ -33,55 +33,55 @@
 
         let attrName = options.name;
         let prefix = 'new PannerNode(c, {' + attrName + ': ';
 
         should(function() {
           let nodeOptions = {};
           nodeOptions[attrName] = -1;
           new PannerNode(context, nodeOptions);
-        }, prefix + '-1})').throw('RangeError');
+        }, prefix + '-1})').throw(RangeError);
 
         if (options.isZeroAllowed) {
           should(function() {
             let nodeOptions = {};
             nodeOptions[attrName] = 0;
             new PannerNode(context, nodeOptions);
           }, prefix + '0})').notThrow();
         } else {
           should(function() {
             let nodeOptions = {};
             nodeOptions[attrName] = 0;
             new PannerNode(context, nodeOptions);
-          }, prefix + '0})').throw('RangeError');
+          }, prefix + '0})').throw(RangeError);
         }
 
         // The smallest representable positive single float.
         let leastPositiveDoubleFloat = 4.9406564584124654e-324;
 
         should(function() {
           let nodeOptions = {};
           nodeOptions[attrName] = leastPositiveDoubleFloat;
           new PannerNode(context, nodeOptions);
         }, prefix + leastPositiveDoubleFloat + '})').notThrow();
 
         prefix = 'panner.' + attrName + ' = ';
         panner = new PannerNode(context);
         should(function() {
           panner[attrName] = -1;
-        }, prefix + '-1').throw('RangeError');
+        }, prefix + '-1').throw(RangeError);
 
         if (options.isZeroAllowed) {
           should(function() {
             panner[attrName] = 0;
           }, prefix + '0').notThrow();
         } else {
           should(function() {
             panner[attrName] = 0;
-          }, prefix + '0').throw('RangeError');
+          }, prefix + '0').throw(RangeError);
         }
 
         should(function() {
           panner[attrName] = leastPositiveDoubleFloat;
         }, prefix + leastPositiveDoubleFloat).notThrow();
       }
 
       audit.define('min-distance', (task, should) => {