Bug 1211330 - Moved 'unset' invalid values from background-image alone to shared invalidGradientAndElementValues - r=heycam
authorGerald Squelart <gsquelart@mozilla.com>
Tue, 03 Jul 2018 10:40:33 +1000
changeset 424853 7ff340d8288f43f9e72b5ba9179b97c910ca08d1
parent 424852 bd647d6acb5afed9f4ba1ad8dd73d1e8d67875a1
child 424854 4f695620856d81f7457cc7f2f194b664009d633c
push id104933
push usershindli@mozilla.com
push dateTue, 03 Jul 2018 22:35:47 +0000
treeherdermozilla-inbound@00de580e868f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersheycam
bugs1211330
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1211330 - Moved 'unset' invalid values from background-image alone to shared invalidGradientAndElementValues - r=heycam This expands the testing of 'unset' invalid values to border-image-source, mask-image, and shape-outside. MozReview-Commit-ID: 3tcHnCgr6Dh
layout/style/test/property_database.js
--- a/layout/style/test/property_database.js
+++ b/layout/style/test/property_database.js
@@ -287,16 +287,20 @@ var invalidGradientAndElementValues = [
   "linear-gradient(.414rad bottom, red, blue)",
 
   "linear-gradient(to top, 0%, blue)",
   "linear-gradient(to top, red, 100%)",
   "linear-gradient(to top, red, 45%, 56%, blue)",
   "linear-gradient(to top, red,, blue)",
   "linear-gradient(to top, red, green 35%, 15%, 54%, blue)",
 
+  "linear-gradient(unset, 10px 10px, from(blue))",
+  "linear-gradient(unset, 10px 10px, blue 0)",
+  "repeating-linear-gradient(unset, 10px 10px, blue 0)",
+
 
   "radial-gradient(top left 45deg, red, blue)",
   "radial-gradient(20% bottom -300deg, red, blue)",
   "radial-gradient(center 20% 1.95929rad, red, blue)",
   "radial-gradient(left 35px 30grad, red, blue)",
   "radial-gradient(10% 10em 99999deg, red, blue)",
   "radial-gradient(44px top -33deg, red, blue)",
 
@@ -2745,17 +2749,17 @@ var gCSSProperties = {
     other_values: [
     "url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAIAAAD8GO2jAAAAKElEQVR42u3NQQ0AAAgEoNP+nTWFDzcoQE1udQQCgUAgEAgEAsGTYAGjxAE/G/Q2tQAAAABJRU5ErkJggg==)", "url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAIAAAD8GO2jAAAAKElEQVR42u3NQQ0AAAgEoNP+nTWFDzcoQE1udQQCgUAgEAgEAsGTYAGjxAE/G/Q2tQAAAABJRU5ErkJggg==')", 'url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAIAAAD8GO2jAAAAKElEQVR42u3NQQ0AAAgEoNP+nTWFDzcoQE1udQQCgUAgEAgEAsGTYAGjxAE/G/Q2tQAAAABJRU5ErkJggg==")',
     "none, none",
     "none, none, none, none, none",
     "url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAIAAAD8GO2jAAAAKElEQVR42u3NQQ0AAAgEoNP+nTWFDzcoQE1udQQCgUAgEAgEAsGTYAGjxAE/G/Q2tQAAAABJRU5ErkJggg==), none",
     "none, url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAIAAAD8GO2jAAAAKElEQVR42u3NQQ0AAAgEoNP+nTWFDzcoQE1udQQCgUAgEAgEAsGTYAGjxAE/G/Q2tQAAAABJRU5ErkJggg==), none",
     "url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAIAAAD8GO2jAAAAKElEQVR42u3NQQ0AAAgEoNP+nTWFDzcoQE1udQQCgUAgEAgEAsGTYAGjxAE/G/Q2tQAAAABJRU5ErkJggg==), url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAIAAAD8GO2jAAAAKElEQVR42u3NQQ0AAAgEoNP+nTWFDzcoQE1udQQCgUAgEAgEAsGTYAGjxAE/G/Q2tQAAAABJRU5ErkJggg==)",
     ].concat(validGradientAndElementValues),
-    invalid_values: [ "linear-gradient(unset, 10px 10px, from(blue))", "linear-gradient(unset, 10px 10px, blue 0)", "repeating-linear-gradient(unset, 10px 10px, blue 0)"
+    invalid_values: [
     ].concat(invalidGradientAndElementValues),
     unbalanced_values: [
     ].concat(unbalancedGradientAndElementValues)
   },
   "background-origin": {
     domProp: "backgroundOrigin",
     inherited: false,
     type: CSS_TYPE_LONGHAND,