Bug 1530914 - Highlighted resource information is difficult to read when blocked. r=Honza
authorlloan <lloanalas@outlook.com>
Fri, 17 May 2019 06:50:40 +0000
changeset 474299 7fdd2abe918b6ba220dd097d27d1a2cda6cfa8e6
parent 474298 eeb6dd82b7c1a9fc36610bfe1ccecdf93c356677
child 474300 d5a1f414d631aa02482f1c650387bc14c5e31b62
push id113144
push usershindli@mozilla.com
push dateFri, 17 May 2019 16:44:55 +0000
treeherdermozilla-inbound@f4c4b796f845 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza
bugs1530914, 9063611
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1530914 - Highlighted resource information is difficult to read when blocked. r=Honza When looking at the resource listing, and there's a blocked item, it is difficult to read the pink text. Before: https://bug1530914.bmoattachments.org/attachment.cgi?id=9063611 Now: https://i.imgur.com/znNx8aQ.png Differential Revision: https://phabricator.services.mozilla.com/D31354
devtools/client/netmonitor/src/assets/styles/RequestList.css
--- a/devtools/client/netmonitor/src/assets/styles/RequestList.css
+++ b/devtools/client/netmonitor/src/assets/styles/RequestList.css
@@ -464,37 +464,41 @@
 
 /* Request list item */
 
 .request-list-item {
   height: 24px;
   line-height: 24px;
 }
 
-.request-list-item.selected {
-  background-color: var(--theme-selection-background);
-  color: var(--theme-selection-color);
-}
-
 .request-list-item:not(.selected).odd {
   background-color: var(--table-zebra-background);
 }
 
 .request-list-item:not(.selected):hover {
   background-color: var(--table-selection-background-hover);
 }
 
 .request-list-item:not(.selected).fromCache > .requests-list-column:not(.requests-list-waterfall) {
   opacity: 0.7;
 }
 
 .request-list-item.blocked {
   color: var(--timing-blocked-color);
 }
 
+/*
+ * Put ahead of .request-list-item.blocked to avoid specificity conflict.
+ * Bug 1530914 - Highlighted Security Value is difficult to read.
+ */
+.request-list-item.selected {
+  background-color: var(--theme-selection-background);
+  color: var(--theme-selection-color);
+}
+
 /* Responsive web design support */
 
 @media (max-width: 700px) {
   .requests-list-status-code {
     width: auto;
   }
 
   .requests-list-size {