Bug 1438682 - 2. Implement dummy closeConnection; r=esawin
authorJim Chen <nchen@mozilla.com>
Thu, 15 Feb 2018 18:06:07 -0500
changeset 404262 7ea185f4bce1e1ddaa8927b4e0f4e5068d04d8ca
parent 404261 f066f679fb044cef576f467979808003a63e8de0
child 404263 a7f80d59de443854464dc6c4635b5d0a3650a05d
push id99968
push userrgurzau@mozilla.com
push dateFri, 16 Feb 2018 22:14:56 +0000
treeherdermozilla-inbound@2e16779c96cc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersesawin
bugs1438682
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1438682 - 2. Implement dummy closeConnection; r=esawin closeConnection is a new API introduced in N. We don't really support it at the moment but we also don't want the default behavior, so we implement a dummy. MozReview-Commit-ID: JY1Tl30X2s7
mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoInputConnection.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoInputConnection.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoInputConnection.java
@@ -538,16 +538,22 @@ import android.view.inputmethod.InputMet
     public Handler getHandler(Handler defHandler) {
         if (!canReturnCustomHandler()) {
             return defHandler;
         }
 
         return getHandler();
     }
 
+    // Android N: @Override // InputConnection
+    @SuppressLint("Override")
+    public void closeConnection() {
+        // Not supported at the moment.
+    }
+
     @Override // TextInputController.Delegate
     public synchronized InputConnection onCreateInputConnection(EditorInfo outAttrs) {
         // Some keyboards require us to fill out outAttrs even if we return null.
         outAttrs.inputType = InputType.TYPE_CLASS_TEXT;
         outAttrs.imeOptions = EditorInfo.IME_ACTION_NONE;
         outAttrs.actionLabel = null;
 
         if (mIMEState == IME_STATE_DISABLED) {