Bug 1450856 - Fix PromptDelegate.onExternalResponse() for non-e10s r=esawin
authorJames Willcox <snorp@snorp.net>
Thu, 03 May 2018 12:26:40 -0500
changeset 416819 7d21cb6d11c2a5406f5bbb68ed060392e0dc321b
parent 416818 3550cb0d54d45808dcf609eaf1fb4c0028e7d48a
child 416820 3405310200b7b0af4cbfcceca7c7b1345423d141
push id102878
push userjwillcox@mozilla.com
push dateThu, 03 May 2018 21:29:15 +0000
treeherdermozilla-inbound@7d21cb6d11c2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersesawin
bugs1450856
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1450856 - Fix PromptDelegate.onExternalResponse() for non-e10s r=esawin MozReview-Commit-ID: FFuX0fviAgj
mobile/android/components/geckoview/GeckoViewExternalAppService.js
--- a/mobile/android/components/geckoview/GeckoViewExternalAppService.js
+++ b/mobile/android/components/geckoview/GeckoViewExternalAppService.js
@@ -18,22 +18,20 @@ function ExternalAppService() {
 }
 
 ExternalAppService.prototype = {
   classID: Components.ID("{a89eeec6-6608-42ee-a4f8-04d425992f45}"),
   QueryInterface: ChromeUtils.generateQI([Ci.nsIExternalHelperAppService]),
 
   doContent(mimeType, request, context, forceSave) {
     const channel = request.QueryInterface(Ci.nsIChannel);
-    const mm = context.QueryInterface(Ci.nsIDocShell).tabChild.messageManager;
-
     debug `doContent: uri=${channel.URI.displaySpec}
                       contentType=${channel.contentType}`;
 
-    EventDispatcher.forMessageManager(mm).sendRequest({
+    GeckoViewUtils.getDispatcherForWindow(context).sendRequest({
       type: "GeckoView:ExternalResponse",
       uri: channel.URI.displaySpec,
       contentType: channel.contentType,
       contentLength: channel.contentLength,
       filename: channel.contentDispositionFilename
     });
 
     request.cancel(Cr.NS_ERROR_ABORT);