Bug 1573902 - Fix CDM Init return value name in IPDL. r=dminor
authorBryce Seager van Dyk <bvandyk@mozilla.com>
Wed, 14 Aug 2019 19:35:07 +0000
changeset 488103 7c287afc3556403098d8f26c382b119aa8d6c3ec
parent 488102 d14199c9c1cc887fb8e67298e970429848a0d591
child 488104 c9f306364c7d79c316cedb484da364944909a1a4
push id113900
push usercbrindusan@mozilla.com
push dateThu, 15 Aug 2019 09:53:50 +0000
treeherdermozilla-inbound@0db07ff50ab5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdminor
bugs1573902
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1573902 - Fix CDM Init return value name in IPDL. r=dminor The return value for PChromiumCDM::Init was unused when the IPDL change was first made. However, that quickly changed, but I failed to update the IPDL to reflect that the value is now used to propagate the value that CDM interface 10 Widevine modules give us via the OnInitialized callback. This patch fixes the IPDL to reflect that. The changes in C++ code have already been made, so no change needed there. Differential Revision: https://phabricator.services.mozilla.com/D41995
dom/media/gmp/PChromiumCDM.ipdl
--- a/dom/media/gmp/PChromiumCDM.ipdl
+++ b/dom/media/gmp/PChromiumCDM.ipdl
@@ -11,17 +11,17 @@ namespace gmp {
 
 async refcounted protocol PChromiumCDM
 {
   manager PGMPContent;
 child:
 
   // cdm::ContentDecryptionModule9+10
   async Init(bool aAllowDistinctiveIdentifier,
-             bool aAllowPersistentState) returns (bool unused);
+             bool aAllowPersistentState) returns (bool aSuccess);
 
   async GetStatusForPolicy(uint32_t aPromiseId,
                            nsCString aMinHdcpVersion);
 
   async SetServerCertificate(uint32_t aPromiseId,
                              uint8_t[] aServerCert);
 
   async CreateSessionAndGenerateRequest(uint32_t aPromiseId,