Backed out 2 changesets (bug 1591925) for failures on select-element-zero-height-001.html. CLOSED TREE
authorCsoregi Natalia <ncsoregi@mozilla.com>
Thu, 14 Nov 2019 05:11:41 +0200
changeset 501877 771c82ef46a350365f7aad056eb30cea2fae820c
parent 501876 3cf4cf89e8ea13ac159ef96d9688d51403ad5994
child 501878 aa0f3547216405f94d08eb7e93bb52675e0de413
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1591925
milestone72.0a1
backs outb2d168294899bb4700cb3bd929c0bde85879fcea
bbeb8f3081930de9728f5c0f1653dc467f7eac23
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 2 changesets (bug 1591925) for failures on select-element-zero-height-001.html. CLOSED TREE Backed out changeset b2d168294899 (bug 1591925) Backed out changeset bbeb8f308193 (bug 1591925)
layout/generic/nsFlexContainerFrame.cpp
testing/web-platform/meta/css/css-flexbox/select-element-zero-height-001.html.ini
testing/web-platform/tests/css/css-flexbox/select-element-zero-height-001-ref.html
testing/web-platform/tests/css/css-flexbox/select-element-zero-height-001.html
testing/web-platform/tests/css/css-flexbox/select-element-zero-height-002-ref.html
testing/web-platform/tests/css/css-flexbox/select-element-zero-height-002.html
--- a/layout/generic/nsFlexContainerFrame.cpp
+++ b/layout/generic/nsFlexContainerFrame.cpp
@@ -2088,29 +2088,28 @@ void FlexItem::CheckForMinSizeAuto(const
                                    const FlexboxAxisTracker& aAxisTracker) {
   const nsStylePosition* pos = aFlexItemReflowInput.mStylePosition;
   const nsStyleDisplay* disp = aFlexItemReflowInput.mStyleDisplay;
 
   // We'll need special behavior for "min-[width|height]:auto" (whichever is in
   // the flex container's main axis) iff:
   // (a) its computed value is "auto"
   // (b) the "overflow" sub-property in the same axis (the main axis) has a
-  //     computed value of "visible" and the item does not create a scroll
-  //     container.
+  //     computed value of "visible"
   const auto& mainMinSize = aAxisTracker.IsRowOriented()
                                 ? pos->MinISize(aAxisTracker.GetWritingMode())
                                 : pos->MinBSize(aAxisTracker.GetWritingMode());
 
-  // If the scrollable overflow makes us create a scroll container, then we
-  // don't need to do any extra resolution for our `min-size:auto` value.
-  // We don't need to check for scrollable overflow in a particular axis
-  // because this will be true for both or neither axis.
+  // NOTE: Technically we should be checking the 'overflow' subproperty in the
+  // main axis. But since we only care whether it's 'visible', we can check
+  // either subproperty -- because they must be BOTH 'visible' or BOTH
+  // non-'visible' due to the way the subproperties interact.
   mNeedsMinSizeAutoResolution =
       IsAutoOrEnumOnBSize(mainMinSize, IsInlineAxisMainAxis()) &&
-      !disp->IsScrollableOverflow();
+      disp->mOverflowX == StyleOverflow::Visible;
 }
 
 nscoord FlexItem::GetBaselineOffsetFromOuterCrossEdge(
     AxisEdgeType aEdge, const FlexboxAxisTracker& aAxisTracker,
     bool aUseFirstLineBaseline) const {
   // NOTE:
   //  * We only use baselines for aligning in the flex container's cross axis.
   //  * Baselines are a measurement in the item's block axis.
deleted file mode 100644
--- a/testing/web-platform/meta/css/css-flexbox/select-element-zero-height-001.html.ini
+++ /dev/null
@@ -1,3 +0,0 @@
-[select-element-zero-height-001.html]
-  expected: FAIL
-  bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1596255
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-flexbox/select-element-zero-height-001-ref.html
+++ /dev/null
@@ -1,14 +0,0 @@
-<!DOCTYPE html>
-<title>Reference: Select element in flexbox with zero height</title>
-<link rel="author" title="Mozilla" href="https://mozilla.org">
-<style>
-  .container {
-    height: 0px;
-    border: 1px dotted black;
-  }
-</style>
-<body>
-  <div class="container">
-    <select style="width:100%"><option>Hi</option></select>
-  </div>
-</body>
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-flexbox/select-element-zero-height-001.html
+++ /dev/null
@@ -1,19 +0,0 @@
-<!DOCTYPE html>
-<title>Select element in flexbox with zero height</title>
-<link rel="author" title="Mozilla" href="https://mozilla.org">
-<link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1591925">
-<link rel="help" href="https://drafts.csswg.org/css-flexbox/#content-size-suggestion">
-<link rel="match" href="select-element-zero-height-001-ref.html">
-<style>
-  .container {
-    display: flex;
-    flex-direction: column;
-    height: 0px;
-    border: 1px dotted black;
-  }
-</style>
-<body>
-  <div class="container">
-    <select><option>Hi</option></select>
-  </div>
-</body>
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-flexbox/select-element-zero-height-002-ref.html
+++ /dev/null
@@ -1,18 +0,0 @@
-<!DOCTYPE html>
-<title>Reference: Select element with background color in flexbox with zero height</title>
-<link rel="author" title="Mozilla" href="https://mozilla.org">
-<style>
-  .container {
-    height: 0px;
-    border: 1px dotted black;
-  }
-  .with-background {
-    width: 100%;
-    background: lime;
-  }
-</style>
-<body>
-  <div class="container">
-    <select class="with-background"><option>Hi</option></select>
-  </div>
-</body>
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-flexbox/select-element-zero-height-002.html
+++ /dev/null
@@ -1,22 +0,0 @@
-<!DOCTYPE html>
-<title>Select element with background color in flexbox with zero height</title>
-<link rel="author" title="Mozilla" href="https://mozilla.org">
-<link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1591925">
-<link rel="help" href="https://drafts.csswg.org/css-flexbox/#content-size-suggestion">
-<link rel="match" href="select-element-zero-height-002-ref.html">
-<style>
-  .container {
-    display: flex;
-    flex-direction: column;
-    height: 0px;
-    border: 1px dotted black;
-  }
-  .with-background {
-    background: lime;
-  }
-</style>
-<body>
-  <div class="container">
-    <select class="with-background"><option>Hi</option></select>
-  </div>
-</body>