Bug 531479 - Always return exit status of the app, not the stack fixer process. r=dbaron
authorJesse Ruderman <jruderman@gmail.com>
Sun, 29 Nov 2009 13:29:03 -0800
changeset 35275 76795c16848701af4da70afd1121191389865b1f
parent 35274 d2a7652d726a6b005958d50abb84faeb68881637
child 35276 091a108677adf16e9b0bb2e3f52c0ae7bd356a13
push idunknown
push userunknown
push dateunknown
reviewersdbaron
bugs531479
milestone1.9.3a1pre
Bug 531479 - Always return exit status of the app, not the stack fixer process. r=dbaron
build/automation.py.in
--- a/build/automation.py.in
+++ b/build/automation.py.in
@@ -605,19 +605,19 @@ def runApp(testURL, env, app, profileDir
     if didTimeout:
       log.info("TEST-UNEXPECTED-FAIL | automation.py | application timed out after %d seconds with no output", int(timeout))
       triggerBreakpad(proc, utilityPath)
 
   status = proc.wait()
   if status != 0 and not didTimeout:
     log.info("TEST-UNEXPECTED-FAIL | automation.py | Exited with code %d during test run", status)
   if stackFixerProcess is not None:
-    status = stackFixerProcess.wait()
-    if status != 0 and not didTimeout:
-      log.info("TEST-UNEXPECTED-FAIL | automation.py | Stack fixer process exited with code %d during test run", status)
+    fixerStatus = stackFixerProcess.wait()
+    if fixerStatus != 0 and not didTimeout:
+      log.info("TEST-UNEXPECTED-FAIL | automation.py | Stack fixer process exited with code %d during test run", fixerStatus)
   log.info("INFO | automation.py | Application ran for: %s", str(datetime.now() - startTime))
 
   if checkForCrashes(os.path.join(profileDir, "minidumps"), symbolsPath):
     status = -1
 
   if IS_TEST_BUILD and runSSLTunnel:
     ssltunnelProcess.kill()