Bug 1475033 part 5 - Remove scrollbarbutton min-{width,height} rule. r=jimm
authorXidorn Quan <me@upsuper.org>
Mon, 06 Aug 2018 14:21:40 +1000
changeset 432083 76149510c0f0a2f7843bacb06239106f1013bd4e
parent 432082 665ba9179f6f06ab22a23c606c3dd141c63c6cea
child 432084 1972d9de2b1014ffd032565578d4ca1d5016e846
push id106627
push userebalazs@mozilla.com
push dateFri, 17 Aug 2018 09:52:13 +0000
treeherdermozilla-inbound@b84213ec5a4d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjimm
bugs1475033
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1475033 part 5 - Remove scrollbarbutton min-{width,height} rule. r=jimm Almost all widgets provide a non-overridable size for scrollbar buttons, so it makes no sense to specify min size for them. It is probably a layout bug that min size properties can override the value returned by GetMinimumWidgetSize even if aIsOverridable is set to false, but removing this rule is simpler than locating and fixing the issue in layout code :) MozReview-Commit-ID: 58pmxQaHlGe
toolkit/themes/windows/global/xulscrollbars.css
--- a/toolkit/themes/windows/global/xulscrollbars.css
+++ b/toolkit/themes/windows/global/xulscrollbars.css
@@ -48,23 +48,16 @@ thumb[orient="vertical"] {
   min-height: 8px;
 }
 
 thumb[orient="horizontal"] {
   -moz-appearance: scrollbarthumb-horizontal;
   min-width: 8px;
 }
 
-/* ::::: scrollbar button ::::: */
-
-scrollbarbutton {
-  min-width: 16px;
-  min-height: 16px;
-}
-
 /* ::::: square at the corner of two scrollbars ::::: */
 
 scrollcorner {
   -moz-appearance: scrollcorner;
   width: 16px;
   cursor: default;
   background-color: -moz-Dialog;
 }